public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: simona@ffwll.ch, devicetree@vger.kernel.org,
	p.zabel@pengutronix.de,  junzhi.zhao@mediatek.com,
	mripard@kernel.org, matthias.bgg@gmail.com,
	 linux-kernel@vger.kernel.org, tzimmermann@suse.de,
	krzk+dt@kernel.org,  dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,  airlied@gmail.com,
	chunkuang.hu@kernel.org, conor+dt@kernel.org,
	 kernel@collabora.com, jitao.shi@mediatek.com,
	 maarten.lankhorst@linux.intel.com, ck.hu@mediatek.com,
	 linux-mediatek@lists.infradead.org, jie.qiu@mediatek.com
Subject: Re: [PATCH v2 07/15] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2
Date: Thu, 05 Dec 2024 07:33:52 -0600	[thread overview]
Message-ID: <173340563286.3304541.16351309995499835638.robh@kernel.org> (raw)
In-Reply-To: <20241205114518.53527-8-angelogioacchino.delregno@collabora.com>


On Thu, 05 Dec 2024 12:45:09 +0100, AngeloGioacchino Del Regno wrote:
> Add a binding for the HDMI TX v2 Encoder found in MediaTek MT8195
> and MT8188 SoCs.
> 
> This fully supports the HDMI Specification 2.0b, hence it provides
> support for 3D-HDMI, Polarity inversion, up to 16 bits Deep Color,
> color spaces including RGB444, YCBCR420/422/444 (ITU601/ITU709) and
> xvYCC, with output resolutions up to 3840x2160p@60Hz.
> 
> Moreover, it also supports HDCP 1.4 and 2.3, Variable Refresh Rate
> (VRR) and Consumer Electronics Control (CEC).
> 
> This IP also includes support for HDMI Audio, including IEC60958
> and IEC61937 SPDIF, 8-channel PCM, DSD, and other lossless audio
> according to HDMI 2.0.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../mediatek/mediatek,mt8195-hdmi.yaml        | 154 ++++++++++++++++++
>  1 file changed, 154 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.example.dtb: hdmi-tx@1c300000: i2c: False schema does not allow {'compatible': ['mediatek,mt8195-hdmi-ddc'], 'clocks': [[4294967295]]}
	from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.example.dtb: hdmi-tx@1c300000: i2c: Unevaluated properties are not allowed ('clocks', 'compatible' were unexpected)
	from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi.yaml#
Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.example.dtb: /example-0/soc/hdmi-tx@1c300000/i2c: failed to match any schema with compatible: ['mediatek,mt8195-hdmi-ddc']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241205114518.53527-8-angelogioacchino.delregno@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-12-05 13:33 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 11:45 [PATCH v2 00/15] Add support for MT8195/88 DPI, HDMIv2 and DDCv2 AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 01/15] dt-bindings: display: mediatek: dpi: Add MT8195 and MT8188 compat AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 02/15] drm/mediatek: mtk_dpi: Add support for Pattern Generator in debugfs AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 03/15] drm/mediatek: mtk_dpi: Use an array for pixclk factor calculation AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 04/15] drm/mediatek: mtk_dpi: Move pixel clock setting flow to function AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 05/15] drm/mediatek: mtk_dpi: Add checks for reg_h_fre_con existence AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 06/15] drm/mediatek: Add support for MT8195 Digital Parallel Interface AngeloGioacchino Del Regno
2024-12-09  2:32   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 07/15] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2 AngeloGioacchino Del Regno
2024-12-05 13:33   ` Rob Herring (Arm) [this message]
2024-12-09  3:26   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 08/15] drm/mediatek: mtk_cec: Switch to register as module_platform_driver AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 09/15] drm/mediatek: mtk_hdmi_ddc: " AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 10/15] drm/mediatek: hdmi: Use regmap instead of iomem for main registers AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 11/15] drm/mediatek: mtk_hdmi: Fix typo for aud_sampe_size member AngeloGioacchino Del Regno
2024-12-09  6:00   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 12/15] drm/mediatek: mtk_hdmi: Split driver and add common probe function AngeloGioacchino Del Regno
2024-12-05 12:29   ` Dmitry Baryshkov
2024-12-05 12:36     ` AngeloGioacchino Del Regno
2024-12-05 12:56       ` Dmitry Baryshkov
2024-12-09  7:05   ` CK Hu (胡俊光)
2024-12-09  7:19   ` CK Hu (胡俊光)
2024-12-09  7:51   ` CK Hu (胡俊光)
2024-12-11  2:46   ` CK Hu (胡俊光)
2024-12-13  8:43   ` CK Hu (胡俊光)
2024-12-16  6:05   ` CK Hu (胡俊光)
2024-12-16  7:38   ` CK Hu (胡俊光)
2024-12-17  1:55   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 13/15] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge AngeloGioacchino Del Regno
2024-12-09  8:17   ` CK Hu (胡俊光)
2024-12-09  9:49     ` AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 14/15] drm/mediatek: mtk_hdmi_common: Add OP_HDMI, vendor and product strings AngeloGioacchino Del Regno
2024-12-09  9:09   ` CK Hu (胡俊光)
2024-12-09  9:56     ` AngeloGioacchino Del Regno
2024-12-10  1:22       ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 15/15] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188 AngeloGioacchino Del Regno
2024-12-05 12:56   ` Dmitry Baryshkov
2024-12-05 13:30     ` AngeloGioacchino Del Regno
2024-12-05 19:35       ` Dmitry Baryshkov
2024-12-09 11:33         ` AngeloGioacchino Del Regno
2024-12-09 13:08           ` Dmitry Baryshkov
2024-12-05 22:48   ` kernel test robot
2024-12-10  3:28   ` CK Hu (胡俊光)
2024-12-10  8:33     ` AngeloGioacchino Del Regno
2024-12-10  8:09   ` CK Hu (胡俊光)
2024-12-16  8:57   ` CK Hu (胡俊光)
2024-12-16 11:04     ` AngeloGioacchino Del Regno
2024-12-17  6:40       ` CK Hu (胡俊光)
2024-12-17 12:34         ` Dmitry Baryshkov
2024-12-17  6:47   ` CK Hu (胡俊光)
2024-12-17  9:21   ` CK Hu (胡俊光)
2024-12-17 14:49     ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173340563286.3304541.16351309995499835638.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jie.qiu@mediatek.com \
    --cc=jitao.shi@mediatek.com \
    --cc=junzhi.zhao@mediatek.com \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox