public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>
Cc: "robh@kernel.org" <robh@kernel.org>,
	"jie.qiu@mediatek.com" <jie.qiu@mediatek.com>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"simona@ffwll.ch" <simona@ffwll.ch>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"kernel@collabora.com" <kernel@collabora.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"junzhi.zhao@mediatek.com" <junzhi.zhao@mediatek.com>
Subject: Re: [PATCH v2 13/15] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge
Date: Mon, 9 Dec 2024 08:17:48 +0000	[thread overview]
Message-ID: <c0e144b3a90881066d0974157e66ac23f09a0fc5.camel@mediatek.com> (raw)
In-Reply-To: <20241205114518.53527-14-angelogioacchino.delregno@collabora.com>

Hi, Angelo:

On Thu, 2024-12-05 at 12:45 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> In preparation for adding the new HDMI TX v2 IP driver, assign the
> pointer to the DDC adapter to struct drm_bridge during probe.
> 
> This commit brings no functional changes.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> index 1b23ab6969ec..4f708b04f5e8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> @@ -410,6 +410,7 @@ struct mtk_hdmi *mtk_hdmi_common_probe(struct platform_device *pdev)
>         hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_HPD;
>         hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
>         hdmi->bridge.of_node = pdev->dev.of_node;
> +       hdmi->bridge.ddc = hdmi->ddc_adpt;

I don't know why only v2 driver need to assign this?
Could you point out the code where access this value?

Regards,
CK

> 
>         ret = devm_drm_bridge_add(dev, &hdmi->bridge);
>         if (ret)
> --
> 2.47.0
> 


  reply	other threads:[~2024-12-09  8:17 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 11:45 [PATCH v2 00/15] Add support for MT8195/88 DPI, HDMIv2 and DDCv2 AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 01/15] dt-bindings: display: mediatek: dpi: Add MT8195 and MT8188 compat AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 02/15] drm/mediatek: mtk_dpi: Add support for Pattern Generator in debugfs AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 03/15] drm/mediatek: mtk_dpi: Use an array for pixclk factor calculation AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 04/15] drm/mediatek: mtk_dpi: Move pixel clock setting flow to function AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 05/15] drm/mediatek: mtk_dpi: Add checks for reg_h_fre_con existence AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 06/15] drm/mediatek: Add support for MT8195 Digital Parallel Interface AngeloGioacchino Del Regno
2024-12-09  2:32   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 07/15] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2 AngeloGioacchino Del Regno
2024-12-05 13:33   ` Rob Herring (Arm)
2024-12-09  3:26   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 08/15] drm/mediatek: mtk_cec: Switch to register as module_platform_driver AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 09/15] drm/mediatek: mtk_hdmi_ddc: " AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 10/15] drm/mediatek: hdmi: Use regmap instead of iomem for main registers AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 11/15] drm/mediatek: mtk_hdmi: Fix typo for aud_sampe_size member AngeloGioacchino Del Regno
2024-12-09  6:00   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 12/15] drm/mediatek: mtk_hdmi: Split driver and add common probe function AngeloGioacchino Del Regno
2024-12-05 12:29   ` Dmitry Baryshkov
2024-12-05 12:36     ` AngeloGioacchino Del Regno
2024-12-05 12:56       ` Dmitry Baryshkov
2024-12-09  7:05   ` CK Hu (胡俊光)
2024-12-09  7:19   ` CK Hu (胡俊光)
2024-12-09  7:51   ` CK Hu (胡俊光)
2024-12-11  2:46   ` CK Hu (胡俊光)
2024-12-13  8:43   ` CK Hu (胡俊光)
2024-12-16  6:05   ` CK Hu (胡俊光)
2024-12-16  7:38   ` CK Hu (胡俊光)
2024-12-17  1:55   ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 13/15] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge AngeloGioacchino Del Regno
2024-12-09  8:17   ` CK Hu (胡俊光) [this message]
2024-12-09  9:49     ` AngeloGioacchino Del Regno
2024-12-05 11:45 ` [PATCH v2 14/15] drm/mediatek: mtk_hdmi_common: Add OP_HDMI, vendor and product strings AngeloGioacchino Del Regno
2024-12-09  9:09   ` CK Hu (胡俊光)
2024-12-09  9:56     ` AngeloGioacchino Del Regno
2024-12-10  1:22       ` CK Hu (胡俊光)
2024-12-05 11:45 ` [PATCH v2 15/15] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188 AngeloGioacchino Del Regno
2024-12-05 12:56   ` Dmitry Baryshkov
2024-12-05 13:30     ` AngeloGioacchino Del Regno
2024-12-05 19:35       ` Dmitry Baryshkov
2024-12-09 11:33         ` AngeloGioacchino Del Regno
2024-12-09 13:08           ` Dmitry Baryshkov
2024-12-05 22:48   ` kernel test robot
2024-12-10  3:28   ` CK Hu (胡俊光)
2024-12-10  8:33     ` AngeloGioacchino Del Regno
2024-12-10  8:09   ` CK Hu (胡俊光)
2024-12-16  8:57   ` CK Hu (胡俊光)
2024-12-16 11:04     ` AngeloGioacchino Del Regno
2024-12-17  6:40       ` CK Hu (胡俊光)
2024-12-17 12:34         ` Dmitry Baryshkov
2024-12-17  6:47   ` CK Hu (胡俊光)
2024-12-17  9:21   ` CK Hu (胡俊光)
2024-12-17 14:49     ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0e144b3a90881066d0974157e66ac23f09a0fc5.camel@mediatek.com \
    --to=ck.hu@mediatek.com \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jie.qiu@mediatek.com \
    --cc=jitao.shi@mediatek.com \
    --cc=junzhi.zhao@mediatek.com \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox