From: "Rob Herring (Arm)" <robh@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Florian Fainelli <florian.fainelli@broadcom.com>,
Alex Elder <elder@kernel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Michael Turquette <mturquette@baylibre.com>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-clk@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
devicetree@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Stephen Boyd <sboyd@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Scott Branden <sbranden@broadcom.com>
Subject: Re: [PATCH v2 2/7] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx bus clocks
Date: Mon, 03 Mar 2025 15:43:54 -0600 [thread overview]
Message-ID: <174103823477.2582909.2641429106641464271.robh@kernel.org> (raw)
In-Reply-To: <20250303-kona-bus-clock-v2-2-a363c6a6b798@gmail.com>
On Mon, 03 Mar 2025 21:27:50 +0100, Artur Weber wrote:
> Add bus clocks corresponding to peripheral clocks currently supported
> by the BCM281xx clock driver and add the relevant clock IDs to the
> clock/bcm281xx.h dt-bindings header.
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
> Changes in v2:
> - Add this commit (BCM281xx bus clocks)
> ---
> .../devicetree/bindings/clock/brcm,kona-ccu.yaml | 21 +++++++++++++++++-
> include/dt-bindings/clock/bcm281xx.h | 25 +++++++++++++++++++---
> 2 files changed, 42 insertions(+), 4 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/brcm,kona-ccu.example.dtb: clock-controller@3e011000: clock-output-names: ['uartb', 'uartb2', 'uartb3', 'uartb4', 'ssp0', 'ssp2', 'bsc1', 'bsc2', 'bsc3', 'pwm'] is too short
from schema $id: http://devicetree.org/schemas/clock/brcm,kona-ccu.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250303-kona-bus-clock-v2-2-a363c6a6b798@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-03 21:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 20:27 [PATCH v2 0/7] clk: bcm: kona: Add bus clock support, bus clocks for BCM21664/BCM281xx Artur Weber
2025-03-03 20:27 ` [PATCH v2 1/7] dt-bindings: clock: brcm,kona-ccu: Add BCM21664 bus clocks Artur Weber
2025-03-04 7:35 ` Krzysztof Kozlowski
2025-03-03 20:27 ` [PATCH v2 2/7] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx " Artur Weber
2025-03-03 21:43 ` Rob Herring (Arm) [this message]
2025-03-04 7:35 ` Krzysztof Kozlowski
2025-03-04 20:22 ` Artur Weber
2025-03-03 20:27 ` [PATCH v2 3/7] clk: bcm: kona: Add support for " Artur Weber
2025-03-03 20:27 ` [PATCH v2 4/7] clk: bcm21664: Add matching bus clocks for peripheral clocks Artur Weber
2025-03-03 20:27 ` [PATCH v2 5/7] clk: bcm281xx: Add corresponding " Artur Weber
2025-03-03 20:27 ` [PATCH v2 6/7] ARM: dts: bcm2166x-common: Add matching " Artur Weber
2025-03-03 20:27 ` [PATCH v2 7/7] ARM: dts: bcm11351: Add corresponding " Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174103823477.2582909.2641429106641464271.robh@kernel.org \
--to=robh@kernel.org \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rjui@broadcom.com \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox