From: Krzysztof Kozlowski <krzk@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alex Elder <elder@kernel.org>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 2/7] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx bus clocks
Date: Tue, 4 Mar 2025 08:35:16 +0100 [thread overview]
Message-ID: <20250304-fat-nebulous-meerkat-008f04@krzk-bin> (raw)
In-Reply-To: <20250303-kona-bus-clock-v2-2-a363c6a6b798@gmail.com>
On Mon, Mar 03, 2025 at 09:27:50PM +0100, Artur Weber wrote:
> - if:
> properties:
> compatible:
> diff --git a/include/dt-bindings/clock/bcm281xx.h b/include/dt-bindings/clock/bcm281xx.h
> index d74ca42112e79746c513f6861a89628ee03f0f79..15449f998eb7a5a191fd847b689cfbe60b27c541 100644
> --- a/include/dt-bindings/clock/bcm281xx.h
> +++ b/include/dt-bindings/clock/bcm281xx.h
> @@ -34,7 +34,9 @@
> #define BCM281XX_AON_CCU_HUB_TIMER 0
> #define BCM281XX_AON_CCU_PMU_BSC 1
> #define BCM281XX_AON_CCU_PMU_BSC_VAR 2
> -#define BCM281XX_AON_CCU_CLOCK_COUNT 3
You cannot change defines, it is an ABI. Unless it is not an ABI... so
just drop all these counts in separate patch, just like we were doing
for other platforms.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-04 7:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 20:27 [PATCH v2 0/7] clk: bcm: kona: Add bus clock support, bus clocks for BCM21664/BCM281xx Artur Weber
2025-03-03 20:27 ` [PATCH v2 1/7] dt-bindings: clock: brcm,kona-ccu: Add BCM21664 bus clocks Artur Weber
2025-03-04 7:35 ` Krzysztof Kozlowski
2025-03-03 20:27 ` [PATCH v2 2/7] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx " Artur Weber
2025-03-03 21:43 ` Rob Herring (Arm)
2025-03-04 7:35 ` Krzysztof Kozlowski [this message]
2025-03-04 20:22 ` Artur Weber
2025-03-03 20:27 ` [PATCH v2 3/7] clk: bcm: kona: Add support for " Artur Weber
2025-03-03 20:27 ` [PATCH v2 4/7] clk: bcm21664: Add matching bus clocks for peripheral clocks Artur Weber
2025-03-03 20:27 ` [PATCH v2 5/7] clk: bcm281xx: Add corresponding " Artur Weber
2025-03-03 20:27 ` [PATCH v2 6/7] ARM: dts: bcm2166x-common: Add matching " Artur Weber
2025-03-03 20:27 ` [PATCH v2 7/7] ARM: dts: bcm11351: Add corresponding " Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304-fat-nebulous-meerkat-008f04@krzk-bin \
--to=krzk@kernel.org \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox