* [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block
@ 2026-04-10 11:10 Krzysztof Kozlowski
2026-04-10 11:10 ` [PATCH 2/2] dt-bindings: pinctrl: nvidia,tegra234: Correctly use additionalProperties Krzysztof Kozlowski
2026-04-13 17:17 ` [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block Rob Herring (Arm)
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-10 11:10 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thierry Reding, Jonathan Hunter, Prathamesh Shete, linux-gpio,
devicetree, linux-tegra, linux-kernel
Cc: Krzysztof Kozlowski
Binding should require 'reg' property, because address space cannot be
missing in the hardware and is already needed by the Linux drivers.
Require also 'compatible' by convention, although it is not strictly
necessary.
Fixes: 857982138b79 ("dt-bindings: pinctrl: Document Tegra234 pin controllers")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml | 4 ++++
.../devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
index db8224dfba2c..56fb9cf763ef 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
@@ -58,6 +58,10 @@ patternProperties:
drive_soc_gpio27_pee6, drive_ao_retention_n_pee2,
drive_vcomp_alert_pee1, drive_hdmi_cec_pgg0 ]
+required:
+ - compatible
+ - reg
+
unevaluatedProperties: false
examples:
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
index f5a3a881dec4..bd305a34eee2 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
@@ -115,6 +115,10 @@ patternProperties:
drive_sdmmc1_dat2_pj4, drive_sdmmc1_dat1_pj3,
drive_sdmmc1_dat0_pj2 ]
+required:
+ - compatible
+ - reg
+
unevaluatedProperties: false
examples:
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] dt-bindings: pinctrl: nvidia,tegra234: Correctly use additionalProperties
2026-04-10 11:10 [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block Krzysztof Kozlowski
@ 2026-04-10 11:10 ` Krzysztof Kozlowski
2026-04-13 17:18 ` Rob Herring (Arm)
2026-04-13 17:17 ` [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block Rob Herring (Arm)
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-10 11:10 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thierry Reding, Jonathan Hunter, Prathamesh Shete, linux-gpio,
devicetree, linux-tegra, linux-kernel
Cc: Krzysztof Kozlowski
The binding does not reference any other schema, thus should use
"additionalProperties: false" to disallow any undocumented properties.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml | 2 +-
.../devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
index 56fb9cf763ef..4910dc8e8aeb 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
@@ -62,7 +62,7 @@ required:
- compatible
- reg
-unevaluatedProperties: false
+additionalProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
index bd305a34eee2..52b3d40e8839 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
@@ -119,7 +119,7 @@ required:
- compatible
- reg
-unevaluatedProperties: false
+additionalProperties: false
examples:
- |
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] dt-bindings: pinctrl: nvidia,tegra234: Correctly use additionalProperties
2026-04-10 11:10 ` [PATCH 2/2] dt-bindings: pinctrl: nvidia,tegra234: Correctly use additionalProperties Krzysztof Kozlowski
@ 2026-04-13 17:18 ` Rob Herring (Arm)
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-04-13 17:18 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Thierry Reding, Jonathan Hunter, linux-gpio,
Conor Dooley, Prathamesh Shete, devicetree, linux-tegra,
linux-kernel, Linus Walleij
On Fri, 10 Apr 2026 13:10:49 +0200, Krzysztof Kozlowski wrote:
> The binding does not reference any other schema, thus should use
> "additionalProperties: false" to disallow any undocumented properties.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml | 2 +-
> .../devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block
2026-04-10 11:10 [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block Krzysztof Kozlowski
2026-04-10 11:10 ` [PATCH 2/2] dt-bindings: pinctrl: nvidia,tegra234: Correctly use additionalProperties Krzysztof Kozlowski
@ 2026-04-13 17:17 ` Rob Herring (Arm)
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-04-13 17:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-gpio, linux-tegra, Thierry Reding, Jonathan Hunter,
Linus Walleij, linux-kernel, Prathamesh Shete,
Krzysztof Kozlowski, devicetree, Conor Dooley
On Fri, 10 Apr 2026 13:10:48 +0200, Krzysztof Kozlowski wrote:
> Binding should require 'reg' property, because address space cannot be
> missing in the hardware and is already needed by the Linux drivers.
> Require also 'compatible' by convention, although it is not strictly
> necessary.
>
> Fixes: 857982138b79 ("dt-bindings: pinctrl: Document Tegra234 pin controllers")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml | 4 ++++
> .../devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml | 4 ++++
> 2 files changed, 8 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-13 17:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-10 11:10 [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block Krzysztof Kozlowski
2026-04-10 11:10 ` [PATCH 2/2] dt-bindings: pinctrl: nvidia,tegra234: Correctly use additionalProperties Krzysztof Kozlowski
2026-04-13 17:18 ` Rob Herring (Arm)
2026-04-13 17:17 ` [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox