From: "Rob Herring (Arm)" <robh@kernel.org>
To: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
linux-kernel@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>
Subject: Re: [PATCH v3 5/7] dt-bindings: sound: qcom,sm8250: allow TDM slot properties
Date: Tue, 07 Jul 2026 15:33:23 -0500 [thread overview]
Message-ID: <178345640307.4113079.1879467469002132914.robh@kernel.org> (raw)
In-Reply-To: <20260707190106.2876465-6-prasad.kumpatla@oss.qualcomm.com>
On Wed, 08 Jul 2026 00:31:04 +0530, Prasad Kumpatla wrote:
> Allow the standard TDM slot properties in CPU and codec endpoint
> nodes.
>
> Some audio backends operate in TDM mode and require the slot
> configuration to be described in Devicetree. The common TDM binding
> defines dai-tdm-slot-num, dai-tdm-slot-width,
> dai-tdm-slot-tx-mask and dai-tdm-slot-rx-mask for this purpose.
>
> Permit these standard properties in endpoint nodes so TDM-capable
> links can describe their slot configuration using the common binding.
>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> ---
> .../devicetree/bindings/sound/qcom,sm8250.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/qcom,sm8250.yaml:88:19: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/qcom,sm8250.yaml:115:19: [error] string value is redundantly quoted with any quotes (quoted-strings)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260707190106.2876465-6-prasad.kumpatla@oss.qualcomm.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-07-07 20:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 19:00 [PATCH v3 0/7]ASoC: qcom: add AudioReach TDM backend support Prasad Kumpatla
2026-07-07 19:01 ` [PATCH v3 1/7] ASoC: qcom: qdsp6: add topology-driven Audio IF support Prasad Kumpatla
2026-07-07 19:01 ` [PATCH v3 2/7] ASoC: qcom: q6apm-lpass-dais: add TDM DAI operations Prasad Kumpatla
2026-07-07 19:01 ` [PATCH v3 3/7] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks Prasad Kumpatla
2026-07-08 6:53 ` Krzysztof Kozlowski
2026-07-08 6:54 ` Krzysztof Kozlowski
2026-07-07 19:01 ` [PATCH v3 4/7] ASoC: qcom: q6prm: add Audio IF clock IDs Prasad Kumpatla
2026-07-07 19:01 ` [PATCH v3 5/7] dt-bindings: sound: qcom,sm8250: allow TDM slot properties Prasad Kumpatla
2026-07-07 20:33 ` Rob Herring (Arm) [this message]
2026-07-08 18:34 ` Rob Herring
2026-07-07 19:01 ` [PATCH v3 6/7] ASoC: qcom: common: add DAI-node TDM slot helpers Prasad Kumpatla
2026-07-07 19:01 ` [PATCH v3 7/7] ASoC: qcom: sc8280xp: add TDM hw_params support Prasad Kumpatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178345640307.4113079.1879467469002132914.robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox