Devicetree
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
@ 2026-09-02  8:13 Abel Vesa
  2026-09-02  8:18 ` sashiko-bot
  2026-09-11  2:25 ` Bjorn Andersson
  0 siblings, 2 replies; 4+ messages in thread
From: Abel Vesa @ 2026-09-02  8:13 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio, Abel Vesa

Enable the Adreno 722 GPU on the Eliza CQS SoM board and provide the zap
shader firmware path.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Changes in v2:
- Rebased on next-20260901.
- Picked up Konrad's R-b tag.
- Reworded commit message as Konrad suggested.
- Fixed the zap shader firmware filename.
- Link to v1: https://patch.msgid.link/20260901-dts-qcom-eliza-evk-enable-gpu-v1-1-a7c3fb27b4e9@oss.qualcomm.com
---
 arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
index 5ef6c51618bf..918f5289ca45 100644
--- a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
@@ -374,6 +374,14 @@ &pm7550ba_eusb2_repeater {
 	vdd3-supply = <&vreg_l17b>;
 };
 
+&gpu {
+	status = "okay";
+};
+
+&gpu_zap_shader {
+	firmware-name = "qcom/eliza/gen71700_zap.mbn";
+};
+
 &remoteproc_adsp {
 	firmware-name = "qcom/eliza/adsp.mbn",
 			"qcom/eliza/adsp_dtb.mbn";

---
base-commit: 8b72f6626dc39b9e7e82b2721d4f7c3b86286012
change-id: 20260901-dts-qcom-eliza-evk-enable-gpu-6532c131cea1

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
  2026-09-02  8:13 [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU Abel Vesa
@ 2026-09-02  8:18 ` sashiko-bot
  2026-09-02  8:25   ` Abel Vesa
  2026-09-11  2:25 ` Bjorn Andersson
  1 sibling, 1 reply; 4+ messages in thread
From: sashiko-bot @ 2026-09-02  8:18 UTC (permalink / raw)
  To: Abel Vesa; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The overridden DT nodes are not sorted alphabetically by label.
--

commit 69d2b599210486d1fb104df39a0da4a840c7aa02
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU

Enable the Adreno 722 GPU on the Eliza CQS SoM board and provide the zap
shader firmware path.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> index 5ef6c51618bf9..918f5289ca45f 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> @@ -374,6 +374,14 @@ &pm7550ba_eusb2_repeater {
>  	vdd3-supply = <&vreg_l17b>;
>  };
>  
> +&gpu {

[Severity: Low]
This isn't a bug, but should the overridden DT nodes at the root level be
sorted alphabetically by their label to maintain consistency?

Since 'g' comes before 'p', the &gpu and &gpu_zap_shader nodes inserted here
in arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi should probably be placed
before &pm7550ba_eusb2_repeater.

> +	status = "okay";
> +};
> +
> +&gpu_zap_shader {
> +	firmware-name = "qcom/eliza/gen71700_zap.mbn";
> +};
> +
>  &remoteproc_adsp {
>  	firmware-name = "qcom/eliza/adsp.mbn",
>  			"qcom/eliza/adsp_dtb.mbn";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-dts-qcom-eliza-evk-enable-gpu-v2-1-51b452a460a2@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
  2026-09-02  8:18 ` sashiko-bot
@ 2026-09-02  8:25   ` Abel Vesa
  0 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2026-09-02  8:25 UTC (permalink / raw)
  To: sashiko-reviews; +Cc: devicetree, robh, conor+dt

On 26-09-02 08:18:50, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The overridden DT nodes are not sorted alphabetically by label.
> --
> 
> commit 69d2b599210486d1fb104df39a0da4a840c7aa02
> Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
> 
> arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
> 
> Enable the Adreno 722 GPU on the Eliza CQS SoM board and provide the zap
> shader firmware path.
> 
> > diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> > index 5ef6c51618bf9..918f5289ca45f 100644
> > --- a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> > @@ -374,6 +374,14 @@ &pm7550ba_eusb2_repeater {
> >  	vdd3-supply = <&vreg_l17b>;
> >  };
> >  
> > +&gpu {
> 
> [Severity: Low]
> This isn't a bug, but should the overridden DT nodes at the root level be
> sorted alphabetically by their label to maintain consistency?
> 
> Since 'g' comes before 'p', the &gpu and &gpu_zap_shader nodes inserted here
> in arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi should probably be placed
> before &pm7550ba_eusb2_repeater.

Urgh, good catch.

Will send v3 with gpu nodes moved in proper place.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
  2026-09-02  8:13 [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU Abel Vesa
  2026-09-02  8:18 ` sashiko-bot
@ 2026-09-11  2:25 ` Bjorn Andersson
  1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-09-11  2:25 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Abel Vesa
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio


On Wed, 02 Sep 2026 11:13:35 +0300, Abel Vesa wrote:
> Enable the Adreno 722 GPU on the Eliza CQS SoM board and provide the zap
> shader firmware path.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
      commit: f0d9238839b3c2ebe3f8c821a2b60e8e3ce2ae6d

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-11  2:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-02  8:13 [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU Abel Vesa
2026-09-02  8:18 ` sashiko-bot
2026-09-02  8:25   ` Abel Vesa
2026-09-11  2:25 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox