From: Romain Gantois <romain.gantois@bootlin.com>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] iio: temperature: tmp117: add TI TMP119 support
Date: Fri, 05 Jun 2026 13:38:01 +0200 [thread overview]
Message-ID: <18PCQgHDRMeFeQrJjHXSqQ@bootlin.com> (raw)
In-Reply-To: <20260605110802.74B701F00893@smtp.kernel.org>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Friday, 5 June 2026 13:08:02 CEST sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider: - [Medium] The IIO device name for the TMP119 sensor
...
>
> And indio_dev->name is assigned from match_data->name later in
>
> tmp117_probe():
> indio_dev->name = match_data->name;
>
> Does this break userspace applications or udev rules that rely on reading
> the correct sensor part name ("tmp119") from sysfs?
While unlikely that userspace applications would need to differentiate between
these two sensors, it is preferable that the correct part name appears in
sysfs. I'll fix this in version 2.
--
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-06-05 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 9:01 [PATCH 0/2] iio: temperature: tmp117: Support the TMP119 sensor Romain Gantois
2026-06-05 9:01 ` [PATCH 1/2] dt-bindings: iio: ti,tmp117: add binding for the TMP119 Romain Gantois
2026-06-05 11:53 ` Jonathan Cameron
2026-06-05 12:24 ` Romain Gantois
2026-06-05 14:20 ` Jonathan Cameron
2026-06-05 16:08 ` Conor Dooley
2026-06-05 9:01 ` [PATCH 2/2] iio: temperature: tmp117: add TI TMP119 support Romain Gantois
2026-06-05 11:08 ` sashiko-bot
2026-06-05 11:38 ` Romain Gantois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18PCQgHDRMeFeQrJjHXSqQ@bootlin.com \
--to=romain.gantois@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox