Re: [PATCH 2/2] iio: temperature: tmp117: add TI TMP119 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The IIO device name for the TMP119 sensor is incorrectly reported as 'tmp117' to userspace.
--

commit 3bc7597d636b9eb1df1b77ad9bb9ab2ab8c85398
Author: Wil Stark <wil_stark@keysight.com>

iio: temperature: tmp117: add TI TMP119 support

This commit adds support for the TMP119 temperature sensor to the tmp117
driver. It maps the TMP119 device ID and compatible string to the existing
tmp117 match data.

> diff --git a/drivers/iio/temperature/tmp117.c b/drivers/iio/temperature/tmp117.c
> index 8972083d903a2..8e9621171c516 100644
> --- a/drivers/iio/temperature/tmp117.c
> +++ b/drivers/iio/temperature/tmp117.c
[ ... ]
> @@ -170,6 +171,7 @@ static int tmp117_probe(struct i2c_client *client)
>  		match_data = &tmp116_channels_info;
>  		break;
>  	case TMP117_DEVICE_ID:
> +	case TMP119_DEVICE_ID:
>  		match_data = &tmp117_channels_info;
>  		break;

[Severity: Medium]
Will this cause the IIO device name exposed to userspace to be incorrectly
reported as "tmp117" for TMP119 devices?

Since TMP119 maps directly to tmp117_channels_info:

static const struct tmp11x_info tmp117_channels_info = {
        .name = "tmp117",
        ...
};

And indio_dev->name is assigned from match_data->name later in tmp117_probe():

        indio_dev->name = match_data->name;

Does this break userspace applications or udev rules that rely on reading
the correct sensor part name ("tmp119") from sysfs?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-tmp119-v1-0-349f45f17d12@bootlin.com?part=2