Devicetree
 help / color / mirror / Atom feed
From: Romain Gantois <romain.gantois@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Puranjay Mohan" <puranjay@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Wil Stark" <wil_stark@keysight.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: ti,tmp117: add binding for the TMP119
Date: Fri, 05 Jun 2026 14:24:45 +0200	[thread overview]
Message-ID: <ft-705oeTSiaftSGNjv94A@bootlin.com> (raw)
In-Reply-To: <20260605125332.151b92f8@jic23-huawei>

[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]

Hi Jonathan,

On Friday, 5 June 2026 13:53:32 CEST Jonathan Cameron wrote:
> On Fri, 05 Jun 2026 11:01:35 +0200
> 
> Romain Gantois <romain.gantois@bootlin.com> wrote:
> > The TMP119 has the same register layout as the TMP117, and a better local
> > sensor accuracy.
> 
> Sounds like (and the driver changes pretty much confirm) that this could
> use a fallback compatible to the tmp117.
> 

What do you mean by "fallback compatible" in this case? Do you mean we should 
do something like this in the bindings:

```
enum:
       - ti,tmp116
       - ti,tmp119
const:
       - ti,tmp117
```

But wouldn't this invalidate existing device trees which only have:

`compatible = "ti,tmp116";`

> The second patch then just resolves the print that would happen on older
> kernels using that fallback due to ID mismatch.  That's fine but nice
> if older kernels can work with this part.

Sorry I don't quite understand: since this is a feature patch, I don't expect 
it would get backported onto older kernels. Therefore why would the second 
patch resolve the print happening on older kernels?

Thanks,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-06-05 12:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05  9:01 [PATCH 0/2] iio: temperature: tmp117: Support the TMP119 sensor Romain Gantois
2026-06-05  9:01 ` [PATCH 1/2] dt-bindings: iio: ti,tmp117: add binding for the TMP119 Romain Gantois
2026-06-05 11:53   ` Jonathan Cameron
2026-06-05 12:24     ` Romain Gantois [this message]
2026-06-05 14:20       ` Jonathan Cameron
2026-06-05 16:08         ` Conor Dooley
2026-06-05  9:01 ` [PATCH 2/2] iio: temperature: tmp117: add TI TMP119 support Romain Gantois
2026-06-05 11:08   ` sashiko-bot
2026-06-05 11:38     ` Romain Gantois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ft-705oeTSiaftSGNjv94A@bootlin.com \
    --to=romain.gantois@bootlin.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=puranjay@kernel.org \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wil_stark@keysight.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox