[PATCH] ARM: dts: imx6qdl-sabresd: correct gpio key's active state

[PATCH] ARM: dts: imx6qdl-sabresd: correct gpio key's active state

[Anson Huang]

>From schematic, the power, vol+/- key's active state is low,
so we need to set the gpio flag to active low.

Signed-off-by: Anson Huang <b20788-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 91e5dd4..f7689b4 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -58,21 +58,21 @@
 
 		power {
 			label = "Power Button";
-			gpios = <&gpio3 29 0>;
+			gpios = <&gpio3 29 1>;
 			gpio-key,wakeup;
 			linux,code = <KEY_POWER>;
 		};
 
 		volume-up {
 			label = "Volume Up";
-			gpios = <&gpio1 4 0>;
+			gpios = <&gpio1 4 1>;
 			gpio-key,wakeup;
 			linux,code = <KEY_VOLUMEUP>;
 		};
 
 		volume-down {
 			label = "Volume Down";
-			gpios = <&gpio1 5 0>;
+			gpios = <&gpio1 5 1>;
 			gpio-key,wakeup;
 			linux,code = <KEY_VOLUMEDOWN>;
 		};
-- 
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: imx6qdl-sabresd: correct gpio key's active state

[Sascha Hauer]

On Mon, Jan 20, 2014 at 07:42:33PM +0800, Anson Huang wrote:
> From schematic, the power, vol+/- key's active state is low,
> so we need to set the gpio flag to active low.
> 
> Signed-off-by: Anson Huang <b20788-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 91e5dd4..f7689b4 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -58,21 +58,21 @@
>  
>  		power {
>  			label = "Power Button";
> -			gpios = <&gpio3 29 0>;
> +			gpios = <&gpio3 29 1>;

When touching this you could take the opportunity and use
GPIO_ACTIVE_LOW.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ARM: dts: imx6qdl-sabresd: correct gpio key's active state

[Anson.Huang-KZfg59tc24xl57MIdRCFDg]

Hi, Sascha
	Thanks for the reminder, will improve it in V2.

Best Regards.
Anson huang 黄勇才
 
Freescale Semiconductor Shanghai
上海浦东新区亮景路192号A座2楼
201203
Tel:021-28937058


>-----Original Message-----
>From: Sascha Hauer [mailto:s.hauer@pengutronix.de]
>Sent: Monday, January 20, 2014 7:54 PM
>To: Huang Yongcai-B20788
>Cc: shawn.guo@linaro.org; devicetree@vger.kernel.org
>Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: correct gpio key's active
>state
>
>On Mon, Jan 20, 2014 at 07:42:33PM +0800, Anson Huang wrote:
>> From schematic, the power, vol+/- key's active state is low, so we
>> need to set the gpio flag to active low.
>>
>> Signed-off-by: Anson Huang <b20788@freescale.com>
>> ---
>>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
>> b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
>> index 91e5dd4..f7689b4 100644
>> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
>> @@ -58,21 +58,21 @@
>>
>>  		power {
>>  			label = "Power Button";
>> -			gpios = <&gpio3 29 0>;
>> +			gpios = <&gpio3 29 1>;
>
>When touching this you could take the opportunity and use GPIO_ACTIVE_LOW.
>
>Sascha
>
>--
>Pengutronix e.K.                           |                             |
>Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
>Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>