* [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device
@ 2015-12-04 5:22 Vladimir Zapolskiy
2015-12-04 9:21 ` Arnd Bergmann
2015-12-04 15:59 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2015-12-04 5:22 UTC (permalink / raw)
To: Rob Herring, Thierry Reding; +Cc: linux-pwm, devicetree
LPC32xx SoC has two independent PWM controllers, they have different
clock parents, clock gates and slightly different controls, each of
these two PWM controllers has one output channel.
The change updates device tree binding documentation to reflect two PWM
devices.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
index cfe1db3..ab0907d 100644
--- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
@@ -8,5 +8,10 @@ Examples:
pwm@0x4005C000 {
compatible = "nxp,lpc3220-pwm";
- reg = <0x4005C000 0x8>;
+ reg = <0x4005C000 0x4>;
+};
+
+pwm@0x4005C004 {
+ compatible = "nxp,lpc3220-pwm";
+ reg = <0x4005C004 0x4>;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device
2015-12-04 5:22 [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device Vladimir Zapolskiy
@ 2015-12-04 9:21 ` Arnd Bergmann
2015-12-04 15:59 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-12-04 9:21 UTC (permalink / raw)
To: Vladimir Zapolskiy; +Cc: Rob Herring, Thierry Reding, linux-pwm, devicetree
On Friday 04 December 2015 07:22:33 Vladimir Zapolskiy wrote:
> LPC32xx SoC has two independent PWM controllers, they have different
> clock parents, clock gates and slightly different controls, each of
> these two PWM controllers has one output channel.
>
> The change updates device tree binding documentation to reflect two PWM
> devices.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>
The change looks reasonable, but I think you should clarify that this is
an incompatible change, and do it in the same patch as the corresponding
change to set 'npwms' to 1 in the driver.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device
2015-12-04 5:22 [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device Vladimir Zapolskiy
2015-12-04 9:21 ` Arnd Bergmann
@ 2015-12-04 15:59 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2015-12-04 15:59 UTC (permalink / raw)
To: Vladimir Zapolskiy; +Cc: Thierry Reding, linux-pwm, devicetree
On Fri, Dec 04, 2015 at 07:22:33AM +0200, Vladimir Zapolskiy wrote:
> LPC32xx SoC has two independent PWM controllers, they have different
> clock parents, clock gates and slightly different controls, each of
> these two PWM controllers has one output channel.
>
> The change updates device tree binding documentation to reflect two PWM
> devices.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
> Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> index cfe1db3..ab0907d 100644
> --- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> @@ -8,5 +8,10 @@ Examples:
>
> pwm@0x4005C000 {
> compatible = "nxp,lpc3220-pwm";
> - reg = <0x4005C000 0x8>;
> + reg = <0x4005C000 0x4>;
> +};
> +
> +pwm@0x4005C004 {
Remove the '0x' and use lower case hex chars.
Rob
> + compatible = "nxp,lpc3220-pwm";
> + reg = <0x4005C004 0x4>;
> };
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-04 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-04 5:22 [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device Vladimir Zapolskiy
2015-12-04 9:21 ` Arnd Bergmann
2015-12-04 15:59 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox