public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] watchdog: dw_wdt: add reset lines
@ 2016-09-22  7:02 Steffen Trumtrar
       [not found] ` <1474527753-22194-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Steffen Trumtrar @ 2016-09-22  7:02 UTC (permalink / raw)
  To: linux-watchdog; +Cc: kernel, Steffen Trumtrar, devicetree, linux-kernel

Hi!

This series adds support for the reset line that is
(potentially) holding the watchdog in reset.

As the watchdog is useless if this happens, it needs to be deasserted
in the probe function.
Additionally, the reset is the only way of stopping a once started watchdog.
This was previously not supported, so add the stop operation to the watchdog ops.

Tested on the SoCFPGA platform.

Regards,
Steffen

Steffen Trumtrar (3):
  watchdog: bindings: dw_wdt: add reset lines
  watchdog: dw_wdt: get reset lines from dt
  watchdog: dw_wdt: add stop watchdog operation

 .../devicetree/bindings/watchdog/dw_wdt.txt        |  5 +++++
 drivers/watchdog/dw_wdt.c                          | 25 ++++++++++++++++++++++
 2 files changed, 30 insertions(+)

-- 
2.8.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/3] watchdog: bindings: dw_wdt: add reset lines
       [not found] ` <1474527753-22194-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2016-09-22  7:02   ` Steffen Trumtrar
       [not found]     ` <1474527753-22194-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Steffen Trumtrar @ 2016-09-22  7:02 UTC (permalink / raw)
  To: linux-watchdog-u79uwXL29TY76Z2rM5mHXA
  Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ, Steffen Trumtrar, Wim Van Sebroeck,
	Rob Herring, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Guenter Roeck, linux-kernel-u79uwXL29TY76Z2rM5mHXA

Document the reset lines holding the watchdog core in reset.

Signed-off-by: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
 Documentation/devicetree/bindings/watchdog/dw_wdt.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/dw_wdt.txt b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt
index 08e16f684f2d..3bf386c72241 100644
--- a/Documentation/devicetree/bindings/watchdog/dw_wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt
@@ -10,6 +10,9 @@ Required Properties:
 Optional Properties:
 
 - interrupts	: The interrupt used for the watchdog timeout warning.
+- resets	: phandle pointing to the system reset controller with
+		line index for the watchdog.
+- reset-names	: must be set to "dw-wdt".
 
 Example:
 
@@ -18,4 +21,6 @@ Example:
 		reg = <0xffd02000 0x1000>;
 		interrupts = <0 171 4>;
 		clocks = <&per_base_clk>;
+		resets = <&rst WDT0_RESET>;
+		reset-names = "dw-wdt";
 	};
-- 
2.8.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] watchdog: bindings: dw_wdt: add reset lines
       [not found]     ` <1474527753-22194-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2016-09-23 19:59       ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2016-09-23 19:59 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ, Wim Van Sebroeck, Mark Rutland,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Guenter Roeck,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Thu, Sep 22, 2016 at 09:02:30AM +0200, Steffen Trumtrar wrote:
> Document the reset lines holding the watchdog core in reset.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
>  Documentation/devicetree/bindings/watchdog/dw_wdt.txt | 5 +++++
>  1 file changed, 5 insertions(+)

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-23 19:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-22  7:02 [PATCH 0/3] watchdog: dw_wdt: add reset lines Steffen Trumtrar
     [not found] ` <1474527753-22194-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-09-22  7:02   ` [PATCH 1/3] watchdog: bindings: " Steffen Trumtrar
     [not found]     ` <1474527753-22194-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-09-23 19:59       ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox