Devicetree
 help / color / mirror / Atom feed
* [PATCH 1/4] dt-bindings: display: amlogic, meson-vpu: Add optional power domain property
       [not found] <1508227664-11171-1-git-send-email-narmstrong@baylibre.com>
@ 2017-10-17  8:07 ` Neil Armstrong
  2017-10-23 22:44   ` Rob Herring
  2017-10-17  8:07 ` [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator Neil Armstrong
  1 sibling, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2017-10-17  8:07 UTC (permalink / raw)
  To: airlied
  Cc: devicetree, Neil Armstrong, linux-kernel, dri-devel,
	linux-amlogic, linux-arm-kernel

The Video Processing Unit power domain was setup by the Vendor U-Boot,
add support for an optional Power Domain phandle to setup it from the kernel.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 Documentation/devicetree/bindings/display/amlogic,meson-vpu.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.txt b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.txt
index 00f74ba..057b813 100644
--- a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.txt
+++ b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.txt
@@ -64,6 +64,10 @@ Required properties:
 - reg-names: should contain the names of the previous memory regions
 - interrupts: should contain the VENC Vsync interrupt number
 
+Optional properties:
+- power-domains: Optional phandle to associated power domain as described in
+	the file ../power/power_domain.txt
+
 Required nodes:
 
 The connections to the VPU output video ports are modeled using the OF graph
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator
       [not found] <1508227664-11171-1-git-send-email-narmstrong@baylibre.com>
  2017-10-17  8:07 ` [PATCH 1/4] dt-bindings: display: amlogic, meson-vpu: Add optional power domain property Neil Armstrong
@ 2017-10-17  8:07 ` Neil Armstrong
       [not found]   ` <1508227664-11171-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
  1 sibling, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2017-10-17  8:07 UTC (permalink / raw)
  To: airlied
  Cc: devicetree, Neil Armstrong, linux-kernel, dri-devel,
	linux-amlogic, linux-arm-kernel

On reference boards and derivatives, the HDMI Logic is powered by an external
5V regulator.
This regulator was set by the Vendor U-Boot, add optional support for it.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
index 7f040ed..bf4a180 100644
--- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
+++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
@@ -48,6 +48,10 @@ Required properties:
   Documentation/devicetree/bindings/reset/reset.txt,
   the reset-names should be "hdmitx_apb", "hdmitx", "hdmitx_phy"
 
+Optional properties:
+- hdmi-supply: Optional phandle to an external 5V regulator to power the HDMI
+  logic, as described in the file ../regulator/regulator.txt
+
 Required nodes:
 
 The connections to the HDMI ports are modeled using the OF graph
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] dt-bindings: display: amlogic, meson-vpu: Add optional power domain property
  2017-10-17  8:07 ` [PATCH 1/4] dt-bindings: display: amlogic, meson-vpu: Add optional power domain property Neil Armstrong
@ 2017-10-23 22:44   ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2017-10-23 22:44 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: airlied, devicetree, linux-kernel, dri-devel, linux-amlogic,
	linux-arm-kernel

On Tue, Oct 17, 2017 at 10:07:41AM +0200, Neil Armstrong wrote:
> The Video Processing Unit power domain was setup by the Vendor U-Boot,
> add support for an optional Power Domain phandle to setup it from the kernel.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  Documentation/devicetree/bindings/display/amlogic,meson-vpu.txt | 4 ++++
>  1 file changed, 4 insertions(+)

Acked-by: Rob Herring <robh@kernel.org> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator
       [not found]   ` <1508227664-11171-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
@ 2017-10-23 22:46     ` Rob Herring
  2017-10-24  8:09       ` Neil Armstrong
  0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2017-10-23 22:46 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: airlied-cv59FeDIM0c, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Tue, Oct 17, 2017 at 10:07:42AM +0200, Neil Armstrong wrote:
> On reference boards and derivatives, the HDMI Logic is powered by an external
> 5V regulator.
> This regulator was set by the Vendor U-Boot, add optional support for it.
> 
> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
> index 7f040ed..bf4a180 100644
> --- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
> @@ -48,6 +48,10 @@ Required properties:
>    Documentation/devicetree/bindings/reset/reset.txt,
>    the reset-names should be "hdmitx_apb", "hdmitx", "hdmitx_phy"
>  
> +Optional properties:
> +- hdmi-supply: Optional phandle to an external 5V regulator to power the HDMI
> +  logic, as described in the file ../regulator/regulator.txt

5V into a modern SoC sounds strange. Is this really for the chip or for 
5V to the connector? The latter should be in the connector node.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator
  2017-10-23 22:46     ` Rob Herring
@ 2017-10-24  8:09       ` Neil Armstrong
       [not found]         ` <9b69d42b-ffc5-32cf-1509-ec8e74fc3825-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2017-10-24  8:09 UTC (permalink / raw)
  To: Rob Herring
  Cc: devicetree, linux-kernel, dri-devel, linux-amlogic,
	linux-arm-kernel

On 24/10/2017 00:46, Rob Herring wrote:
> On Tue, Oct 17, 2017 at 10:07:42AM +0200, Neil Armstrong wrote:
>> On reference boards and derivatives, the HDMI Logic is powered by an external
>> 5V regulator.
>> This regulator was set by the Vendor U-Boot, add optional support for it.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
>> index 7f040ed..bf4a180 100644
>> --- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
>> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
>> @@ -48,6 +48,10 @@ Required properties:
>>    Documentation/devicetree/bindings/reset/reset.txt,
>>    the reset-names should be "hdmitx_apb", "hdmitx", "hdmitx_phy"
>>  
>> +Optional properties:
>> +- hdmi-supply: Optional phandle to an external 5V regulator to power the HDMI
>> +  logic, as described in the file ../regulator/regulator.txt
> 
> 5V into a modern SoC sounds strange. Is this really for the chip or for 
> 5V to the connector? The latter should be in the connector node.
> 
> Rob
> 

Hi Rob,

The chip does not get the 5V but multiple derived voltages, but depends on the 5V regulator to
enable this power supply for the connector and to the hdmi io bank.

So in my opinion it's not related to the connector but to the HDMI logic.

Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator
       [not found]         ` <9b69d42b-ffc5-32cf-1509-ec8e74fc3825-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
@ 2017-10-24 15:49           ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2017-10-24 15:49 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: airlied-cv59FeDIM0c, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Tue, Oct 24, 2017 at 10:09:15AM +0200, Neil Armstrong wrote:
> On 24/10/2017 00:46, Rob Herring wrote:
> > On Tue, Oct 17, 2017 at 10:07:42AM +0200, Neil Armstrong wrote:
> >> On reference boards and derivatives, the HDMI Logic is powered by an external
> >> 5V regulator.
> >> This regulator was set by the Vendor U-Boot, add optional support for it.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> >> ---
> >>  Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
> >> index 7f040ed..bf4a180 100644
> >> --- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
> >> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt
> >> @@ -48,6 +48,10 @@ Required properties:
> >>    Documentation/devicetree/bindings/reset/reset.txt,
> >>    the reset-names should be "hdmitx_apb", "hdmitx", "hdmitx_phy"
> >>  
> >> +Optional properties:
> >> +- hdmi-supply: Optional phandle to an external 5V regulator to power the HDMI
> >> +  logic, as described in the file ../regulator/regulator.txt
> > 
> > 5V into a modern SoC sounds strange. Is this really for the chip or for 
> > 5V to the connector? The latter should be in the connector node.
> > 
> > Rob
> > 
> 
> Hi Rob,
> 
> The chip does not get the 5V but multiple derived voltages, but depends on the 5V regulator to
> enable this power supply for the connector and to the hdmi io bank.
> 
> So in my opinion it's not related to the connector but to the HDMI logic.

But you just said it is for the connector too.

In any case, if it is for the HDMI i/o, then

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-10-24 15:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1508227664-11171-1-git-send-email-narmstrong@baylibre.com>
2017-10-17  8:07 ` [PATCH 1/4] dt-bindings: display: amlogic, meson-vpu: Add optional power domain property Neil Armstrong
2017-10-23 22:44   ` Rob Herring
2017-10-17  8:07 ` [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator Neil Armstrong
     [not found]   ` <1508227664-11171-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-10-23 22:46     ` Rob Herring
2017-10-24  8:09       ` Neil Armstrong
     [not found]         ` <9b69d42b-ffc5-32cf-1509-ec8e74fc3825-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-10-24 15:49           ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox