[PATCH 0/2] ASoC: tfa9879: cleanup bindings and claim maintainership

[PATCH 0/2] ASoC: tfa9879: cleanup bindings and claim maintainership

[Peter Rosin]

Hi!

Device tree bindings where added for the tfa9879 along with improved
support for them in the driver some time ago. All behind my back.
This cleans things up and properly adds me as maintainer of the new
bindings.

Cheers,
Peter

Peter Rosin (2):
  ASoC: tfa9879: clean up bindings
  ASoC: tfa9879: add DT bindings to MAINTAINERS

 Documentation/devicetree/bindings/sound/tfa9879.txt | 8 ++++----
 MAINTAINERS                                         | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.11.0

[PATCH 1/2] ASoC: tfa9879: clean up bindings

[Peter Rosin]

Fix a couple of nitpicks:

- list #sound-dai-cells as a required property.
- The chip supports full speed I2C; don't indicate standard mode only.
- status = "okay" is just noise.
- The chip is an amplifier, not a codec.
- consistently indent with tabs.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 Documentation/devicetree/bindings/sound/tfa9879.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt
index 23ba522d9e2b..1620e6848436 100644
--- a/Documentation/devicetree/bindings/sound/tfa9879.txt
+++ b/Documentation/devicetree/bindings/sound/tfa9879.txt
@@ -6,18 +6,18 @@ Required properties:
 
 - reg : the I2C address of the device
 
+- #sound-dai-cells : must be 0.
+
 Example:
 
 &i2c1 {
-	clock-frequency = <100000>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_i2c1>;
-	status = "okay";
 
-	codec: tfa9879@6c {
+	amp: amp@6c {
 		#sound-dai-cells = <0>;
 		compatible = "nxp,tfa9879";
 		reg = <0x6c>;
-        };
+	};
 };
 
-- 
2.11.0

Applied "ASoC: tfa9879: clean up bindings" to the asoc tree

[Mark Brown]

The patch

   ASoC: tfa9879: clean up bindings

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From d61f9982c2a395407a75a4f7057c4a3f55bda462 Mon Sep 17 00:00:00 2001
From: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
Date: Mon, 11 Dec 2017 15:26:14 +0100
Subject: [PATCH] ASoC: tfa9879: clean up bindings

Fix a couple of nitpicks:

- list #sound-dai-cells as a required property.
- The chip supports full speed I2C; don't indicate standard mode only.
- status = "okay" is just noise.
- The chip is an amplifier, not a codec.
- consistently indent with tabs.

Signed-off-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 Documentation/devicetree/bindings/sound/tfa9879.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt
index 23ba522d9e2b..1620e6848436 100644
--- a/Documentation/devicetree/bindings/sound/tfa9879.txt
+++ b/Documentation/devicetree/bindings/sound/tfa9879.txt
@@ -6,18 +6,18 @@ Required properties:
 
 - reg : the I2C address of the device
 
+- #sound-dai-cells : must be 0.
+
 Example:
 
 &i2c1 {
-	clock-frequency = <100000>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_i2c1>;
-	status = "okay";
 
-	codec: tfa9879@6c {
+	amp: amp@6c {
 		#sound-dai-cells = <0>;
 		compatible = "nxp,tfa9879";
 		reg = <0x6c>;
-        };
+	};
 };
 
-- 
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ASoC: tfa9879: add DT bindings to MAINTAINERS

[Peter Rosin]

Let's keep maintenance of the driver and the bindings in one place.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d4fdcb12616c..e7c2ca89fec4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9804,6 +9804,7 @@ NXP TFA9879 DRIVER
 M:	Peter Rosin <peda@axentia.se>
 L:	alsa-devel@alsa-project.org (moderated for non-subscribers)
 S:	Maintained
+F:	Documentation/devicetree/bindings/sound/tfa9879.txt
 F:	sound/soc/codecs/tfa9879*
 
 NXP-NCI NFC DRIVER
-- 
2.11.0

Applied "ASoC: tfa9879: add DT bindings to MAINTAINERS" to the asoc tree

[Mark Brown]

The patch

   ASoC: tfa9879: add DT bindings to MAINTAINERS

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From a73be94364b80388c0a600715117923669f165f8 Mon Sep 17 00:00:00 2001
From: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
Date: Mon, 11 Dec 2017 15:26:15 +0100
Subject: [PATCH] ASoC: tfa9879: add DT bindings to MAINTAINERS

Let's keep maintenance of the driver and the bindings in one place.

Signed-off-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index aa71ab52fd76..a04aaa270ad5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9805,6 +9805,7 @@ NXP TFA9879 DRIVER
 M:	Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
 L:	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org (moderated for non-subscribers)
 S:	Maintained
+F:	Documentation/devicetree/bindings/sound/tfa9879.txt
 F:	sound/soc/codecs/tfa9879*
 
 NXP-NCI NFC DRIVER
-- 
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] ASoC: tfa9879: cleanup bindings and claim maintainership

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

On Mon, Dec 11, 2017 at 03:26:13PM +0100, Peter Rosin wrote:
> Hi!
> 
> Device tree bindings where added for the tfa9879 along with improved
> support for them in the driver some time ago. All behind my back.
> This cleans things up and properly adds me as maintainer of the new
> bindings.
> 
> Cheers,
> Peter
> 
> Peter Rosin (2):
>   ASoC: tfa9879: clean up bindings
>   ASoC: tfa9879: add DT bindings to MAINTAINERS

The actual patch series doesn't appear to have arrived in my inbox?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] ASoC: tfa9879: cleanup bindings and claim maintainership

[Peter Rosin]

On 2017-12-11 17:35, Mark Brown wrote:
> On Mon, Dec 11, 2017 at 03:26:13PM +0100, Peter Rosin wrote:
>> Hi!
>>
>> Device tree bindings where added for the tfa9879 along with improved
>> support for them in the driver some time ago. All behind my back.
>> This cleans things up and properly adds me as maintainer of the new
>> bindings.
>>
>> Cheers,
>> Peter
>>
>> Peter Rosin (2):
>>   ASoC: tfa9879: clean up bindings
>>   ASoC: tfa9879: add DT bindings to MAINTAINERS
> 
> The actual patch series doesn't appear to have arrived in my inbox?

That's weird, because I sent it all with git send-email and the
patches did reach lkml [1] and patchwork has them too [2][3]. I
have also verified that you were indeed on the Cc list, and I have
not seen any errors (yet). I'm not sure if it's going to matter if
I send them again, or if it is fastest/simplest for you to get them
from patchwork?

Cheers,
Peter

[1] https://lkml.org/lkml/2017/12/11/374
[2] https://patchwork.kernel.org/patch/10105305/
[3] https://patchwork.kernel.org/patch/10105307/