* [PATCH v1] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts
@ 2022-09-08 13:25 matthias.bgg
2022-09-08 13:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: matthias.bgg @ 2022-09-08 13:25 UTC (permalink / raw)
To: Yong Wu, Joerg Roedel, Will Deacon
Cc: devicetree, Robin Murphy, linux-kernel, Krzysztof Kozlowski,
iommu, Rob Herring, linux-mediatek, Matthias Brugger,
linux-arm-kernel, Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
The mt8195-iommu-infra has five banks and one interrupt for each.
Reflect that in the binding.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
.../bindings/iommu/mediatek,iommu.yaml | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
index fee0241b50988..621aca2adfb7f 100644
--- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
@@ -91,7 +91,7 @@ properties:
maxItems: 1
interrupts:
- maxItems: 1
+ description: each bank has one dedicated interrupt
clocks:
items:
@@ -183,6 +183,19 @@ allOf:
required:
- mediatek,infracfg
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt8195-iommu-infra
+
+ then:
+ properties:
+ interrupts:
+ maxItems: 5
+ required:
+ - interrupts
+
- if: # The IOMMUs don't have larbs.
not:
properties:
@@ -191,8 +204,12 @@ allOf:
const: mediatek,mt8195-iommu-infra
then:
+ properties:
+ interrupts:
+ maxItems: 1
required:
- mediatek,larbs
+ - interrupts
additionalProperties: false
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts
2022-09-08 13:25 [PATCH v1] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts matthias.bgg
@ 2022-09-08 13:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-08 13:30 UTC (permalink / raw)
To: matthias.bgg, Yong Wu, Joerg Roedel, Will Deacon
Cc: devicetree, Robin Murphy, linux-kernel, Krzysztof Kozlowski,
iommu, Rob Herring, linux-mediatek, Matthias Brugger,
linux-arm-kernel, Matthias Brugger
On 08/09/2022 15:25, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> The mt8195-iommu-infra has five banks and one interrupt for each.
> Reflect that in the binding.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> .../bindings/iommu/mediatek,iommu.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> index fee0241b50988..621aca2adfb7f 100644
> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> @@ -91,7 +91,7 @@ properties:
> maxItems: 1
>
> interrupts:
> - maxItems: 1
Keep here wide constraints - minItems:1, maxItems:5
> + description: each bank has one dedicated interrupt
>
> clocks:
> items:
> @@ -183,6 +183,19 @@ allOf:
> required:
> - mediatek,infracfg
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8195-iommu-infra
> +
> + then:
> + properties:
> + interrupts:
> + maxItems: 5
and then minItems:5
> + required:
> + - interrupts
This seems unrelated and not really needed.
> +
> - if: # The IOMMUs don't have larbs.
> not:
> properties:
> @@ -191,8 +204,12 @@ allOf:
> const: mediatek,mt8195-iommu-infra
>
> then:
> + properties:
> + interrupts:
> + maxItems: 1
> required:
> - mediatek,larbs
> + - interrupts
This seems unrelated and not really needed.
>
> additionalProperties: false
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-08 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08 13:25 [PATCH v1] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts matthias.bgg
2022-09-08 13:30 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox