* [PATCH 1/2] arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash
2023-12-15 19:18 [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Nathan Morrisson
@ 2023-12-15 19:18 ` Nathan Morrisson
2023-12-15 19:18 ` [PATCH 2/2] arm64: dts: ti: k3-am64-phycore-som: " Nathan Morrisson
2023-12-15 19:20 ` [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Andrew Davis
2 siblings, 0 replies; 6+ messages in thread
From: Nathan Morrisson @ 2023-12-15 19:18 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, upstream, w.egorov
Provide a fixed-partitions dummy node so bootladers can fixup
paritions.
Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
---
arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
index aa43e7407eee..681ac03cef40 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
@@ -311,6 +311,12 @@ serial_flash: flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <0>;
+
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR Flash
2023-12-15 19:18 [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Nathan Morrisson
2023-12-15 19:18 ` [PATCH 1/2] arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash Nathan Morrisson
@ 2023-12-15 19:18 ` Nathan Morrisson
2023-12-15 19:20 ` [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Andrew Davis
2 siblings, 0 replies; 6+ messages in thread
From: Nathan Morrisson @ 2023-12-15 19:18 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, upstream, w.egorov
Provide a fixed-partitions dummy node so bootladers can fixup
paritions.
Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
---
arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
index f87f09d83c95..a25ff4cf9373 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
@@ -207,6 +207,12 @@ flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <0>;
+
+ partitions{
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x ***
2023-12-15 19:18 [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Nathan Morrisson
2023-12-15 19:18 ` [PATCH 1/2] arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash Nathan Morrisson
2023-12-15 19:18 ` [PATCH 2/2] arm64: dts: ti: k3-am64-phycore-som: " Nathan Morrisson
@ 2023-12-15 19:20 ` Andrew Davis
2023-12-18 18:47 ` Nathan Morrisson
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Davis @ 2023-12-15 19:20 UTC (permalink / raw)
To: Nathan Morrisson, nm, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, upstream, w.egorov
On 12/15/23 1:18 PM, Nathan Morrisson wrote:
> Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x
> and phyCORE-AM64x to enable the bootloader to fixup the partitions
> during boot.
>
Why can't your bootloader add these nodes?
Andrew
> Nathan Morrisson (2):
> arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash
> arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR Flash
>
> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++
> arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++
> 2 files changed, 12 insertions(+)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x ***
2023-12-15 19:20 ` [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Andrew Davis
@ 2023-12-18 18:47 ` Nathan Morrisson
2023-12-18 19:41 ` Andrew Davis
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Morrisson @ 2023-12-18 18:47 UTC (permalink / raw)
To: Andrew Davis, nm, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, upstream, w.egorov
Hi Andrew,
We are adding the nodes directly to the device tree to match what is
done in other device trees, for example: k3-am642-tqma64xxl.dtsi. You
are correct that this could be done by the bootloader instead though.
Why do you prefer having the bootloader add the nodes?
Regards,
Nathan
On 12/15/23 11:20 AM, Andrew Davis wrote:
> On 12/15/23 1:18 PM, Nathan Morrisson wrote:
>> Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x
>> and phyCORE-AM64x to enable the bootloader to fixup the partitions
>> during boot.
>>
>
> Why can't your bootloader add these nodes?
>
> Andrew
>
>> Nathan Morrisson (2):
>> arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR
>> Flash
>> arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR
>> Flash
>>
>> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++
>> arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++
>> 2 files changed, 12 insertions(+)
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x ***
2023-12-18 18:47 ` Nathan Morrisson
@ 2023-12-18 19:41 ` Andrew Davis
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Davis @ 2023-12-18 19:41 UTC (permalink / raw)
To: Nathan Morrisson, nm, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, upstream, w.egorov
On 12/18/23 12:47 PM, Nathan Morrisson wrote:
> Hi Andrew,
>
> We are adding the nodes directly to the device tree to match what is done in other device trees, for example: k3-am642-tqma64xxl.dtsi. You are correct that this could be done by the bootloader instead though. Why do you prefer having the bootloader add the nodes?
>
k3-am642-tqma64xxl.dtsi should be fixed, it slipped past me and
shouldn't be used as a reference.
The bootloader might not fill it out at all, what if we start
using the new MTD GPT partitions? Then the new bootloaders
will have to start *removing* these stale half-nodes.
If the bootloader is going to add fixed partitions it should do
the whole job. There is no good reason to have a half complete
nodes here.
Andrew
> Regards,
>
> Nathan
>
> On 12/15/23 11:20 AM, Andrew Davis wrote:
>> On 12/15/23 1:18 PM, Nathan Morrisson wrote:
>>> Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x
>>> and phyCORE-AM64x to enable the bootloader to fixup the partitions
>>> during boot.
>>>
>>
>> Why can't your bootloader add these nodes?
>>
>> Andrew
>>
>>> Nathan Morrisson (2):
>>> arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash
>>> arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR Flash
>>>
>>> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++
>>> arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++
>>> 2 files changed, 12 insertions(+)
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread