* [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block
2024-01-23 12:17 [PATCH 0/5] Add RZ/G2UL CRU and CSI support Biju Das
@ 2024-01-23 12:17 ` Biju Das
2024-01-24 17:49 ` Conor Dooley
2024-01-23 12:17 ` [PATCH 2/5] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block Biju Das
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Biju Das @ 2024-01-23 12:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Lad Prabhakar,
linux-media, devicetree, linux-renesas-soc, Biju Das
Document the CSI-2 block which is part of CRU found in Renesas RZ/G2UL
SoC.
The CSI-2 block on the RZ/G2UL SoC is identical to one found on the
RZ/G2L SoC.
No driver changes are required as generic compatible string
"renesas,rzg2l-csi2" will be used as a fallback on RZ/G2UL SoC.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
index 67eea2ac1d22..7faa12fecd5b 100644
--- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
@@ -19,6 +19,7 @@ properties:
compatible:
items:
- enum:
+ - renesas,r9a07g043-csi2 # RZ/G2UL
- renesas,r9a07g044-csi2 # RZ/G2{L,LC}
- renesas,r9a07g054-csi2 # RZ/V2L
- const: renesas,rzg2l-csi2
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block
2024-01-23 12:17 ` [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block Biju Das
@ 2024-01-24 17:49 ` Conor Dooley
2024-01-25 14:17 ` Biju Das
0 siblings, 1 reply; 10+ messages in thread
From: Conor Dooley @ 2024-01-24 17:49 UTC (permalink / raw)
To: Biju Das
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, Magnus Damm, Lad Prabhakar,
linux-media, devicetree, linux-renesas-soc, Biju Das
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On Tue, Jan 23, 2024 at 12:17:16PM +0000, Biju Das wrote:
> Document the CSI-2 block which is part of CRU found in Renesas RZ/G2UL
> SoC.
>
> The CSI-2 block on the RZ/G2UL SoC is identical to one found on the
> RZ/G2L SoC.
>
> No driver changes are required as generic compatible string
> "renesas,rzg2l-csi2" will be used as a fallback on RZ/G2UL SoC.
Not super relevant to the bindings commit tbh.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> index 67eea2ac1d22..7faa12fecd5b 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> @@ -19,6 +19,7 @@ properties:
> compatible:
> items:
> - enum:
> + - renesas,r9a07g043-csi2 # RZ/G2UL
> - renesas,r9a07g044-csi2 # RZ/G2{L,LC}
> - renesas,r9a07g054-csi2 # RZ/V2L
> - const: renesas,rzg2l-csi2
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block
2024-01-24 17:49 ` Conor Dooley
@ 2024-01-25 14:17 ` Biju Das
0 siblings, 0 replies; 10+ messages in thread
From: Biju Das @ 2024-01-25 14:17 UTC (permalink / raw)
To: Conor Dooley
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, Magnus Damm,
Prabhakar Mahadev Lad, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
biju.das.au
Hi Conor Dooley,
Thanks for the feedback.
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Wednesday, January 24, 2024 5:49 PM
> Subject: Re: [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document
> Renesas RZ/G2UL CSI-2 block
>
> On Tue, Jan 23, 2024 at 12:17:16PM +0000, Biju Das wrote:
> > Document the CSI-2 block which is part of CRU found in Renesas RZ/G2UL
> > SoC.
> >
> > The CSI-2 block on the RZ/G2UL SoC is identical to one found on the
> > RZ/G2L SoC.
> >
>
> > No driver changes are required as generic compatible string
> > "renesas,rzg2l-csi2" will be used as a fallback on RZ/G2UL SoC.
>
> Not super relevant to the bindings commit tbh.
I agree driver doesn't have anything to do with bindings other than using
the fallback compatible. From bindings anyway one can get fallback
compatible details for a device. So strictly speaking it is not required.
I will remove this in next version, if there is no objection.
Cheers,
Biju
>
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Cheers,
> Conor.
>
> > ---
> > Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > index 67eea2ac1d22..7faa12fecd5b 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > @@ -19,6 +19,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - renesas,r9a07g043-csi2 # RZ/G2UL
> > - renesas,r9a07g044-csi2 # RZ/G2{L,LC}
> > - renesas,r9a07g054-csi2 # RZ/V2L
> > - const: renesas,rzg2l-csi2
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/5] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block
2024-01-23 12:17 [PATCH 0/5] Add RZ/G2UL CRU and CSI support Biju Das
2024-01-23 12:17 ` [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block Biju Das
@ 2024-01-23 12:17 ` Biju Das
2024-01-24 17:48 ` Conor Dooley
2024-01-23 12:17 ` [PATCH 3/5] arm64: dts: renesas: r9a07g043u: Add CSI and CRU nodes Biju Das
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Biju Das @ 2024-01-23 12:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Lad Prabhakar,
linux-media, devicetree, linux-renesas-soc, Biju Das
Document the CRU IP found in Renesas RZ/G2UL SoC.
The CRU block on the RZ/G2UL SoC is identical to one found on the
RZ/G2L SoC, but it does not support parallel input.
No driver changes are required as generic compatible string
"renesas,rzg2l-cru" will be used as a fallback on RZ/G2UL SoC.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
.../bindings/media/renesas,rzg2l-cru.yaml | 43 +++++++++++++++++--
1 file changed, 39 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
index 1e72b8808d24..7015a01fc1bc 100644
--- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
@@ -19,6 +19,7 @@ properties:
compatible:
items:
- enum:
+ - renesas,r9a07g043-cru # RZ/G2UL
- renesas,r9a07g044-cru # RZ/G2{L,LC}
- renesas,r9a07g054-cru # RZ/V2L
- const: renesas,rzg2l-cru
@@ -87,10 +88,6 @@ properties:
Input port node, describing the Image Processing module connected to the
CSI-2 receiver.
- required:
- - port@0
- - port@1
-
required:
- compatible
- reg
@@ -102,6 +99,44 @@ required:
- reset-names
- power-domains
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,r9a07g044-cru
+ - renesas,r9a07g054-cru
+ then:
+ properties:
+ ports:
+ properties:
+ port@0:
+ description: Parallel input
+ port@1:
+ description: CSI
+
+ required:
+ - port@0
+ - port@1
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,r9a07g043-cru
+ then:
+ properties:
+ ports:
+ properties:
+ port@0: false
+ port@1:
+ description: CSI-2
+
+ required:
+ - port@1
+
additionalProperties: false
examples:
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/5] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block
2024-01-23 12:17 ` [PATCH 2/5] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block Biju Das
@ 2024-01-24 17:48 ` Conor Dooley
2024-01-25 14:34 ` Biju Das
0 siblings, 1 reply; 10+ messages in thread
From: Conor Dooley @ 2024-01-24 17:48 UTC (permalink / raw)
To: Biju Das
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, Magnus Damm, Lad Prabhakar,
linux-media, devicetree, linux-renesas-soc, Biju Das
[-- Attachment #1: Type: text/plain, Size: 2893 bytes --]
On Tue, Jan 23, 2024 at 12:17:17PM +0000, Biju Das wrote:
> Document the CRU IP found in Renesas RZ/G2UL SoC.
>
> The CRU block on the RZ/G2UL SoC is identical to one found on the
> RZ/G2L SoC, but it does not support parallel input.
>
> No driver changes are required as generic compatible string
> "renesas,rzg2l-cru" will be used as a fallback on RZ/G2UL SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> .../bindings/media/renesas,rzg2l-cru.yaml | 43 +++++++++++++++++--
> 1 file changed, 39 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> index 1e72b8808d24..7015a01fc1bc 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> @@ -19,6 +19,7 @@ properties:
> compatible:
> items:
> - enum:
> + - renesas,r9a07g043-cru # RZ/G2UL
> - renesas,r9a07g044-cru # RZ/G2{L,LC}
> - renesas,r9a07g054-cru # RZ/V2L
> - const: renesas,rzg2l-cru
> @@ -87,10 +88,6 @@ properties:
> Input port node, describing the Image Processing module connected to the
> CSI-2 receiver.
>
> - required:
> - - port@0
> - - port@1
> -
> required:
> - compatible
> - reg
> @@ -102,6 +99,44 @@ required:
> - reset-names
> - power-domains
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r9a07g044-cru
> + - renesas,r9a07g054-cru
> + then:
> + properties:
> + ports:
> + properties:
> + port@0:
> + description: Parallel input
> + port@1:
> + description: CSI
> +
> + required:
> + - port@0
> + - port@1
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r9a07g043-cru
> + then:
> + properties:
> + ports:
> + properties:
> + port@0: false
> + port@1:
> + description: CSI-2
The description in the existing binding says that port @ 1 is CSI-2
already - but this patch seems to imply that it is only CSI-2 for the 43
model. I don't know the media stuff all that well, but is the port
actually CSI-2 on all 3 devices?
If so, I would drop the description stuff from here and just use the
if/else stuff to restrict the ports, rather than try to re-describe
them.
Cheers,
Conor.
> +
> + required:
> + - port@1
> +
> additionalProperties: false
>
> examples:
> --
> 2.25.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH 2/5] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block
2024-01-24 17:48 ` Conor Dooley
@ 2024-01-25 14:34 ` Biju Das
0 siblings, 0 replies; 10+ messages in thread
From: Biju Das @ 2024-01-25 14:34 UTC (permalink / raw)
To: Conor Dooley
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, Magnus Damm,
Prabhakar Mahadev Lad, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
biju.das.au
Hi Conor Dooley,
Thanks for the feedback.
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Wednesday, January 24, 2024 5:48 PM
> Subject: Re: [PATCH 2/5] media: dt-bindings: renesas,rzg2l-cru: Document
> Renesas RZ/G2UL CRU block
>
> On Tue, Jan 23, 2024 at 12:17:17PM +0000, Biju Das wrote:
> > Document the CRU IP found in Renesas RZ/G2UL SoC.
> >
> > The CRU block on the RZ/G2UL SoC is identical to one found on the
> > RZ/G2L SoC, but it does not support parallel input.
> >
> > No driver changes are required as generic compatible string
> > "renesas,rzg2l-cru" will be used as a fallback on RZ/G2UL SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > .../bindings/media/renesas,rzg2l-cru.yaml | 43 +++++++++++++++++--
> > 1 file changed, 39 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > index 1e72b8808d24..7015a01fc1bc 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > @@ -19,6 +19,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - renesas,r9a07g043-cru # RZ/G2UL
> > - renesas,r9a07g044-cru # RZ/G2{L,LC}
> > - renesas,r9a07g054-cru # RZ/V2L
> > - const: renesas,rzg2l-cru
> > @@ -87,10 +88,6 @@ properties:
> > Input port node, describing the Image Processing module
> connected to the
> > CSI-2 receiver.
> >
> > - required:
> > - - port@0
> > - - port@1
> > -
> > required:
> > - compatible
> > - reg
> > @@ -102,6 +99,44 @@ required:
> > - reset-names
> > - power-domains
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - renesas,r9a07g044-cru
> > + - renesas,r9a07g054-cru
> > + then:
> > + properties:
> > + ports:
> > + properties:
> > + port@0:
> > + description: Parallel input
> > + port@1:
> > + description: CSI
> > +
> > + required:
> > + - port@0
> > + - port@1
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - renesas,r9a07g043-cru
> > + then:
> > + properties:
> > + ports:
> > + properties:
> > + port@0: false
> > + port@1:
> > + description: CSI-2
>
> The description in the existing binding says that port @ 1 is CSI-2
> already - but this patch seems to imply that it is only CSI-2 for the 43
> model. I don't know the media stuff all that well, but is the port
> actually CSI-2 on all 3 devices?
RZ/G2{L,LC} abd RZ/V2L has 2 ports one is parallel and other one is CSI
Where as RZ/G2UL has only 1 port (CSI).
As you said, it correct CSI-2 present on all 3 devices.
>
> If so, I would drop the description stuff from here and just use the
> if/else stuff to restrict the ports, rather than try to re-describe them.
Agreed. Will fix this in next version along with fixing commit description
for removing driver changes.
Cheers,
Biju
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/5] arm64: dts: renesas: r9a07g043u: Add CSI and CRU nodes
2024-01-23 12:17 [PATCH 0/5] Add RZ/G2UL CRU and CSI support Biju Das
2024-01-23 12:17 ` [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block Biju Das
2024-01-23 12:17 ` [PATCH 2/5] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block Biju Das
@ 2024-01-23 12:17 ` Biju Das
2024-01-23 12:17 ` [PATCH 4/5] arm64: dts: renesas: rzg2ul-smarc: Enable CRU, CSI support Biju Das
2024-01-23 12:17 ` [PATCH 5/5] arm64: dts: renesas: r9a07g043u11-smarc-cru-csi-ov5645: Reduce I2C frequency Biju Das
4 siblings, 0 replies; 10+ messages in thread
From: Biju Das @ 2024-01-23 12:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Prabhakar Mahadev Lad, Biju Das
Add CSI and CRU nodes r9a07g043 (RZ/G2UL) SoC DTSI.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 69 +++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi
index 2ab231572d95..01d08ebb4a78 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi
@@ -61,6 +61,75 @@ &pinctrl {
&soc {
interrupt-parent = <&gic>;
+ cru: video@10830000 {
+ compatible = "renesas,r9a07g043-cru", "renesas,rzg2l-cru";
+ reg = <0 0x10830000 0 0x400>;
+ clocks = <&cpg CPG_MOD R9A07G043_CRU_VCLK>,
+ <&cpg CPG_MOD R9A07G043_CRU_PCLK>,
+ <&cpg CPG_MOD R9A07G043_CRU_ACLK>;
+ clock-names = "video", "apb", "axi";
+ interrupts = <SOC_PERIPHERAL_IRQ(167) IRQ_TYPE_LEVEL_HIGH>,
+ <SOC_PERIPHERAL_IRQ(168) IRQ_TYPE_LEVEL_HIGH>,
+ <SOC_PERIPHERAL_IRQ(169) IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "image_conv", "image_conv_err", "axi_mst_err";
+ resets = <&cpg R9A07G043_CRU_PRESETN>,
+ <&cpg R9A07G043_CRU_ARESETN>;
+ reset-names = "presetn", "aresetn";
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ reg = <1>;
+ crucsi2: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&csi2cru>;
+ };
+ };
+ };
+ };
+
+ csi2: csi2@10830400 {
+ compatible = "renesas,r9a07g043-csi2", "renesas,rzg2l-csi2";
+ reg = <0 0x10830400 0 0xfc00>;
+ interrupts = <SOC_PERIPHERAL_IRQ(166) IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD R9A07G043_CRU_SYSCLK>,
+ <&cpg CPG_MOD R9A07G043_CRU_VCLK>,
+ <&cpg CPG_MOD R9A07G043_CRU_PCLK>;
+ clock-names = "system", "video", "apb";
+ resets = <&cpg R9A07G043_CRU_PRESETN>,
+ <&cpg R9A07G043_CRU_CMN_RSTB>;
+ reset-names = "presetn", "cmn-rstb";
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ };
+
+ port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+
+ csi2cru: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&crucsi2>;
+ };
+ };
+ };
+ };
+
irqc: interrupt-controller@110a0000 {
compatible = "renesas,r9a07g043u-irqc",
"renesas,rzg2l-irqc";
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/5] arm64: dts: renesas: rzg2ul-smarc: Enable CRU, CSI support
2024-01-23 12:17 [PATCH 0/5] Add RZ/G2UL CRU and CSI support Biju Das
` (2 preceding siblings ...)
2024-01-23 12:17 ` [PATCH 3/5] arm64: dts: renesas: r9a07g043u: Add CSI and CRU nodes Biju Das
@ 2024-01-23 12:17 ` Biju Das
2024-01-23 12:17 ` [PATCH 5/5] arm64: dts: renesas: r9a07g043u11-smarc-cru-csi-ov5645: Reduce I2C frequency Biju Das
4 siblings, 0 replies; 10+ messages in thread
From: Biju Das @ 2024-01-23 12:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Prabhakar Mahadev Lad, Biju Das
Enable CRU, CSI on RZ/G2UL SMARC EVK and tie the CSI to the OV5645 sensor
using Device Tree overlay.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/Makefile | 2 ++
.../r9a07g043u11-smarc-cru-csi-ov5645.dtso | 21 +++++++++++++++++++
2 files changed, 23 insertions(+)
create mode 100644 arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso
diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 8ea68d582710..f46d6f0b26ab 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -104,6 +104,8 @@ dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs-panel-aa104xd12.dtb
dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc.dtb
dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043-smarc-pmod.dtbo
+r9a07g043u11-smarc-cru-csi-ov5645-dtbs := r9a07g043u11-smarc.dtb r9a07g043u11-smarc-cru-csi-ov5645.dtbo
+dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc-cru-csi-ov5645.dtb
r9a07g043u11-smarc-pmod-dtbs := r9a07g043u11-smarc.dtb r9a07g043-smarc-pmod.dtbo
dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc-pmod.dtb
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso b/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso
new file mode 100644
index 000000000000..b41bb4b31a26
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree overlay for the RZ/G2UL SMARC EVK with OV5645 camera
+ * connected to CSI and CRU enabled.
+ *
+ * Copyright (C) 2024 Renesas Electronics Corp.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
+
+#define OV5645_PARENT_I2C i2c0
+#include "rz-smarc-cru-csi-ov5645.dtsi"
+
+&ov5645 {
+ enable-gpios = <&pinctrl RZG2L_GPIO(4, 4) GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pinctrl RZG2L_GPIO(0, 1) GPIO_ACTIVE_LOW>;
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/5] arm64: dts: renesas: r9a07g043u11-smarc-cru-csi-ov5645: Reduce I2C frequency
2024-01-23 12:17 [PATCH 0/5] Add RZ/G2UL CRU and CSI support Biju Das
` (3 preceding siblings ...)
2024-01-23 12:17 ` [PATCH 4/5] arm64: dts: renesas: rzg2ul-smarc: Enable CRU, CSI support Biju Das
@ 2024-01-23 12:17 ` Biju Das
4 siblings, 0 replies; 10+ messages in thread
From: Biju Das @ 2024-01-23 12:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Prabhakar Mahadev Lad, Biju Das
Reduce i2c freq from 400->100 kHz on RZ/G2UL SMARC EVK as the captured
image is not proper with the sensor configuration over I2C.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
.../boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso b/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso
index b41bb4b31a26..bb769c0f3ca5 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso
+++ b/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc-cru-csi-ov5645.dtso
@@ -19,3 +19,7 @@ &ov5645 {
enable-gpios = <&pinctrl RZG2L_GPIO(4, 4) GPIO_ACTIVE_HIGH>;
reset-gpios = <&pinctrl RZG2L_GPIO(0, 1) GPIO_ACTIVE_LOW>;
};
+
+&i2c0 {
+ clock-frequency = <100000>;
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread