[PATCH 0/2] dt-bindings: trivial-devices: add RAA228004 and IPMB-DEV

[PATCH 0/2] dt-bindings: trivial-devices: add RAA228004 and IPMB-DEV

[Potin Lai]

Add RAA228004 and IPMB-DEV in to trivial-devices list.

Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
---
Potin Lai (2):
      dt-bindings: trivial-devices: add isil,raa228004
      dt-bindings: trivial-devices: add ipmb-dev

 Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
 1 file changed, 4 insertions(+)
---
base-commit: 59b723cd2adbac2a34fc8e12c74ae26ae45bf230
change-id: 20241120-trivial-devices-81d6caa95069

Best regards,
-- 
Potin Lai <potin.lai.pt@gmail.com>

[PATCH 1/2] dt-bindings: trivial-devices: add isil,raa228004

[Potin Lai]

The RAA228004 is a Power Converter with Multiple Power Trains.

Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 9bf0fb17a05e..aa09dc51dab7 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -161,6 +161,8 @@ properties:
           - isil,isl69269
             # Intersil ISL76682 Ambient Light Sensor
           - isil,isl76682
+            # Renesas RAA228004 Power Converters
+          - isil,raa228004
             # JEDEC JESD300 (SPD5118) Hub and Serial Presence Detect
           - jedec,spd5118
             # Linear Technology LTC2488

-- 
2.31.1

[PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev

[Potin Lai]

Add ipmb-dev into trivial-devices to support IPMB device node.

Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index aa09dc51dab7..89dfac9b6a9e 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -149,6 +149,8 @@ properties:
           - injoinic,ip5209
             # Inspur Power System power supply unit version 1
           - inspur,ipsps1
+            # IPMB Device
+          - ipmb-dev
             # Intersil ISL29028 Ambient Light and Proximity Sensor
           - isil,isl29028
             # Intersil ISL29030 Ambient Light and Proximity Sensor

-- 
2.31.1

Re: [PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

On Wed, Nov 20, 2024 at 11:28:07PM +0800, Potin Lai wrote:
> Add ipmb-dev into trivial-devices to support IPMB device node.

What is an "impb device"? You need a better description than this.

> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index aa09dc51dab7..89dfac9b6a9e 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -149,6 +149,8 @@ properties:
>            - injoinic,ip5209
>              # Inspur Power System power supply unit version 1
>            - inspur,ipsps1
> +            # IPMB Device
> +          - ipmb-dev
>              # Intersil ISL29028 Ambient Light and Proximity Sensor
>            - isil,isl29028
>              # Intersil ISL29030 Ambient Light and Proximity Sensor
> 
> -- 
> 2.31.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: trivial-devices: add isil,raa228004

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Wed, Nov 20, 2024 at 11:28:06PM +0800, Potin Lai wrote:
> The RAA228004 is a Power Converter with Multiple Power Trains.

This isn't a SPI or I2C device, so I don't think it is appropriate to
document it here. Seemingly it is PWM controlled, so at least you're
going to have a pwms property.

Cheers,
Conor.

> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 9bf0fb17a05e..aa09dc51dab7 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -161,6 +161,8 @@ properties:
>            - isil,isl69269
>              # Intersil ISL76682 Ambient Light Sensor
>            - isil,isl76682
> +            # Renesas RAA228004 Power Converters
> +          - isil,raa228004
>              # JEDEC JESD300 (SPD5118) Hub and Serial Presence Detect
>            - jedec,spd5118
>              # Linear Technology LTC2488
> 
> -- 
> 2.31.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev

[Krzysztof Kozlowski]

On 20/11/2024 17:22, Conor Dooley wrote:
> On Wed, Nov 20, 2024 at 11:28:07PM +0800, Potin Lai wrote:
>> Add ipmb-dev into trivial-devices to support IPMB device node.
> 
> What is an "impb device"? You need a better description than this.
And provide users of these two. That's necessary for something that is
not even matching standard compatible format.

Best regards,
Krzysztof