From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, krzk+dt@kernel.org,
conor+dt@kernel.org, ana-maria.cusco@analog.com,
marcelo.schmitt1@gmail.com
Subject: Re: [RFC PATCH 2/4] dt-bindings: iio: adc: Add AD4170
Date: Thu, 19 Dec 2024 14:07:04 +0000 [thread overview]
Message-ID: <20241219140704.2d06403f@jic23-huawei> (raw)
In-Reply-To: <20241218194804.GA2203791-robh@kernel.org>
On Wed, 18 Dec 2024 13:48:04 -0600
Rob Herring <robh@kernel.org> wrote:
> On Wed, Dec 18, 2024 at 11:37:42AM -0300, Marcelo Schmitt wrote:
> > Add device tree documentation for AD4170 sigma-delta ADCs.
> >
>
> The usual question with long lists of properties. Any of these should be
> run-time controlled (by userspace) instead? If they might vary by the
> user for given h/w design, then should be user controlled instead.
Hi Rob,
I took a look and mostly make sense in DT as they are hardware design
things as it's all about driving an external bridge circuit for
which there will be a correct configuration.
There were a few exceptions however hiding in amongst them!
ADCs that support Wheatstone bridge operations are probably my least
favourite drivers to review. Very very fiddly as they have
complex (and random seeming) control functions for circuitry that
is off chip and only somewhat standard.
Jonathan
next prev parent reply other threads:[~2024-12-19 14:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 14:37 [RFC PATCH 0/4] Add support for AD4170 Marcelo Schmitt
2024-12-18 14:37 ` [RFC PATCH 1/4] include: dt-bindings: iio: adc: Add defines " Marcelo Schmitt
2024-12-19 9:22 ` Krzysztof Kozlowski
2024-12-18 14:37 ` [RFC PATCH 2/4] dt-bindings: iio: adc: Add AD4170 Marcelo Schmitt
2024-12-18 15:25 ` Rob Herring (Arm)
2024-12-18 19:48 ` Rob Herring
2024-12-19 14:07 ` Jonathan Cameron [this message]
2024-12-19 14:03 ` Jonathan Cameron
2024-12-18 14:37 ` [RFC PATCH 3/4] iio: adc: Add support for AD4170 Marcelo Schmitt
2024-12-19 9:25 ` Krzysztof Kozlowski
2024-12-19 14:15 ` Jonathan Cameron
2024-12-19 15:04 ` Jonathan Cameron
2024-12-19 19:49 ` David Lechner
2024-12-18 14:38 ` [RFC PATCH 4/4] Documentation: iio: Add ADC documentation Marcelo Schmitt
2024-12-18 20:46 ` David Lechner
2024-12-19 12:55 ` Jonathan Cameron
2025-01-14 13:36 ` Marcelo Schmitt
2025-01-14 13:33 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219140704.2d06403f@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=ana-maria.cusco@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox