From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: David Lechner <dlechner@baylibre.com>,
Marcelo Schmitt <marcelo.schmitt@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
ana-maria.cusco@analog.com
Subject: Re: [RFC PATCH 4/4] Documentation: iio: Add ADC documentation
Date: Tue, 14 Jan 2025 10:36:54 -0300 [thread overview]
Message-ID: <Z4ZodgpXRTNP5Rer@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20241219125503.6c909c24@jic23-huawei>
On 12/19, Jonathan Cameron wrote:
> On Wed, 18 Dec 2024 14:46:14 -0600
> David Lechner <dlechner@baylibre.com> wrote:
>
> > On 12/18/24 8:38 AM, Marcelo Schmitt wrote:
> > > ADCs can have different input configurations such that developers can get
> > > confused when trying to model some of them into IIO channels.
> > >
...
> > > Add documentation about common ADC characteristics and IIO support for them.
> > >
> > > [1]: https://lore.kernel.org/linux-iio/0fef36f8-a7db-40cc-86bd-9449cb4ab46e@gmail.com/
> > > [2]: https://www.analog.com/en/resources/technical-articles/sar-adc-input-types.html.
> > >
> > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> > > ---
> >
...
> > > +1. ADC Channel Types
> > > +====================
> > > +
> > > +ADCs can have distinct types of inputs, each of them measuring analog voltages
> > > +in a slightly different way. An ADC digitizes the analog input voltage over a
> > > +span given by the provided voltage reference, the input type, and the input
> > > +polarity. The input range allowed to an ADC channel is needed to determine the
> > > +scale factor and offset needed to obtain the measured value in real-world
> > > +units (millivolts for voltage measurement, milliamps for current measurement,
> > > +etc.).
>
> Add some 'weasel' words in here. There are more complex non linear ADCs and ones
> only capable of reaching some fraction of the reference voltage.
> Maybe throw in a "generally" somewhere.
V2 will come with a short paragraph with a disclaimer for complex ADCs :)
Thanks,
Marcelo
next prev parent reply other threads:[~2025-01-14 13:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 14:37 [RFC PATCH 0/4] Add support for AD4170 Marcelo Schmitt
2024-12-18 14:37 ` [RFC PATCH 1/4] include: dt-bindings: iio: adc: Add defines " Marcelo Schmitt
2024-12-19 9:22 ` Krzysztof Kozlowski
2024-12-18 14:37 ` [RFC PATCH 2/4] dt-bindings: iio: adc: Add AD4170 Marcelo Schmitt
2024-12-18 15:25 ` Rob Herring (Arm)
2024-12-18 19:48 ` Rob Herring
2024-12-19 14:07 ` Jonathan Cameron
2024-12-19 14:03 ` Jonathan Cameron
2024-12-18 14:37 ` [RFC PATCH 3/4] iio: adc: Add support for AD4170 Marcelo Schmitt
2024-12-19 9:25 ` Krzysztof Kozlowski
2024-12-19 14:15 ` Jonathan Cameron
2024-12-19 15:04 ` Jonathan Cameron
2024-12-19 19:49 ` David Lechner
2024-12-18 14:38 ` [RFC PATCH 4/4] Documentation: iio: Add ADC documentation Marcelo Schmitt
2024-12-18 20:46 ` David Lechner
2024-12-19 12:55 ` Jonathan Cameron
2025-01-14 13:36 ` Marcelo Schmitt [this message]
2025-01-14 13:33 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4ZodgpXRTNP5Rer@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=ana-maria.cusco@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox