Re: [RFC PATCH 3/4] iio: adc: Add support for AD4170

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 19 Dec 2024 10:25:42 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Wed, Dec 18, 2024 at 11:37:59AM -0300, Marcelo Schmitt wrote:
> > +#include <asm/div64.h>
> > +#include <linux/unaligned.h>
> > +
> > +#include <linux/iio/buffer.h>
> > +#include <linux/iio/iio.h>
> > +#include <linux/iio/kfifo_buf.h>
> > +#include <linux/iio/sysfs.h>
> > +#include <linux/iio/trigger.h>
> > +#include <linux/iio/triggered_buffer.h>
> > +#include <linux/iio/trigger_consumer.h>
> > +#include "ad4170.h"
> > +  
> 
> No bindings header included? No usage of binding defines (I did look for
> them in case you have some incorrect include via other header)? So not a
> binding...

It's in the local header in this patch.

> diff --git a/drivers/iio/adc/ad4170.h b/drivers/iio/adc/ad4170.h
> new file mode 100644
> index 000000000000..5b24788314b1
> --- /dev/null
> +++ b/drivers/iio/adc/ad4170.h
> @@ -0,0 +1,316 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * AD4170 ADC driver
> + *
> + * Copyright 2024 Analog Devices Inc.
> + */
> +
> +#include <dt-bindings/iio/adc/adi,ad4170.h>

Agreed on the lack of them being used as widely as they should be though!

> 
> Best regards,
> Krzysztof
>