* [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements
@ 2024-12-29 23:01 Andreas Kemnade
2024-12-29 23:01 ` [PATCH 1/2] ARM: dts: omap4: panda: fix resources needed for Panda Andreas Kemnade
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Andreas Kemnade @ 2024-12-29 23:01 UTC (permalink / raw)
To: Rob Herring, Conor Dooley, linux-omap, linux-kernel,
Roger Quadros, Aaro Koskinen, Kevin Hilman, devicetree,
Krzysztof Kozlowski, Tony Lindgren
Cc: Andreas Kemnade
Add proper definitions for 32k clock and enable bluetooth
everywhere.
Andreas Kemnade (2):
ARM: dts: omap4: panda: fix resources needed for Panda
ARM: dts: omap4: panda: cleanup bluetooth
.../boot/dts/ti/omap/omap4-panda-common.dtsi | 38 ++++++++++++++++++-
arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ----------------
2 files changed, 36 insertions(+), 34 deletions(-)
--
2.39.5
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] ARM: dts: omap4: panda: fix resources needed for Panda 2024-12-29 23:01 [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Andreas Kemnade @ 2024-12-29 23:01 ` Andreas Kemnade 2024-12-29 23:01 ` [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth Andreas Kemnade 2024-12-30 18:17 ` [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Rob Herring (Arm) 2 siblings, 0 replies; 7+ messages in thread From: Andreas Kemnade @ 2024-12-29 23:01 UTC (permalink / raw) To: Rob Herring, Conor Dooley, linux-omap, linux-kernel, Roger Quadros, Aaro Koskinen, Kevin Hilman, devicetree, Krzysztof Kozlowski, Tony Lindgren Cc: Andreas Kemnade The Pandaboard needs a 32k clock in the TWL6030 to be enabled to work. With some luck, it is enabled by some U-Boot fork. Do not rely on it and properly specify the requirement. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi index 97706d6296a6..c860b590142a 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi @@ -130,6 +130,12 @@ hsusb1_phy: hsusb1_phy { clock-frequency = <19200000>; }; + wl12xx_pwrseq: wl12xx-pwrseq { + compatible = "mmc-pwrseq-simple"; + clocks = <&twl 0>; + clock-names = "ext_clock"; + }; + /* regulator for wl12xx on sdio5 */ wl12xx_vmmc: wl12xx_vmmc { pinctrl-names = "default"; @@ -408,6 +414,7 @@ twl: twl@48 { reg = <0x48>; /* IRQ# = 7 */ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */ + #clock-cells = <1>; system-power-controller; }; @@ -488,6 +495,7 @@ &mmc5 { non-removable; bus-width = <4>; cap-power-off-card; + mmc-pwrseq = <&wl12xx_pwrseq>; #address-cells = <1>; #size-cells = <0>; -- 2.39.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth 2024-12-29 23:01 [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Andreas Kemnade 2024-12-29 23:01 ` [PATCH 1/2] ARM: dts: omap4: panda: fix resources needed for Panda Andreas Kemnade @ 2024-12-29 23:01 ` Andreas Kemnade 2025-01-04 17:29 ` Roger Quadros 2024-12-30 18:17 ` [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Rob Herring (Arm) 2 siblings, 1 reply; 7+ messages in thread From: Andreas Kemnade @ 2024-12-29 23:01 UTC (permalink / raw) To: Rob Herring, Conor Dooley, linux-omap, linux-kernel, Roger Quadros, Aaro Koskinen, Kevin Hilman, devicetree, Krzysztof Kozlowski, Tony Lindgren Cc: Andreas Kemnade Bluetooth is available on the other Panda board versions, too, so move stuff to common and specify the needed clock properly. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++-- arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ------------------- 2 files changed, 28 insertions(+), 34 deletions(-) diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi index c860b590142a..c048ab9af053 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */ wl12xx_gpio: wl12xx-gpio-pins { pinctrl-single,pins = < OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */ OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */ >; }; @@ -393,6 +391,22 @@ button_pins: button-pins { OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */ >; }; + + bt_pins: bt-pins { + pinctrl-single,pins = < + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */ + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */ + >; + }; + + uart2_pins: uart2-pins { + pinctrl-single,pins = < + OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts - HCI */ + OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts */ + OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx */ + OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx */ + >; + }; }; &omap4_pmx_wkup { @@ -531,8 +545,20 @@ &twl_usb_comparator { }; &uart2 { + pinctrl-names = "default"; + pinctrl-0 = <&uart2_pins>; + interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH &omap4_pmx_core OMAP4_UART2_RX>; + + bluetooth { + compatible = "ti,wl1271-st"; + pinctrl-names = "default"; + pinctrl-0 = <&bt_pins>; + enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */ + clocks = <&twl 0>; + clock-names = "ext_clock"; + }; }; &uart3 { diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts index fe7b156d10ed..a933fe560834 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts @@ -49,22 +49,6 @@ button_pins: button-pins { OMAP4_IOPAD(0x0fc, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_113 */ >; }; - - bt_pins: bt-pins { - pinctrl-single,pins = < - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */ - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */ - >; - }; - - uart2_pins: uart2-pins { - pinctrl-single,pins = < - OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts.uart2_cts - HCI */ - OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts.uart2_rts */ - OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx.uart2_rx */ - OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx.uart2_tx */ - >; - }; }; &led_wkgpio_pins { @@ -96,19 +80,3 @@ buttonS2 { &gpio1_target { ti,no-reset-on-init; }; - -&wl12xx_gpio { - pinctrl-single,pins = < - OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ - OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ - >; -}; - -&uart2 { - pinctrl-names = "default"; - pinctrl-0 = <&uart2_pins &bt_pins>; - bluetooth: tiwi { - compatible = "ti,wl1271-st"; - enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */ - }; -}; -- 2.39.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth 2024-12-29 23:01 ` [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth Andreas Kemnade @ 2025-01-04 17:29 ` Roger Quadros 2025-01-04 18:41 ` Andreas Kemnade 0 siblings, 1 reply; 7+ messages in thread From: Roger Quadros @ 2025-01-04 17:29 UTC (permalink / raw) To: Andreas Kemnade, Rob Herring, Conor Dooley, linux-omap, linux-kernel, Aaro Koskinen, Kevin Hilman, devicetree, Krzysztof Kozlowski, Tony Lindgren Hello Andreas, On 30/12/2024 01:01, Andreas Kemnade wrote: > Bluetooth is available on the other Panda board versions, too, so move > stuff to common and specify the needed clock properly. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++-- > arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ------------------- > 2 files changed, 28 insertions(+), 34 deletions(-) > > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > index c860b590142a..c048ab9af053 100644 > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */ > wl12xx_gpio: wl12xx-gpio-pins { > pinctrl-single,pins = < > OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */ > - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */ > OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ This one is FM_EN and has nothing to do with WLAN. > - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */ > >; > }; > > @@ -393,6 +391,22 @@ button_pins: button-pins { > OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */ > >; > }; > + > + bt_pins: bt-pins { > + pinctrl-single,pins = < > + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */ > + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */ Could we please use comment style <pin name>.<pinmux name> - Function OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */ OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */ > + >; > + }; > + > + uart2_pins: uart2-pins { > + pinctrl-single,pins = < > + OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts - HCI */ > + OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts */ > + OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx */ > + OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx */ Need to fix comment style to <pin name>.<pinmux name> - Function > + >; > + }; > }; > > &omap4_pmx_wkup { > @@ -531,8 +545,20 @@ &twl_usb_comparator { > }; > > &uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart2_pins>; > + Unnecessary new line. > interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH > &omap4_pmx_core OMAP4_UART2_RX>; > + Here too? > + bluetooth { > + compatible = "ti,wl1271-st"; > + pinctrl-names = "default"; > + pinctrl-0 = <&bt_pins>; > + enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */ > + clocks = <&twl 0>; > + clock-names = "ext_clock"; > + }; > }; > > &uart3 { > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts > index fe7b156d10ed..a933fe560834 100644 > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts > @@ -49,22 +49,6 @@ button_pins: button-pins { > OMAP4_IOPAD(0x0fc, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_113 */ > >; > }; > - > - bt_pins: bt-pins { > - pinctrl-single,pins = < > - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */ > - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */ > - >; > - }; > - > - uart2_pins: uart2-pins { > - pinctrl-single,pins = < > - OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts.uart2_cts - HCI */ > - OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts.uart2_rts */ > - OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx.uart2_rx */ > - OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx.uart2_tx */ > - >; > - }; > }; > > &led_wkgpio_pins { > @@ -96,19 +80,3 @@ buttonS2 { > &gpio1_target { > ti,no-reset-on-init; > }; > - > -&wl12xx_gpio { > - pinctrl-single,pins = < > - OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ > - OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ > - >; > -}; > - > -&uart2 { > - pinctrl-names = "default"; > - pinctrl-0 = <&uart2_pins &bt_pins>; > - bluetooth: tiwi { > - compatible = "ti,wl1271-st"; > - enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */ > - }; > -}; -- cheers, -roger ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth 2025-01-04 17:29 ` Roger Quadros @ 2025-01-04 18:41 ` Andreas Kemnade 2025-01-07 12:33 ` Roger Quadros 0 siblings, 1 reply; 7+ messages in thread From: Andreas Kemnade @ 2025-01-04 18:41 UTC (permalink / raw) To: Roger Quadros Cc: Rob Herring, Conor Dooley, linux-omap, linux-kernel, Aaro Koskinen, Kevin Hilman, devicetree, Krzysztof Kozlowski, Tony Lindgren Hello Roger, Am Sat, 4 Jan 2025 19:29:44 +0200 schrieb Roger Quadros <rogerq@kernel.org>: > Hello Andreas, > > On 30/12/2024 01:01, Andreas Kemnade wrote: > > Bluetooth is available on the other Panda board versions, too, so move > > stuff to common and specify the needed clock properly. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++-- > > arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ------------------- > > 2 files changed, 28 insertions(+), 34 deletions(-) > > > > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > > index c860b590142a..c048ab9af053 100644 > > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > > @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */ > > wl12xx_gpio: wl12xx-gpio-pins { > > pinctrl-single,pins = < > > OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ > > We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */ > This is about existing code, there is still a lot of room to cleanup other stuff. > > - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */ > > OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ > > This one is FM_EN and has nothing to do with WLAN. > same here. > > - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */ > > >; > > }; > > > > @@ -393,6 +391,22 @@ button_pins: button-pins { > > OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */ > > >; > > }; > > + > > + bt_pins: bt-pins { > > + pinctrl-single,pins = < > > + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */ > > + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */ > > Could we please use comment style <pin name>.<pinmux name> - Function > OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */ > OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */ > I was a bit lazy with checkpatch.pl. Your proposal generates a lot of noise there, so I was too lazy to filter that noise, so I disabled that noise. I had it first that way. Regards, Andreas ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth 2025-01-04 18:41 ` Andreas Kemnade @ 2025-01-07 12:33 ` Roger Quadros 0 siblings, 0 replies; 7+ messages in thread From: Roger Quadros @ 2025-01-07 12:33 UTC (permalink / raw) To: Andreas Kemnade Cc: Rob Herring, Conor Dooley, linux-omap, linux-kernel, Aaro Koskinen, Kevin Hilman, devicetree, Krzysztof Kozlowski, Tony Lindgren On 04/01/2025 20:41, Andreas Kemnade wrote: > Hello Roger, > > Am Sat, 4 Jan 2025 19:29:44 +0200 > schrieb Roger Quadros <rogerq@kernel.org>: > >> Hello Andreas, >> >> On 30/12/2024 01:01, Andreas Kemnade wrote: >>> Bluetooth is available on the other Panda board versions, too, so move >>> stuff to common and specify the needed clock properly. >>> >>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info> >>> --- >>> .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++-- >>> arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ------------------- >>> 2 files changed, 28 insertions(+), 34 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi >>> index c860b590142a..c048ab9af053 100644 >>> --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi >>> +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi >>> @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */ >>> wl12xx_gpio: wl12xx-gpio-pins { >>> pinctrl-single,pins = < >>> OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ >> >> We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */ >> > This is about existing code, there is still a lot of room to cleanup > other stuff. > >>> - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */ >>> OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ >> >> This one is FM_EN and has nothing to do with WLAN. >> > same here. >>> - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */ >>> >; >>> }; >>> >>> @@ -393,6 +391,22 @@ button_pins: button-pins { >>> OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */ >>> >; >>> }; >>> + >>> + bt_pins: bt-pins { >>> + pinctrl-single,pins = < >>> + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */ >>> + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */ >> >> Could we please use comment style <pin name>.<pinmux name> - Function >> OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */ >> OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */ >> > I was a bit lazy with checkpatch.pl. Your proposal generates a lot of > noise there, so I was too lazy to filter that noise, so I disabled that > noise. I had it first that way. What noise? line length exceeded warnings? Those are harmless. I'd prefer not to loose the pinmux/function information in the comment. -- cheers, -roger ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements 2024-12-29 23:01 [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Andreas Kemnade 2024-12-29 23:01 ` [PATCH 1/2] ARM: dts: omap4: panda: fix resources needed for Panda Andreas Kemnade 2024-12-29 23:01 ` [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth Andreas Kemnade @ 2024-12-30 18:17 ` Rob Herring (Arm) 2 siblings, 0 replies; 7+ messages in thread From: Rob Herring (Arm) @ 2024-12-30 18:17 UTC (permalink / raw) To: Andreas Kemnade Cc: linux-kernel, Aaro Koskinen, devicetree, Kevin Hilman, Krzysztof Kozlowski, Tony Lindgren, Roger Quadros, linux-omap, Conor Dooley On Mon, 30 Dec 2024 00:01:23 +0100, Andreas Kemnade wrote: > Add proper definitions for 32k clock and enable bluetooth > everywhere. > > Andreas Kemnade (2): > ARM: dts: omap4: panda: fix resources needed for Panda > ARM: dts: omap4: panda: cleanup bluetooth > > .../boot/dts/ti/omap/omap4-panda-common.dtsi | 38 ++++++++++++++++++- > arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ---------------- > 2 files changed, 36 insertions(+), 34 deletions(-) > > -- > 2.39.5 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y ti/omap/omap4-panda-es.dtb' for 20241229230125.85787-1-andreas@kemnade.info: arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names': ['default'], 'pinctrl-0': [[119]], 'interrupts-extended': [[1, 0, 73, 4], [117, 220]], 'bluetooth': {'compatible': ['ti,wl1271-st'], 'pinctrl-names': ['default'], 'pinctrl-0': [[120]], 'enable-gpios': [[121, 14, 0]], 'clocks': [[122, 0]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']} from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml# ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-01-07 12:34 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-12-29 23:01 [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Andreas Kemnade 2024-12-29 23:01 ` [PATCH 1/2] ARM: dts: omap4: panda: fix resources needed for Panda Andreas Kemnade 2024-12-29 23:01 ` [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth Andreas Kemnade 2025-01-04 17:29 ` Roger Quadros 2025-01-04 18:41 ` Andreas Kemnade 2025-01-07 12:33 ` Roger Quadros 2024-12-30 18:17 ` [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Rob Herring (Arm)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox