[net-next v1] dt-bindings: can: mpfs: document resets

[net-next v1] dt-bindings: can: mpfs: document resets

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

The CAN cores on Polarfire SoC both have a reset. The platform firmware
brings both cores out of reset, but the linux driver must use them
during normal operation. The resets should have been made required, but
this is one of the things that can happen when the binding is written
without driver support.

Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
This is the second mistake in this binding, both spotted because of the
driver being written (although this one sat downstream for a while for
w/e reason). I wish I could say that I'd send the driver soon, but I am
busy upstreaming things I wrote and therefore understand at the moment,
so a driver that I'd have to go understand and review before sending is
low priority, sorry!

CC: Conor Dooley <conor.dooley@microchip.com>
CC: Daire McNamara <daire.mcnamara@microchip.com>
CC: Marc Kleine-Budde <mkl@pengutronix.de>
CC: Vincent Mailhol <mailhol@kernel.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: linux-riscv@lists.infradead.org
CC: linux-can@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
 .../devicetree/bindings/net/can/microchip,mpfs-can.yaml       | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
index 1219c5cb601f..d2a378064c50 100644
--- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
+++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
@@ -32,11 +32,15 @@ properties:
       - description: AHB peripheral clock
       - description: CAN bus clock
 
+  resets:
+    maxItems: 1
+
 required:
   - compatible
   - reg
   - interrupts
   - clocks
+  - resets
 
 additionalProperties: false
 
-- 
2.51.0

Re: [net-next v1] dt-bindings: can: mpfs: document resets

[Rob Herring (Arm)]

On Mon, 17 Nov 2025 16:38:18 +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> The CAN cores on Polarfire SoC both have a reset. The platform firmware
> brings both cores out of reset, but the linux driver must use them
> during normal operation. The resets should have been made required, but
> this is one of the things that can happen when the binding is written
> without driver support.
> 
> Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> This is the second mistake in this binding, both spotted because of the
> driver being written (although this one sat downstream for a while for
> w/e reason). I wish I could say that I'd send the driver soon, but I am
> busy upstreaming things I wrote and therefore understand at the moment,
> so a driver that I'd have to go understand and review before sending is
> low priority, sorry!
> 
> CC: Conor Dooley <conor.dooley@microchip.com>
> CC: Daire McNamara <daire.mcnamara@microchip.com>
> CC: Marc Kleine-Budde <mkl@pengutronix.de>
> CC: Vincent Mailhol <mailhol@kernel.org>
> CC: Rob Herring <robh@kernel.org>
> CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
> CC: linux-riscv@lists.infradead.org
> CC: linux-can@vger.kernel.org
> CC: devicetree@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> ---
>  .../devicetree/bindings/net/can/microchip,mpfs-can.yaml       | 4 ++++
>  1 file changed, 4 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.example.dtb: can@2010c000 (microchip,mpfs-can): 'resets' is a required property
	from schema $id: http://devicetree.org/schemas/net/can/microchip,mpfs-can.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251117-twitter-sternness-f2b3a1506a6f@spud

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [net-next v1] dt-bindings: can: mpfs: document resets

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2206 bytes --]

On Mon, Nov 17, 2025 at 12:27:44PM -0600, Rob Herring (Arm) wrote:
> 
> On Mon, 17 Nov 2025 16:38:18 +0000, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > The CAN cores on Polarfire SoC both have a reset. The platform firmware
> > brings both cores out of reset, but the linux driver must use them
> > during normal operation. The resets should have been made required, but
> > this is one of the things that can happen when the binding is written
> > without driver support.
> > 
> > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > This is the second mistake in this binding, both spotted because of the
> > driver being written (although this one sat downstream for a while for
> > w/e reason). I wish I could say that I'd send the driver soon, but I am
> > busy upstreaming things I wrote and therefore understand at the moment,
> > so a driver that I'd have to go understand and review before sending is
> > low priority, sorry!
> > 
> > CC: Conor Dooley <conor.dooley@microchip.com>
> > CC: Daire McNamara <daire.mcnamara@microchip.com>
> > CC: Marc Kleine-Budde <mkl@pengutronix.de>
> > CC: Vincent Mailhol <mailhol@kernel.org>
> > CC: Rob Herring <robh@kernel.org>
> > CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > CC: linux-riscv@lists.infradead.org
> > CC: linux-can@vger.kernel.org
> > CC: devicetree@vger.kernel.org
> > CC: linux-kernel@vger.kernel.org
> > ---
> >  .../devicetree/bindings/net/can/microchip,mpfs-can.yaml       | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.example.dtb: can@2010c000 (microchip,mpfs-can): 'resets' is a required property
> 	from schema $id: http://devicetree.org/schemas/net/can/microchip,mpfs-can.yaml

Two issues in the same branch now, there's something weird going on with
my test script. /sigh guess that's my evening gone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [net-next v1] dt-bindings: can: mpfs: document resets

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2596 bytes --]

On Mon, Nov 17, 2025 at 06:29:55PM +0000, Conor Dooley wrote:
> On Mon, Nov 17, 2025 at 12:27:44PM -0600, Rob Herring (Arm) wrote:
> > 
> > On Mon, 17 Nov 2025 16:38:18 +0000, Conor Dooley wrote:
> > > From: Conor Dooley <conor.dooley@microchip.com>
> > > 
> > > The CAN cores on Polarfire SoC both have a reset. The platform firmware
> > > brings both cores out of reset, but the linux driver must use them
> > > during normal operation. The resets should have been made required, but
> > > this is one of the things that can happen when the binding is written
> > > without driver support.
> > > 
> > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > > ---
> > > This is the second mistake in this binding, both spotted because of the
> > > driver being written (although this one sat downstream for a while for
> > > w/e reason). I wish I could say that I'd send the driver soon, but I am
> > > busy upstreaming things I wrote and therefore understand at the moment,
> > > so a driver that I'd have to go understand and review before sending is
> > > low priority, sorry!
> > > 
> > > CC: Conor Dooley <conor.dooley@microchip.com>
> > > CC: Daire McNamara <daire.mcnamara@microchip.com>
> > > CC: Marc Kleine-Budde <mkl@pengutronix.de>
> > > CC: Vincent Mailhol <mailhol@kernel.org>
> > > CC: Rob Herring <robh@kernel.org>
> > > CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > > CC: linux-riscv@lists.infradead.org
> > > CC: linux-can@vger.kernel.org
> > > CC: devicetree@vger.kernel.org
> > > CC: linux-kernel@vger.kernel.org
> > > ---
> > >  .../devicetree/bindings/net/can/microchip,mpfs-can.yaml       | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.example.dtb: can@2010c000 (microchip,mpfs-can): 'resets' is a required property
> > 	from schema $id: http://devicetree.org/schemas/net/can/microchip,mpfs-can.yaml
> 
> Two issues in the same branch now, there's something weird going on with
> my test script. /sigh guess that's my evening gone.

I can spend my evening playing poe after all, I am pretty sure this was
caused by running my test script and then immediately switching windows
back and doing a rebase... I'll send a v2 tomorrow or w/e.
pw-bot: changes-requested

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]