Re: [PATCH v3 2/3] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings

Re: [PATCH v3 2/3] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

On Fri, Mar 20, 2026 at 04:09:47PM +0100, David Marinović wrote:
> From: David Marinovic <david.marinovic@pupin.rs>
> 
> Add compatible strings for the LTC2654 quad-channel DAC family.
> 
> The LTC2654 devices are 4-channel, 16-/12-bit DACs with an internal
> reference and SPI interface. They use the same 24-bit SPI command
> format as the LTC2632/2634/2636 family.
> 
> The 16-bit variants (LTC2654-L16 and LTC2654-H16) require new
> compatible strings, as no existing compatibles support 16-bit
> resolution.
> 
> The 12-bit variants (LTC2654-L12 and LTC2654-H12) are register-
> compatible with LTC2634-L12 and LTC2634-H12 respectively, and can
> use them as fallback compatibles.
> 

> Changes added for:
> - lltc,ltc2654-l16: 16-bit, 2.5V internal reference
> - lltc,ltc2654-l12: 12-bit, 2.5V internal reference (fallback to lltc,ltc2634-l12)
> - lltc,ltc2654-h16: 16-bit, 4.096V internal reference
> - lltc,ltc2654-h12: 12-bit, 4.096V internal reference (fallback to lltc,ltc2634-h12)

No idea what this section is doing, could probably cull it if there's
another version.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

btw, please don't send new versions in reply to old ones, can cause you
to get buried in people's mailboxes.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 0/3] iio: dac: ltc2632: add support for LTC2654 DAC family

[Jonathan Cameron]

On Fri, 20 Mar 2026 16:09:45 +0100
David Marinović <david.marinovic@pupin.rs> wrote:

> From: David Marinovic <david.marinovic@pupin.rs>
> 
> Greetings!
> 
> This is v3 of the LTC2654 DAC support patch series.
> 
> The LTC2654 is a quad-channel, 16-/12-bit DAC with internal
> reference voltage and SPI interface, sharing the same 24-bit
> SPI protocol as the LTC2632/2634/2636 family.
> 
> The LTC2654L-16 variant was tested on a Phytec phyCORE-STM32MP1
> board with the DAC connected via SPI1. The driver probes successfully
> and all 4 channels are accessible via IIO sysfs.
> 
Process comment.  Don't send new versions in reply to a previous one.
It leads to them being well back in people's email history (depending
on the client and how it gets sorted) and leads to hard to read threads.

Convention is new version, new email thread.

Thanks,

Jonathan

> Changes in v3:
> - Patch 1 unchanged
> - DT bindings use fallback compatibles for LTC2654-L12 and
>   LTC2654-H12, which are register-compatible with LTC2634-L12
>   and LTC2634-H12
> - LTC2654-L16 and LTC2654-H16 keep separate compatible strings
>   as no existing compatible supports 16-bit resolution
> - 12-bit variants reuse existing LTC2634 chip_info structures,
>   so only two new chip_info structures are added for 16-bit variants
> 
> 
> David Marinovic (3):
>   iio: dac: ltc2632: drop enum and use individual chip_info objects
>   dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings
>   iio: dac: ltc2632: add support for LTC2654 DAC family
> 
>  .../bindings/iio/dac/lltc,ltc2632.yaml        |  12 +-
>  drivers/iio/dac/ltc2632.c                     | 367 +++++++++---------
>  2 files changed, 188 insertions(+), 191 deletions(-)
> 

Re: [PATCH v3 3/3] iio: dac: ltc2632: add support for LTC2654 DAC family

[Jonathan Cameron]

On Fri, 20 Mar 2026 16:09:48 +0100
David Marinović <david.marinovic@pupin.rs> wrote:

> From: David Marinovic <david.marinovic@pupin.rs>
> 
> Add support for the Linear Technology LTC2654 quad DAC family.
> 
> The LTC2654 is a 4-channel, 16-/12-bit DAC with SPI interface,
> sharing the same 24-bit SPI protocol as the existing LTC2632/
> LTC2634/LTC2636 devices supported by this driver.
> 
> The 12-bit variants of LTC2654 reuse existing LTC2634 chip_info
> structs as they are register-compatible.
> 
> Add support for the following variants:
> - LTC2654L-16: 16-bit, 2.5V internal reference
> - LTC2654L-12: 12-bit, 2.5V internal reference
> - LTC2654H-16: 16-bit, 4.096V internal reference
> - LTC2654H-12: 12-bit, 4.096V internal reference
> 
> Signed-off-by: David Marinovic <david.marinovic@pupin.rs>


>  MODULE_DEVICE_TABLE(of, ltc2632_of_match);
> @@ -404,5 +424,5 @@ static struct spi_driver ltc2632_driver = {
>  module_spi_driver(ltc2632_driver);
>  
>  MODULE_AUTHOR("Maxime Roussin-Belanger <maxime.roussinbelanger@gmail.com>");
> -MODULE_DESCRIPTION("LTC2632 DAC SPI driver");
> +MODULE_DESCRIPTION("LTC2632/LTC2654 DAC SPI driver");
I'm going to tweak this to 
		  "LTC2632 and similar DAC SPI driver" because there are already
other parts not listed here.  E.g. LTC2634 parts

>  MODULE_LICENSE("GPL v2");

Re: [PATCH v3 2/3] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings

[Jonathan Cameron]

On Fri, 20 Mar 2026 17:20:28 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Fri, Mar 20, 2026 at 04:09:47PM +0100, David Marinović wrote:
> > From: David Marinovic <david.marinovic@pupin.rs>
> > 
> > Add compatible strings for the LTC2654 quad-channel DAC family.
> > 
> > The LTC2654 devices are 4-channel, 16-/12-bit DACs with an internal
> > reference and SPI interface. They use the same 24-bit SPI command
> > format as the LTC2632/2634/2636 family.
> > 
> > The 16-bit variants (LTC2654-L16 and LTC2654-H16) require new
> > compatible strings, as no existing compatibles support 16-bit
> > resolution.
> > 
> > The 12-bit variants (LTC2654-L12 and LTC2654-H12) are register-
> > compatible with LTC2634-L12 and LTC2634-H12 respectively, and can
> > use them as fallback compatibles.
> >   
> 
> > Changes added for:
> > - lltc,ltc2654-l16: 16-bit, 2.5V internal reference
> > - lltc,ltc2654-l12: 12-bit, 2.5V internal reference (fallback to lltc,ltc2634-l12)
> > - lltc,ltc2654-h16: 16-bit, 4.096V internal reference
> > - lltc,ltc2654-h12: 12-bit, 4.096V internal reference (fallback to lltc,ltc2634-h12)  
> 
> No idea what this section is doing, could probably cull it if there's
> another version.
I dropped that section whilst applying.

> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable
> 
> btw, please don't send new versions in reply to old ones, can cause you
> to get buried in people's mailboxes.
> 
> Cheers,
> Conor.

Re: [PATCH v3 0/3] iio: dac: ltc2632: add support for LTC2654 DAC family

[Jonathan Cameron]

On Fri, 20 Mar 2026 16:09:45 +0100
David Marinović <david.marinovic@pupin.rs> wrote:

> From: David Marinovic <david.marinovic@pupin.rs>
> 
> Greetings!
> 
> This is v3 of the LTC2654 DAC support patch series.
> 
> The LTC2654 is a quad-channel, 16-/12-bit DAC with internal
> reference voltage and SPI interface, sharing the same 24-bit
> SPI protocol as the LTC2632/2634/2636 family.
> 
> The LTC2654L-16 variant was tested on a Phytec phyCORE-STM32MP1
> board with the DAC connected via SPI1. The driver probes successfully
> and all 4 channels are accessible via IIO sysfs.
> 
> Changes in v3:
> - Patch 1 unchanged
> - DT bindings use fallback compatibles for LTC2654-L12 and
>   LTC2654-H12, which are register-compatible with LTC2634-L12
>   and LTC2634-H12
> - LTC2654-L16 and LTC2654-H16 keep separate compatible strings
>   as no existing compatible supports 16-bit resolution
> - 12-bit variants reuse existing LTC2634 chip_info structures,
>   so only two new chip_info structures are added for 16-bit variants
> 
Applied to the testing branch of iio.git (which will become togreg once
the bots let me know if they found any problems).

I made a few minor tweaks as called out in specific patches.

Thanks,

Jonathan

> 
> David Marinovic (3):
>   iio: dac: ltc2632: drop enum and use individual chip_info objects
>   dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings
>   iio: dac: ltc2632: add support for LTC2654 DAC family
> 
>  .../bindings/iio/dac/lltc,ltc2632.yaml        |  12 +-
>  drivers/iio/dac/ltc2632.c                     | 367 +++++++++---------
>  2 files changed, 188 insertions(+), 191 deletions(-)
>