public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 14/14] dt-bindings: thermal: cooling-devices: Update support for 3 cells cooling device
       [not found] <20260419182203.4083985-1-daniel.lezcano@oss.qualcomm.com>
@ 2026-04-19 18:21 ` Daniel Lezcano
  2026-04-22  7:31   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Lezcano @ 2026-04-19 18:21 UTC (permalink / raw)
  To: rafael
  Cc: gaurav.kohli, Zhang Rui, Lukasz Luba, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Lucas Stach, Russell King,
	Christian Gmeiner, David Airlie, Simona Vetter, Guenter Roeck,
	Joel Stanley, Andrew Jeffery, Thomas Weißschuh, Benson Leung,
	Pali Rohár, Avi Fishman, Tomer Maimon, Tali Perry,
	Patrick Venture, Nancy Yuen, Benjamin Fair, Heiko Stuebner,
	Thierry Reding, Jonathan Hunter, Bjorn Andersson, Konrad Dybcio,
	Amit Daniel Kachhap, Viresh Kumar, Neil Armstrong, Amit Kucheria,
	linux-pm, linux-kernel, linux-hwmon, Daniel Lezcano,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

From: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>

Extend the thermal cooling device binding to support a 3 cells specifier
along with tje 2 cells format.

Update #cooling-cells property to enum to support both 2 and 3 arguments.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
 .../bindings/thermal/thermal-cooling-devices.yaml         | 8 ++++++--
 .../devicetree/bindings/thermal/thermal-zones.yaml        | 3 ++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
index b9022f1613d8..28f5818f1e60 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
@@ -44,10 +44,14 @@ select: true
 properties:
   "#cooling-cells":
     description:
-      Must be 2, in order to specify minimum and maximum cooling state used in
+      Must be 2 or 3. If 2, specifies minimum and maximum cooling state used in
       the cooling-maps reference. The first cell is the minimum cooling state
       and the second cell is the maximum cooling state requested.
-    const: 2
+      If 3, the first cell specifies the thermal mitigation device specifier
+      index for devices that support multiple thermal mitigation mechanisms.
+      The two other cells are respectively the minimum cooling state and the
+      maximum cooling state.
+    enum: [2, 3]
 
 additionalProperties: true
 
diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
index 0de0a9757ccc..1261ba0e802e 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
@@ -214,7 +214,8 @@ patternProperties:
                   device. Using the THERMAL_NO_LIMIT (-1UL) constant in the
                   cooling-device phandle limit specifier lets the framework
                   use the minimum and maximum cooling state for that cooling
-                  device automatically.
+                  device automatically. If three arguments are specified,
+                  the first argument is the cooling device specifier.
 
               contribution:
                 $ref: /schemas/types.yaml#/definitions/uint32
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 14/14] dt-bindings: thermal: cooling-devices: Update support for 3 cells cooling device
  2026-04-19 18:21 ` [PATCH v1 14/14] dt-bindings: thermal: cooling-devices: Update support for 3 cells cooling device Daniel Lezcano
@ 2026-04-22  7:31   ` Krzysztof Kozlowski
  2026-04-22 16:01     ` Daniel Lezcano
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-22  7:31 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: rafael, gaurav.kohli, Zhang Rui, Lukasz Luba, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Lucas Stach, Russell King,
	Christian Gmeiner, David Airlie, Simona Vetter, Guenter Roeck,
	Joel Stanley, Andrew Jeffery, Thomas Weißschuh, Benson Leung,
	Pali Rohár, Avi Fishman, Tomer Maimon, Tali Perry,
	Patrick Venture, Nancy Yuen, Benjamin Fair, Heiko Stuebner,
	Thierry Reding, Jonathan Hunter, Bjorn Andersson, Konrad Dybcio,
	Amit Daniel Kachhap, Viresh Kumar, Neil Armstrong, Amit Kucheria,
	linux-pm, linux-kernel, linux-hwmon, Daniel Lezcano,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On Sun, Apr 19, 2026 at 08:21:58PM +0200, Daniel Lezcano wrote:
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> index b9022f1613d8..28f5818f1e60 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> @@ -44,10 +44,14 @@ select: true
>  properties:
>    "#cooling-cells":
>      description:
> -      Must be 2, in order to specify minimum and maximum cooling state used in
> +      Must be 2 or 3. If 2, specifies minimum and maximum cooling state used in
>        the cooling-maps reference. The first cell is the minimum cooling state
>        and the second cell is the maximum cooling state requested.
> -    const: 2
> +      If 3, the first cell specifies the thermal mitigation device specifier
> +      index for devices that support multiple thermal mitigation mechanisms.
> +      The two other cells are respectively the minimum cooling state and the
> +      maximum cooling state.
> +    enum: [2, 3]

In the same commit you need to narrow
Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
so it will keep value of '2' (const: 2, like all other bindings).

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 14/14] dt-bindings: thermal: cooling-devices: Update support for 3 cells cooling device
  2026-04-22  7:31   ` Krzysztof Kozlowski
@ 2026-04-22 16:01     ` Daniel Lezcano
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2026-04-22 16:01 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: rafael, gaurav.kohli, Zhang Rui, Lukasz Luba, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Lucas Stach, Russell King,
	Christian Gmeiner, David Airlie, Simona Vetter, Guenter Roeck,
	Joel Stanley, Andrew Jeffery, Thomas Weißschuh, Benson Leung,
	Pali Rohár, Avi Fishman, Tomer Maimon, Tali Perry,
	Patrick Venture, Nancy Yuen, Benjamin Fair, Heiko Stuebner,
	Thierry Reding, Jonathan Hunter, Bjorn Andersson, Konrad Dybcio,
	Amit Daniel Kachhap, Viresh Kumar, Neil Armstrong, Amit Kucheria,
	linux-pm, linux-kernel, linux-hwmon, Daniel Lezcano,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On 4/22/26 09:31, Krzysztof Kozlowski wrote:
> On Sun, Apr 19, 2026 at 08:21:58PM +0200, Daniel Lezcano wrote:
>> diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
>> index b9022f1613d8..28f5818f1e60 100644
>> --- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
>> @@ -44,10 +44,14 @@ select: true
>>   properties:
>>     "#cooling-cells":
>>       description:
>> -      Must be 2, in order to specify minimum and maximum cooling state used in
>> +      Must be 2 or 3. If 2, specifies minimum and maximum cooling state used in
>>         the cooling-maps reference. The first cell is the minimum cooling state
>>         and the second cell is the maximum cooling state requested.
>> -    const: 2
>> +      If 3, the first cell specifies the thermal mitigation device specifier
>> +      index for devices that support multiple thermal mitigation mechanisms.
>> +      The two other cells are respectively the minimum cooling state and the
>> +      maximum cooling state.
>> +    enum: [2, 3]
> 
> In the same commit you need to narrow
> Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> so it will keep value of '2' (const: 2, like all other bindings).

Ah yes, thanks !

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-22 16:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260419182203.4083985-1-daniel.lezcano@oss.qualcomm.com>
2026-04-19 18:21 ` [PATCH v1 14/14] dt-bindings: thermal: cooling-devices: Update support for 3 cells cooling device Daniel Lezcano
2026-04-22  7:31   ` Krzysztof Kozlowski
2026-04-22 16:01     ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox