From: Conor Dooley <conor@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <pjw@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
Subject: Re: [PATCH v1 20/20] riscv: dts: starfive: jhb100: Add pinctrl nodes
Date: Fri, 24 Apr 2026 18:01:52 +0100 [thread overview]
Message-ID: <20260424-bok-storm-4f4583686777@spud> (raw)
In-Reply-To: <20260424111330.702272-21-changhuang.liang@starfivetech.com>
[-- Attachment #1: Type: text/plain, Size: 8658 bytes --]
On Fri, Apr 24, 2026 at 04:13:30AM -0700, Changhuang Liang wrote:
> Add pinctrl nodes for starfive JHB100 SoC. They contain
> pinctrl_per0/pinctrl_per1/pinctrl_per2/pinctrl_per2pok/pinctrl_per3/
> pinctrl_sys0/pinctrl_sys0h/pinctrl_sys1/pinctrl_sys2.
>
> Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
What did Lianfeng do? A signoff alone suggests something is incorrectly
attributed here.
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> .../boot/dts/starfive/jhb100-evb1-eth.dts | 27 +++++
> arch/riscv/boot/dts/starfive/jhb100-evb1.dtsi | 4 +
> .../boot/dts/starfive/jhb100-pinctrl.dtsi | 19 ++++
> arch/riscv/boot/dts/starfive/jhb100.dtsi | 107 ++++++++++++++++++
> 4 files changed, 157 insertions(+)
> create mode 100644 arch/riscv/boot/dts/starfive/jhb100-pinctrl.dtsi
>
> diff --git a/arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts b/arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts
> index 62cd046e1224..f7e82f9d0ff1 100644
> --- a/arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts
> +++ b/arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts
> @@ -4,3 +4,30 @@
> */
>
> #include "jhb100-evb1.dtsi"
> +
> +&pinctrl_per0 {
> + gpioe-i3c0-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOB8-11, 32-33 */
> + gpioe-i3c1-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOB12-15, 34-35 */
> + gpioe-i3c2-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOB16-23 */
> + gpioe-i3c4-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOB36-43 */
> +};
> +
> +&pinctrl_per1 {
> + gpioe-spi-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOC0-4 */
> + gpioe-qspi0-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOC5-11 */
> + gpioe-qspi1-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOC12-19 */
> + gpioe-qspi2-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOC20-27 */
> +};
> +
> +&pinctrl_per2 {
> + gpionw-vref = <JHB100_PINVREF_1_8V>; /* VREF for GPIOD19-30 */
> +};
> +
> +&pinctrl_per3 {
> + gpios-vref = <JHB100_PINVREF_1_8V>; /* VREF for GPIOE0-10 */
> +};
> +
> +&pinctrl_sys2 {
> + gpiow-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOA36-39 */
> + gpiow-inner-vref = <JHB100_PINVREF_3_3V>; /* VREF for GPIOA40-43 */
> +};
> diff --git a/arch/riscv/boot/dts/starfive/jhb100-evb1.dtsi b/arch/riscv/boot/dts/starfive/jhb100-evb1.dtsi
> index 462b6fb7953b..acd5949bcfdb 100644
> --- a/arch/riscv/boot/dts/starfive/jhb100-evb1.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jhb100-evb1.dtsi
> @@ -3,7 +3,9 @@
> * Copyright (c) 2024-2026 StarFive Technology Co., Ltd.
> */
>
> +#include "jhb100-pinfunc.h"
> #include "jhb100.dtsi"
> +#include "jhb100-pinctrl.dtsi"
>
> / {
> model = "StarFive JHB100 EVB-1";
> @@ -29,4 +31,6 @@ memory@40000000 {
>
> &uart6 {
> status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart6_pins>;
> };
> diff --git a/arch/riscv/boot/dts/starfive/jhb100-pinctrl.dtsi b/arch/riscv/boot/dts/starfive/jhb100-pinctrl.dtsi
> new file mode 100644
> index 000000000000..d12b79376521
> --- /dev/null
> +++ b/arch/riscv/boot/dts/starfive/jhb100-pinctrl.dtsi
> @@ -0,0 +1,19 @@
> +// SPDX-License-Identifier: GPL-2.0 OR MIT
> +/*
> + * Copyright (c) 2025-2026 StarFive Technology Co., Ltd.
> + */
> +
> +&pinctrl_sys2 {
> + uart6_pins: uart6-grp {
> + uart6-tx-pins {
> + pinmux = <PINMUX(PADNUM_SYS2_GPIO_A38,
> + FUNC_SYS2_UART6_TX)>;
> + };
> +
> + uart6-rx-pins {
> + pinmux = <PINMUX(PADNUM_SYS2_GPIO_A39,
> + FUNC_SYS2_UART6_RX)>;
> + input-enable;
> + };
> + };
> +};
Could we get some more examples, to exercise each pin controller?
Is that impossible without adding more peripherals other than uart?
Cheers,
Conor.
> diff --git a/arch/riscv/boot/dts/starfive/jhb100.dtsi b/arch/riscv/boot/dts/starfive/jhb100.dtsi
> index 700d00f800bc..74d427d7f2df 100644
> --- a/arch/riscv/boot/dts/starfive/jhb100.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jhb100.dtsi
> @@ -425,6 +425,18 @@ per0crg: clock-controller@11a08000 {
> #reset-cells = <1>;
> };
>
> + pinctrl_per0: pinctrl@11a0a000 {
> + compatible = "starfive,jhb100-per0-pinctrl";
> + reg = <0x0 0x11a0a000 0x0 0x1000>;
> + resets = <&per0crg JHB100_PER0RST_GPIO_IOMUX_PRESETN>;
> + interrupts = <60>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_per0 0 0 60>;
> + };
> +
> per1crg: clock-controller@11b40000 {
> compatible = "starfive,jhb100-per1crg";
> reg = <0x0 0x11b40000 0x0 0x1000>;
> @@ -440,6 +452,18 @@ per1crg: clock-controller@11b40000 {
> #reset-cells = <1>;
> };
>
> + pinctrl_per1: pinctrl@11b42000 {
> + compatible = "starfive,jhb100-per1-pinctrl";
> + reg = <0x0 0x11b42000 0x0 0x800>;
> + resets = <&per1crg JHB100_PER1RST_IOMUX_PRESETN>;
> + interrupts = <61>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_per1 0 0 36>;
> + };
> +
> per2crg: clock-controller@11bc0000 {
> compatible = "starfive,jhb100-per2crg";
> reg = <0x0 0x11bc0000 0x0 0x1000>;
> @@ -461,6 +485,30 @@ per2crg: clock-controller@11bc0000 {
> #reset-cells = <1>;
> };
>
> + pinctrl_per2: pinctrl@11bc2000 {
> + compatible = "starfive,jhb100-per2-pinctrl";
> + reg = <0x0 0x11bc2000 0x0 0x400>;
> + resets = <&per2crg JHB100_PER2RST_IOMUX_PRESETN>;
> + interrupts = <62>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_per2 0 0 31>;
> + };
> +
> + pinctrl_per2pok: pinctrl@11bc2400 {
> + compatible = "starfive,jhb100-per2pok-pinctrl";
> + reg = <0x0 0x11bc2400 0x0 0x400>;
> + resets = <&per2crg JHB100_PER2RST_POK_IOMUX_PRESETN>;
> + interrupts = <63>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_per2pok 0 0 18>;
> + };
> +
> per3crg: clock-controller@11c40000 {
> compatible = "starfive,jhb100-per3crg";
> reg = <0x0 0x11c40000 0x0 0x1000>;
> @@ -480,6 +528,18 @@ per3crg: clock-controller@11c40000 {
> #reset-cells = <1>;
> };
>
> + pinctrl_per3: pinctrl@11c42000 {
> + compatible = "starfive,jhb100-per3-pinctrl";
> + reg = <0x0 0x11c42000 0x0 0x1000>;
> + resets = <&per3crg JHB100_PER3RST_IOMUX_PRESETN>;
> + interrupts = <64>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_per3 0 0 11>;
> + };
> +
> sys0crg: clock-controller@13000000 {
> compatible = "starfive,jhb100-sys0crg";
> reg = <0x0 0x13000000 0x0 0x4000>;
> @@ -513,6 +573,53 @@ sys2crg: clock-controller@13008000 {
> #clock-cells = <1>;
> #reset-cells = <1>;
> };
> +
> + pinctrl_sys0: pinctrl@13080000 {
> + compatible = "starfive,jhb100-sys0-pinctrl";
> + reg = <0x0 0x13080000 0x0 0x800>;
> + resets = <&sys0crg JHB100_SYS0RST_SYS0_IOMUX_PRESETN>;
> + interrupts = <56>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_sys0 0 0 4>;
> + };
> +
> + pinctrl_sys0h: pinctrl@13080800 {
> + compatible = "starfive,jhb100-sys0h-pinctrl";
> + reg = <0x0 0x13080800 0x0 0x800>;
> + resets = <&sys0crg JHB100_SYS0RST_SYS0H_IOMUX_PRESETN>;
> + interrupts = <57>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_sys0h 0 0 12>;
> + };
> +
> + pinctrl_sys1: pinctrl@13081000 {
> + compatible = "starfive,jhb100-sys1-pinctrl";
> + reg = <0x0 0x13081000 0x0 0x1000>;
> + resets = <&sys1crg JHB100_SYS1RST_SYS1_IOMUX_PRESETN>;
> + interrupts = <58>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_sys1 0 0 8>;
> + };
> +
> + pinctrl_sys2: pinctrl@13082000 {
> + compatible = "starfive,jhb100-sys2-pinctrl";
> + reg = <0x0 0x13082000 0x0 0x1000>;
> + interrupts = <59>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl_sys2 0 0 37>;
> + };
> };
> };
> };
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-04-24 17:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 11:13 [PATCH v1 00/20] Add basic pinctrl drivers for JHB100 SoC Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 01/20] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl Changhuang Liang
2026-04-28 10:34 ` Linus Walleij
2026-04-24 11:13 ` [PATCH v1 02/20] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver Changhuang Liang
2026-04-28 10:29 ` Linus Walleij
2026-04-24 11:13 ` [PATCH v1 03/20] dt-bindings: pinctrl: Add starfive,jhb100-sys0h-pinctrl Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 04/20] pinctrl: starfive: Add StarFive JHB100 sys0h controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 05/20] dt-bindings: pinctrl: Add starfive,jhb100-sys1-pinctrl Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 06/20] pinctrl: starfive: Add StarFive JHB100 sys1 controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 07/20] dt-bindings: pinctrl: Add starfive,jhb100-sys2-pinctrl Changhuang Liang
2026-04-25 10:28 ` Krzysztof Kozlowski
2026-04-24 11:13 ` [PATCH v1 08/20] pinctrl: starfive: Add StarFive JHB100 sys2 controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 09/20] dt-bindings: pinctrl: Add starfive,jhb100-per0-pinctrl Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 10/20] pinctrl: starfive: Add StarFive JHB100 per0 controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 11/20] dt-bindings: pinctrl: Add starfive,jhb100-per1-pinctrl Changhuang Liang
2026-04-24 16:56 ` Conor Dooley
2026-04-28 1:28 ` Changhuang Liang
2026-04-28 18:51 ` Conor Dooley
2026-04-28 11:08 ` Linus Walleij
2026-04-24 11:13 ` [PATCH v1 12/20] pinctrl: starfive: Add StarFive JHB100 per1 controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 13/20] dt-bindings: pinctrl: Add starfive,jhb100-per2-pinctrl Changhuang Liang
2026-04-24 13:17 ` Rob Herring (Arm)
2026-04-24 11:13 ` [PATCH v1 14/20] pinctrl: starfive: Add StarFive JHB100 per2 controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 15/20] dt-bindings: pinctrl: Add starfive,jhb100-per2pok-pinctrl Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 16/20] pinctrl: starfive: Add StarFive JHB100 per2pok controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 17/20] dt-bindings: pinctrl: Add starfive,jhb100-per3-pinctrl Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 18/20] pinctrl: starfive: Add StarFive JHB100 per3 controller driver Changhuang Liang
2026-04-24 11:13 ` [PATCH v1 19/20] riscv: dts: starfive: Add StarFive JHB100 pin function definitions Changhuang Liang
2026-04-24 17:00 ` Conor Dooley
2026-04-24 11:13 ` [PATCH v1 20/20] riscv: dts: starfive: jhb100: Add pinctrl nodes Changhuang Liang
2026-04-24 17:01 ` Conor Dooley [this message]
2026-04-28 1:53 ` Changhuang Liang
2026-04-28 10:11 ` [PATCH v1 00/20] Add basic pinctrl drivers for JHB100 SoC Linus Walleij
2026-04-29 0:53 ` Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424-bok-storm-4f4583686777@spud \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=brgl@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=lianfeng.ouyang@starfivetech.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox