Re: [PATCH v3 5/7] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing required properties for interrupt controller capabilities.
- [Low] Mismatch between the commit message description of register blocks and the `reg` property constraint.
--

commit e48cb449a1787cbc350f702042fd90d1f1e83047
Author: Tzuyi Chang <tychang@realtek.com>

dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio

This commit introduces device tree bindings for the Realtek DHC RTD1625 GPIO
controllers. It notes a per-pin register architecture and includes properties
for configuring pins and handling interrupts.

> Add the device tree bindings for the Realtek DHC (Digital Home Center)
> RTD1625 GPIO controllers.
> 
> The RTD1625 GPIO controller features a per-pin register architecture
> that differs significantly from previous generations. It utilizes
> separate register blocks for GPIO configuration and interrupt control.

The commit message states the controller utilizes separate register blocks
for GPIO configuration and interrupt control. However, the schema constrains
the reg property to maxItems: 1 and the example uses a single contiguous
block. 

If these are truly separate memory regions, should the reg property be
updated to define multiple items? If they are internal register groups
within the same memory-mapped region, could the commit message be clarified
to reflect this?

> diff --git a/Documentation/devicetree/bindings/gpio/realtek,rtd1625-gpio.yaml b/Documentation/devicetree/bindings/gpio/realtek,rtd1625-gpio.yaml
> new file mode 100644
> index 0000000000000..f13c910b73c69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/realtek,rtd1625-gpio.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - gpio-ranges
> +  - gpio-controller
> +  - "#gpio-cells"
> +
> +additionalProperties: false

The binding defines interrupt-controller and #interrupt-cells properties
earlier in the file, and the example demonstrates their use.

Do these properties need to be included in this required list? Since the
hardware acts as an interrupt controller provider, adding them to the
required list would prevent incomplete device tree nodes from silently
passing schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512033317.1602537-1-eleanor.lin@realtek.com?part=5