Re: [PATCH v3 7/7] arm64: dts: realtek: Add GPIO support for RTD1625

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Both the `gpio@31000` and `iso_m_gpio@89100` nodes omit essential interrupt properties (`interrupts`, `interrupt-controller`, and `#interrupt-cells`).
--

commit d2b46f0c89e5920bcae5cf858be075ac05b6c104
Author: Yu-Chun Lin <eleanor.lin@realtek.com>

arm64: dts: realtek: Add GPIO support for RTD1625

Add the GPIO node for the Realtek RTD1625 SoC.

> diff --git a/arch/arm64/boot/dts/realtek/kent.dtsi b/arch/arm64/boot/dts/realtek/kent.dtsi
> index 8d4293cd4c036..228b82dfdb7ac 100644
> --- a/arch/arm64/boot/dts/realtek/kent.dtsi
> +++ b/arch/arm64/boot/dts/realtek/kent.dtsi
> @@ -151,6 +151,37 @@ uart0: serial@7800 {
>  				status = "disabled";
>  			};
>  
> +			gpio: gpio@31000 {
> +				compatible = "realtek,rtd1625-iso-gpio";
> +				reg = <0x31000 0x398>;
> +				gpio-controller;

Should this node include interrupt properties such as "interrupts",
"interrupt-controller", and "#interrupt-cells"?

In drivers/gpio/gpio-rtd1625.c, rtd1625_gpio_probe() unconditionally registers
an irq_domain. Since the "interrupts" property is absent from the device tree,
platform_get_irq_optional() will return -ENXIO and skip registering the
chained parent IRQ handler, but leave the irq_domain active.

If a consumer driver requests an interrupt for one of these GPIOs, the request
will succeed and return a valid software IRQ mapping from the domain. However,
because the parent IRQ was never hooked up, the hardware will never deliver
the interrupt to the CPU, leading to silent failures for peripherals relying
on GPIO interrupts.

[ ... ]
> +			iso_m_gpio: gpio@89100 {
> +				compatible = "realtek,rtd1625-isom-gpio";
> +				reg = <0x89100 0x30>;
> +				gpio-controller;

Are the interrupt properties also missing here for the same reason?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512033317.1602537-1-eleanor.lin@realtek.com?part=7