* [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support
@ 2026-05-14 12:48 Prathamesh Shete
2026-05-14 12:48 ` [PATCH 2/2] gpio: tegra186: Add support for Tegra238 Prathamesh Shete
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Prathamesh Shete @ 2026-05-14 12:48 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Thierry Reding, Jonathan Hunter, Prathamesh Shete, linux-gpio,
devicetree, linux-tegra, linux-kernel
Extend the existing Tegra186 GPIO controller device tree bindings with
support for the GPIO controllers found on Tegra238. Tegra238 has two
GPIO controllers: the main controller and always-on (AON) controller.
The number of pins is slightly different, but the programming model
remains the same.
Add a new header, include/dt-bindings/gpio/nvidia,tegra238-gpio.h,
that defines port IDs as well as the TEGRA238_MAIN_GPIO() helper,
both of which are used in conjunction to create a unique specifier
for each pin.
Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
---
.../bindings/gpio/nvidia,tegra186-gpio.yaml | 6 ++
.../dt-bindings/gpio/nvidia,tegra238-gpio.h | 58 +++++++++++++++++++
2 files changed, 64 insertions(+)
create mode 100644 include/dt-bindings/gpio/nvidia,tegra238-gpio.h
diff --git a/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml b/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml
index 17748dd1015d..adeb3b3a2902 100644
--- a/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml
@@ -85,6 +85,8 @@ properties:
- nvidia,tegra194-gpio-aon
- nvidia,tegra234-gpio
- nvidia,tegra234-gpio-aon
+ - nvidia,tegra238-gpio
+ - nvidia,tegra238-gpio-aon
- nvidia,tegra256-gpio
- nvidia,tegra264-gpio
- nvidia,tegra264-gpio-uphy
@@ -163,6 +165,7 @@ allOf:
- nvidia,tegra186-gpio
- nvidia,tegra194-gpio
- nvidia,tegra234-gpio
+ - nvidia,tegra238-gpio
- nvidia,tegra256-gpio
- nvidia,tegra264-gpio
- nvidia,tegra264-gpio-uphy
@@ -180,6 +183,7 @@ allOf:
- nvidia,tegra186-gpio-aon
- nvidia,tegra194-gpio-aon
- nvidia,tegra234-gpio-aon
+ - nvidia,tegra238-gpio-aon
- nvidia,tegra264-gpio-aon
then:
properties:
@@ -192,6 +196,8 @@ allOf:
compatible:
contains:
enum:
+ - nvidia,tegra238-gpio
+ - nvidia,tegra238-gpio-aon
- nvidia,tegra264-gpio
- nvidia,tegra264-gpio-uphy
- nvidia,tegra264-gpio-aon
diff --git a/include/dt-bindings/gpio/nvidia,tegra238-gpio.h b/include/dt-bindings/gpio/nvidia,tegra238-gpio.h
new file mode 100644
index 000000000000..8a616a1df54c
--- /dev/null
+++ b/include/dt-bindings/gpio/nvidia,tegra238-gpio.h
@@ -0,0 +1,58 @@
+/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
+/* Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved. */
+
+/*
+ * This header provides constants for binding nvidia,tegra238-gpio*.
+ *
+ * The first cell in Tegra's GPIO specifier is the GPIO ID. The macros below
+ * provide names for this.
+ *
+ * The second cell contains standard flag values specified in gpio.h.
+ */
+
+#ifndef _DT_BINDINGS_GPIO_TEGRA238_GPIO_H
+#define _DT_BINDINGS_GPIO_TEGRA238_GPIO_H
+
+#include <dt-bindings/gpio/gpio.h>
+
+/* GPIOs implemented by main GPIO controller */
+#define TEGRA238_MAIN_GPIO_PORT_A 0
+#define TEGRA238_MAIN_GPIO_PORT_B 1
+#define TEGRA238_MAIN_GPIO_PORT_C 2
+#define TEGRA238_MAIN_GPIO_PORT_D 3
+#define TEGRA238_MAIN_GPIO_PORT_E 4
+#define TEGRA238_MAIN_GPIO_PORT_F 5
+#define TEGRA238_MAIN_GPIO_PORT_G 6
+#define TEGRA238_MAIN_GPIO_PORT_H 7
+#define TEGRA238_MAIN_GPIO_PORT_J 8
+#define TEGRA238_MAIN_GPIO_PORT_K 9
+#define TEGRA238_MAIN_GPIO_PORT_L 10
+#define TEGRA238_MAIN_GPIO_PORT_M 11
+#define TEGRA238_MAIN_GPIO_PORT_N 12
+#define TEGRA238_MAIN_GPIO_PORT_P 13
+#define TEGRA238_MAIN_GPIO_PORT_Q 14
+#define TEGRA238_MAIN_GPIO_PORT_R 15
+#define TEGRA238_MAIN_GPIO_PORT_S 16
+#define TEGRA238_MAIN_GPIO_PORT_T 17
+#define TEGRA238_MAIN_GPIO_PORT_U 18
+#define TEGRA238_MAIN_GPIO_PORT_V 19
+#define TEGRA238_MAIN_GPIO_PORT_W 20
+#define TEGRA238_MAIN_GPIO_PORT_X 21
+
+#define TEGRA238_MAIN_GPIO(port, offset) \
+ ((TEGRA238_MAIN_GPIO_PORT_##port * 8) + (offset))
+
+/* GPIOs implemented by AON GPIO controller */
+#define TEGRA238_AON_GPIO_PORT_AA 0
+#define TEGRA238_AON_GPIO_PORT_BB 1
+#define TEGRA238_AON_GPIO_PORT_CC 2
+#define TEGRA238_AON_GPIO_PORT_DD 3
+#define TEGRA238_AON_GPIO_PORT_EE 4
+#define TEGRA238_AON_GPIO_PORT_FF 5
+#define TEGRA238_AON_GPIO_PORT_GG 6
+#define TEGRA238_AON_GPIO_PORT_HH 7
+
+#define TEGRA238_AON_GPIO(port, offset) \
+ ((TEGRA238_AON_GPIO_PORT_##port * 8) + (offset))
+
+#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] gpio: tegra186: Add support for Tegra238 2026-05-14 12:48 [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support Prathamesh Shete @ 2026-05-14 12:48 ` Prathamesh Shete 2026-05-14 18:11 ` [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support Conor Dooley 2026-05-18 9:12 ` Bartosz Golaszewski 2 siblings, 0 replies; 4+ messages in thread From: Prathamesh Shete @ 2026-05-14 12:48 UTC (permalink / raw) To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Thierry Reding, Jonathan Hunter, Prathamesh Shete, linux-gpio, devicetree, linux-tegra, linux-kernel Extend the existing Tegra186 GPIO controller driver with support for the GPIO controller found on Tegra238. Signed-off-by: Prathamesh Shete <pshete@nvidia.com> --- drivers/gpio/gpio-tegra186.c | 68 ++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c index aa7c3e44234f..f56617c298c0 100644 --- a/drivers/gpio/gpio-tegra186.c +++ b/drivers/gpio/gpio-tegra186.c @@ -19,6 +19,7 @@ #include <dt-bindings/gpio/tegra186-gpio.h> #include <dt-bindings/gpio/tegra194-gpio.h> #include <dt-bindings/gpio/tegra234-gpio.h> +#include <dt-bindings/gpio/nvidia,tegra238-gpio.h> #include <dt-bindings/gpio/tegra241-gpio.h> #include <dt-bindings/gpio/tegra256-gpio.h> #include <dt-bindings/gpio/nvidia,tegra264-gpio.h> @@ -1239,6 +1240,67 @@ static const struct tegra_gpio_soc tegra234_aon_soc = { .has_vm_support = false, }; +#define TEGRA238_MAIN_GPIO_PORT(_name, _bank, _port, _pins) \ + TEGRA_GPIO_PORT(TEGRA238_MAIN, _name, _bank, _port, _pins) + +static const struct tegra_gpio_port tegra238_main_ports[] = { + TEGRA238_MAIN_GPIO_PORT(A, 0, 0, 8), + TEGRA238_MAIN_GPIO_PORT(B, 0, 1, 5), + TEGRA238_MAIN_GPIO_PORT(C, 0, 2, 8), + TEGRA238_MAIN_GPIO_PORT(D, 0, 3, 8), + TEGRA238_MAIN_GPIO_PORT(E, 0, 4, 4), + TEGRA238_MAIN_GPIO_PORT(F, 0, 5, 8), + TEGRA238_MAIN_GPIO_PORT(G, 0, 6, 8), + TEGRA238_MAIN_GPIO_PORT(H, 0, 7, 6), + TEGRA238_MAIN_GPIO_PORT(J, 1, 0, 8), + TEGRA238_MAIN_GPIO_PORT(K, 1, 1, 4), + TEGRA238_MAIN_GPIO_PORT(L, 1, 2, 8), + TEGRA238_MAIN_GPIO_PORT(M, 1, 3, 8), + TEGRA238_MAIN_GPIO_PORT(N, 1, 4, 3), + TEGRA238_MAIN_GPIO_PORT(P, 1, 5, 8), + TEGRA238_MAIN_GPIO_PORT(Q, 1, 6, 3), + TEGRA238_MAIN_GPIO_PORT(R, 2, 0, 8), + TEGRA238_MAIN_GPIO_PORT(S, 2, 1, 8), + TEGRA238_MAIN_GPIO_PORT(T, 2, 2, 8), + TEGRA238_MAIN_GPIO_PORT(U, 2, 3, 6), + TEGRA238_MAIN_GPIO_PORT(V, 2, 4, 2), + TEGRA238_MAIN_GPIO_PORT(W, 3, 0, 8), + TEGRA238_MAIN_GPIO_PORT(X, 3, 1, 2) +}; + +static const struct tegra_gpio_soc tegra238_main_soc = { + .num_ports = ARRAY_SIZE(tegra238_main_ports), + .ports = tegra238_main_ports, + .name = "tegra238-gpio", + .instance = 0, + .num_irqs_per_bank = 8, + .has_vm_support = true, +}; + +#define TEGRA238_AON_GPIO_PORT(_name, _bank, _port, _pins) \ + TEGRA_GPIO_PORT(TEGRA238_AON, _name, _bank, _port, _pins) + +static const struct tegra_gpio_port tegra238_aon_ports[] = { + TEGRA238_AON_GPIO_PORT(AA, 0, 0, 8), + TEGRA238_AON_GPIO_PORT(BB, 0, 1, 1), + TEGRA238_AON_GPIO_PORT(CC, 0, 2, 8), + TEGRA238_AON_GPIO_PORT(DD, 0, 3, 8), + TEGRA238_AON_GPIO_PORT(EE, 0, 4, 6), + TEGRA238_AON_GPIO_PORT(FF, 0, 5, 8), + TEGRA238_AON_GPIO_PORT(GG, 0, 6, 8), + TEGRA238_AON_GPIO_PORT(HH, 0, 7, 4) +}; + +static const struct tegra_gpio_soc tegra238_aon_soc = { + .num_ports = ARRAY_SIZE(tegra238_aon_ports), + .ports = tegra238_aon_ports, + .name = "tegra238-gpio-aon", + .instance = 1, + .num_irqs_per_bank = 8, + .has_gte = true, + .has_vm_support = false, +}; + #define TEGRA241_MAIN_GPIO_PORT(_name, _bank, _port, _pins) \ TEGRA_GPIO_PORT(TEGRA241_MAIN, _name, _bank, _port, _pins) @@ -1447,6 +1509,12 @@ static const struct of_device_id tegra186_gpio_of_match[] = { }, { .compatible = "nvidia,tegra234-gpio-aon", .data = &tegra234_aon_soc + }, { + .compatible = "nvidia,tegra238-gpio", + .data = &tegra238_main_soc + }, { + .compatible = "nvidia,tegra238-gpio-aon", + .data = &tegra238_aon_soc }, { .compatible = "nvidia,tegra256-gpio", .data = &tegra256_main_soc -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support 2026-05-14 12:48 [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support Prathamesh Shete 2026-05-14 12:48 ` [PATCH 2/2] gpio: tegra186: Add support for Tegra238 Prathamesh Shete @ 2026-05-14 18:11 ` Conor Dooley 2026-05-18 9:12 ` Bartosz Golaszewski 2 siblings, 0 replies; 4+ messages in thread From: Conor Dooley @ 2026-05-14 18:11 UTC (permalink / raw) To: Prathamesh Shete Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Jonathan Hunter, linux-gpio, devicetree, linux-tegra, linux-kernel [-- Attachment #1: Type: text/plain, Size: 75 bytes --] Acked-by: Conor Dooley <conor.dooley@microchip.com> pw-bot: not-applicable [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support 2026-05-14 12:48 [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support Prathamesh Shete 2026-05-14 12:48 ` [PATCH 2/2] gpio: tegra186: Add support for Tegra238 Prathamesh Shete 2026-05-14 18:11 ` [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support Conor Dooley @ 2026-05-18 9:12 ` Bartosz Golaszewski 2 siblings, 0 replies; 4+ messages in thread From: Bartosz Golaszewski @ 2026-05-18 9:12 UTC (permalink / raw) To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Prathamesh Shete Cc: Bartosz Golaszewski, Thierry Reding, Jonathan Hunter, linux-gpio, devicetree, linux-tegra, linux-kernel On Thu, 14 May 2026 12:48:34 +0000, Prathamesh Shete wrote: > Extend the existing Tegra186 GPIO controller device tree bindings with > support for the GPIO controllers found on Tegra238. Tegra238 has two > GPIO controllers: the main controller and always-on (AON) controller. > The number of pins is slightly different, but the programming model > remains the same. > > Add a new header, include/dt-bindings/gpio/nvidia,tegra238-gpio.h, > that defines port IDs as well as the TEGRA238_MAIN_GPIO() helper, > both of which are used in conjunction to create a unique specifier > for each pin. > > [...] Applied, thanks! [1/2] dt-bindings: gpio: Add Tegra238 support https://git.kernel.org/brgl/c/4002ccd266b665f1097e20addbe8f3baeb2136f9 [2/2] gpio: tegra186: Add support for Tegra238 https://git.kernel.org/brgl/c/8ac12d8b7099cdebff19aed78a81f61d8042c6be Best regards, -- Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-18 9:12 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-14 12:48 [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support Prathamesh Shete 2026-05-14 12:48 ` [PATCH 2/2] gpio: tegra186: Add support for Tegra238 Prathamesh Shete 2026-05-14 18:11 ` [PATCH 1/2] dt-bindings: gpio: Add Tegra238 support Conor Dooley 2026-05-18 9:12 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox