Re: [PATCH v4 1/3] arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Redundant `interrupt-parent` property alongside `interrupts-extended` in the `aoss_qmp` node.
--

commit 83bbc0567b448712af4a939b7fec5336a2e27452
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes

This commit adds the ADSP remoteproc node, USB controller, and their
dependencies such as the IPCC mailbox, QMP combo PHY, and SNPS eUSB2 PHY to
the Eliza SoC device tree.

> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi

[ ... ]

> +		aoss_qmp: power-management@c300000 {
> +			compatible = "qcom,eliza-aoss-qmp", "qcom,aoss-qmp";
> +			reg = <0x0 0x0c300000 0x0 0x400>;
> +
> +			interrupt-parent = <&ipcc>;
> +			interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP
> +						     IRQ_TYPE_EDGE_RISING>;

Is the interrupt-parent property necessary here?

Since interrupts-extended already explicitly provides the phandle to the
interrupt parent for the interrupt specifier, the interrupt-parent property
appears to be redundant and may trigger a dtc or schema validation warning.

> +
> +			mboxes = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP>;
> +
> +			#clock-cells = <0>;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-eliza-adsp-usb-v4-0-839936e89aca@oss.qualcomm.com?part=1