From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support
Date: Thu, 14 May 2026 04:04:53 +0000 [thread overview]
Message-ID: <20260514040453.D6654C2BCB7@smtp.kernel.org> (raw)
In-Reply-To: <20260513-eliza-adsp-usb-v4-3-839936e89aca@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string `qcom,eliza-pmic-glink` is used without being documented in the binding schema.
--
commit 9f076cccb73f2dcb88a58f126b6e3528a73fc2ba
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support
This commit enables USB and ADSP support for the Eliza MTP. It describes
the USB port, the eUSB2 repeater provided by the PM7550BA PMIC, and the
ADSP remoteproc firmware.
> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index 90f629800cb02..3e41c95edb28f 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
[ ... ]
> @@ -54,6 +57,44 @@ bi_tcxo_ao_div2: bi-tcxo-ao-div2-clk {
> };
> };
>
> + pmic-glink {
> + compatible = "qcom,eliza-pmic-glink",
> + "qcom,sm8550-pmic-glink",
> + "qcom,pmic-glink";
Is the "qcom,eliza-pmic-glink" string documented in the binding schema?
Using a new compatible string here without adding it to the corresponding
binding document usually causes make dtbs_check to report schema
validation warnings.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-eliza-adsp-usb-v4-0-839936e89aca@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-05-14 4:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 9:18 [PATCH v4 0/3] arm64: dts: qcom: eliza: Add ADSP and USB support Abel Vesa
2026-05-13 9:18 ` [PATCH v4 1/3] arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes Abel Vesa
2026-05-13 9:43 ` Konrad Dybcio
2026-05-14 3:30 ` sashiko-bot
2026-05-13 9:18 ` [PATCH v4 2/3] arm64: dts: qcom: Add Eliza-specific PM7550BA dtsi Abel Vesa
2026-05-13 9:18 ` [PATCH v4 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support Abel Vesa
2026-05-14 4:04 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514040453.D6654C2BCB7@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox