Re: [PATCH v3 1/7] dt-bindings: clock: qcom: Add video clock controller on Qualcomm Eliza SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The schema does not define the `power-domains` property, preventing valid device trees from describing the hardware correctly.
--

commit b3d73d9e0090a370ecfafe8774b6d58d6907b4db
Author: Taniya Das <taniya.das@oss.qualcomm.com>

dt-bindings: clock: qcom: Add video clock controller on Qualcomm Eliza SoC

This commit adds the Eliza video clock controller compatible string to the
existing Milos videocc binding. It also includes the corresponding
dt-bindings header for Eliza.

> Eliza Video clock controller is on CX and MX rails similar to Milos.

Since the commit message explicitly states the hardware is on the CX and MX
rails, shouldn't the power-domains property be defined in the binding?

> diff --git a/Documentation/devicetree/bindings/clock/qcom,milos-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,milos-videocc.yaml
> index 14c31efe1308a..6e3e4424af78a 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,milos-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,milos-videocc.yaml
[ ... ]
>  properties:
>    compatible:
> -    const: qcom,milos-videocc
> +    enum:
> +      - qcom,eliza-videocc
> +      - qcom,milos-videocc
>  
>    clocks:

The schema qcom,milos-videocc.yaml does not define the power-domains property,
and neither does its referenced schemas. Since the schema uses
unevaluatedProperties: false, any device tree node that correctly specifies
the power-domains property to model this hardware dependency will fail schema
validation.

This forces developers to omit the property from the device tree entirely. If
the required CX/MX power rails are not incidentally enabled by another
consumer, accessing the unpowered video clock controller registers during
probe or runtime could cause a synchronous external abort and kernel panic.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-eliza_mm_cc_v2-v3-0-b59c370dc281@oss.qualcomm.com?part=1