Re: [PATCH v3 3/7] dt-bindings: clock: qcom: Add support for CAMCC for Eliza

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] The schema fails to require `#power-domain-cells` for the `qcom,eliza-camcc` power domain provider, resulting in broken device tree nodes.
- [Medium] The schema does not define the `power-domains` property, preventing the representation of CX and MX power rails.
- [Medium] The schema incorrectly enforces the `#reset-cells` property for the `qcom,eliza-cambistmclkcc` block, which provides no resets.
--

commit 3a72590500ffe71717979089f9afaf963476d138
Author: Taniya Das <taniya.das@oss.qualcomm.com>

dt-bindings: clock: qcom: Add support for CAMCC for Eliza

This commit adds compatible strings and dt-bindings headers for the
Eliza camera and camera BIST clock controllers to the existing
Milos camcc binding.

> Eliza camera clock controller is on CX and MX rails similar to Milos.
> Add compatible string for Eliza camera and camera BIST clock

Since the controller relies on CX and MX power rails, does the schema
need to define the power-domains property?

The qcom,milos-camcc.yaml binding uses unevaluatedProperties: false and
does not define power-domains. Adding the property to a device tree node
will trigger schema validation errors.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> --- a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
[ ... ]
>  properties:
>    compatible:
> -    const: qcom,milos-camcc
> +    enum:
> +      - qcom,eliza-cambistmclkcc

The qcom,milos-camcc.yaml schema references qcom,gcc.yaml, which
unconditionally requires #reset-cells to be 1.

Since the qcom,eliza-cambistmclkcc block does not provide any resets, does
this incorrectly force device tree nodes to include a dummy #reset-cells
property to pass validation?

> +      - qcom,eliza-camcc

The added qcom,eliza-camcc.h header defines several power domains, making
this block a power domain provider.

Should the schema require the #power-domain-cells property for this
compatible string?

Without it, incomplete device tree nodes missing #power-domain-cells can
silently pass validation, which would cause runtime failures when consumer
IPs try to link to these domains.

> +      - qcom,milos-camcc
>  
>    clocks:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-eliza_mm_cc_v2-v3-0-b59c370dc281@oss.qualcomm.com?part=3