Re: [PATCH V6 07/11] iio: imu: inv_icm42607: Add Temp Support in icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The temperature sensor and high-power clock are left enabled indefinitely after a one-shot read.
--

commit 8d77083c202fdb58f8003d737a9eb92b429cb188
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Temp Support in icm42607

This commit adds functions for reading temperature sensor data.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_temp.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_temp.c
> new file mode 100644
> index 0000000000000..7e9cb072a0110
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_temp.c

[ ... ]

> +static int inv_icm42607_temp_read(struct inv_icm42607_state *st, s16 *temp)
> +{
> +	struct device *dev = regmap_get_device(st->map);
> +	__be16 *raw;
> +	int ret;
> +
> +	PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm);
> +	if (PM_RUNTIME_ACQUIRE_ERR(&pm))
> +		return -ENXIO;
> +
> +	guard(mutex)(&st->lock);
> +
> +	ret = inv_icm42607_set_temp_conf(st, true, NULL);
> +	if (ret)
> +		return ret;
> +
> +	raw = &st->buffer[0];
> +	ret = regmap_bulk_read(st->map, INV_ICM42607_REG_TEMP_DATA1, raw, sizeof(*raw));
> +	if (ret)
> +		return ret;
> +
> +	*temp = be16_to_cpup(raw);
> +	if (*temp == INV_ICM42607_DATA_INVALID)
> +		return -EINVAL;
> +
> +	return 0;
> +}

Does this leave the temperature sensor and high-power clock enabled
indefinitely after a one-shot read?

It looks like inv_icm42607_set_temp_conf() is called with true before
the read, which enables the sensor and disables the low-power RC oscillator,
but the sensor is never disabled again before returning.

While pm_runtime_autosuspend might eventually power down the device,
if another operation (like an accelerometer read) keeps the PM runtime active
before the autosuspend delay expires, the autosuspend will not happen.

Because other configuration functions preserve the existing st->conf.temp_en
state, the high-power clock and temperature sensor would remain permanently
active, leading to an unintended power draw.

Should there be a matching call to inv_icm42607_set_temp_conf() with false
after the read is complete?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512221634.256747-1-macroalpha82@gmail.com?part=7