Re: [PATCH v4 4/7] clk: qcom: videocc: Add video clock controller driver for Eliza

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] CLK_ELIZA_VIDEOCC specifies `default m if ARCH_QCOM` while related clock controller configs for the Eliza SoC family do not, creating an unintentional config imbalance.
--

commit 1383015319c741eb9fd0f648734c02b213d23ae0
Author: Taniya Das <taniya.das@oss.qualcomm.com>

clk: qcom: videocc: Add video clock controller driver for Eliza

This commit adds support for the video clock controller for video clients
to be able to request for videocc clocks on the Eliza platform.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index df21ef5ffd686..f44ec81560203 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -45,6 +45,16 @@ config CLK_ELIZA_TCSRCC
>  	  Support for the TCSR clock controller on Eliza devices.
>  	  Say Y if you want to use peripheral devices such as USB/PCIe/UFS.
>  
> +config CLK_ELIZA_VIDEOCC
> +	tristate "Eliza Video Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
> +	select CLK_ELIZA_GCC
> +	default m if ARCH_QCOM

Is it intentional for CLK_ELIZA_VIDEOCC to specify default m if ARCH_QCOM
while other related configs for the Eliza SoC family (like CLK_ELIZA_TCSRCC
shown above) do not?

Since CLK_ELIZA_VIDEOCC selects CLK_ELIZA_GCC, the default configuration will
build both the video and global clock controllers, while potentially leaving
other peripheral controllers disabled by default.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-eliza_mm_cc_v2-v4-0-e61b5434e8d9@oss.qualcomm.com?part=4