Re: [PATCH v4 7/7] arm64: dts: qcom: eliza: Add support for MM clock controllers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `#power-domain-cells = <1>;` property in the `camcc` device node.
--

commit cf4de2d4ed70ac27e6c99ee7bcb3cb5ce7c09353
Author: Taniya Das <taniya.das@oss.qualcomm.com>

arm64: dts: qcom: eliza: Add support for MM clock controllers

This commit adds device tree nodes for the multimedia clock controllers
(cambistmclkcc, camcc, videocc, gpucc) on the Qualcomm Eliza SoC.

> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> index 4a7a0ac40ce62..1a47eb2a86571 100644
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi

[ ... ]

> +		camcc: clock-controller@ade0000 {
> +			compatible = "qcom,eliza-camcc";
> +			reg = <0x0 0x0ade0000 0x0 0x20000>;
> +
> +			clocks = <&bi_tcxo_div2>,
> +				 <&sleep_clk>,
> +				 <&gcc GCC_CAMERA_AHB_CLK>;
> +
> +			#clock-cells = <1>;
> +			#reset-cells = <1>;
> +		};

Should this node also include a #power-domain-cells property?

The qcom,eliza-camcc driver registers Global Distributed Sync Controllers
(GDSCs) which act as power domains for downstream camera IP blocks.

Without the #power-domain-cells = <1>; property, downstream consumer nodes
might be unable to parse their power-domains phandles, which could leave the
camera hardware unpowered and lead to probe or runtime-pm failures.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-eliza_mm_cc_v2-v4-0-e61b5434e8d9@oss.qualcomm.com?part=7