[PATCH 1/1] dt-bindings: display: simple: add avic,tm097tdh02 panel

[PATCH 1/1] dt-bindings: display: simple: add avic,tm097tdh02 panel

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Add compatilbe string avic,tm097tdh02 for AVIC Optoelectronics 9.7".

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index fdf522a15d2ea..a8f057208e23d 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -63,6 +63,8 @@ properties:
       - auo,p320hvn03
         # Shanghai AVIC Optoelectronics 7" 1024x600 color TFT-LCD panel
       - avic,tm070ddh03
+        # Shanghai AVIC Optoelectronics 9.7" 1024x600 color TFT-LCD panel
+      - avic,tm097tdh02
         # BOE AV101HDT-a10 10.1" 1280x720 LVDS panel
       - boe,av101hdt-a10
         # BOE BP082WX1-100 8.2" WXGA (1280x800) LVDS panel
-- 
2.43.0

Re: [PATCH 1/1] dt-bindings: display: simple: add avic,tm097tdh02 panel

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit adds the `avic,tm097tdh02` compatible string to the device tree bindings schema but fails to add the corresponding driver match data in the `panel-simple` driver, while the schema incorrectly rejects fallback strings.
- [Low] Typo in the commit message: 'compatilbe'.
--

commit 6c3fff393da11c29533acb6535efaaa08a1b9910
Author: Frank Li <Frank.Li@nxp.com>

dt-bindings: display: simple: add avic,tm097tdh02 panel

This commit adds the compatible string for the AVIC Optoelectronics 9.7"
panel to the simple panel device tree bindings schema.

> dt-bindings: display: simple: add avic,tm097tdh02 panel
>
> Add compatilbe string avic,tm097tdh02 for AVIC Optoelectronics 9.7".

This isn't a bug, but there is a typo (compatilbe) in the commit message.

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3e41ed0ef5d51..80e7c6420b289 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -63,6 +63,8 @@ properties:
>        - auo,p320hvn03
>          # Shanghai AVIC Optoelectronics 7" 1024x600 color TFT-LCD panel
>        - avic,tm070ddh03
> +        # Shanghai AVIC Optoelectronics 9.7" 1024x600 color TFT-LCD panel
> +      - avic,tm097tdh02

Does this new compatible string also need to be added to the match table in
the panel-simple.c driver?

The panel-simple.yaml schema restricts the compatible property to a single
string since it is added under an enum. If a device tree uses only the
avic,tm097tdh02 string to pass schema validation, the driver will silently
fail to probe at runtime because the string is missing from the driver's
match table.

Conversely, if a device tree relies on a fallback string to ensure the driver
probes successfully, the schema validation will fail because it does not
currently accept an array of strings for this panel.

Should the schema be updated to allow a fallback string, or should the driver
be updated to match this standalone string directly?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515195935.2415466-1-Frank.Li@oss.nxp.com?part=1