Re: [PATCH v9 04/11] dt-bindings: iio: adc: hx711: add HX710B support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

On Mon, May 18, 2026 at 10:10:54PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The newly added `dvdd-supply` property is described as HX710B-specific but is not forbidden on HX711 nodes in the schema.
> --
> 
> commit e277e4c3f21226be9f52ecf29adbdc5f6f73f38d
> Author: Piyush Patle <piyushpatle228@gmail.com>
> 
> dt-bindings: iio: adc: hx711: add HX710B support
> 
> This commit adds support for the HX710B ADC chip. It adds the avia,hx710b
> compatible string, documents the HX710B-specific dvdd-supply and vref-supply
> properties, and updates the schema constraints.
> 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > index 9134bbe413796..b2b5c7bdf05e6 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> 
> [ ... ]
> 
> > @@ -53,6 +69,21 @@ properties:
> >      maximum: 2500000
> >      default: 400000
> >  
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          const: avia,hx710b
> > +    then:
> > +      properties:
> > +        vsup-supply: false
> > +        rate-gpios: false
> > +      required:
> > +        - vref-supply
> > +    else:
> > +      properties:
> > +        vref-supply: false
> 
> The commit message mentions documenting the HX710B-specific DVDD and VREF
> supplies. While vref-supply is explicitly forbidden on HX711 nodes in this
> else branch, dvdd-supply is not.
> 
> Does this schema unintentionally allow the dvdd-supply property on avia,hx711
> nodes? Should dvdd-supply: false also be added to this else branch?

No.

https://lore.kernel.org/all/20260512-frantic-finch-2b268bed4e15@spud/


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]