Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andreas Klinger <ak@it-klinger.de>,
	Andy Shevchenko <andy@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v9 04/11] dt-bindings: iio: adc: hx711: add HX710B support
Date: Tue, 26 May 2026 13:32:56 +0100	[thread overview]
Message-ID: <20260526133256.4b781fa6@jic23-huawei> (raw)
In-Reply-To: <CAMB+xkYUC-OqncD+SxOo9K36ZR9iC-5CFUs6wKojz2j+M24K4g@mail.gmail.com>

On Sun, 24 May 2026 08:15:27 +0530
Piyush Patle <piyushpatle228@gmail.com> wrote:

> On Wed, May 20, 2026 at 3:49 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Tue, 19 May 2026 03:32:20 +0530
> > Piyush Patle <piyushpatle228@gmail.com> wrote:
> >  
> > > Add the avia,hx710b compatible and document the HX710B-specific
> > > DVDD and VREF supplies.
> > >
> > > Add constraints that forbid HX711-only properties on HX710B nodes and
> > > require vref-supply for HX710B, then add a separate HX710B example.
> > >
> > > Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>  
> > FWIW the only thing Sashiko doesn't like is dvdd is enabled for the old
> > parts. Move it to the earlier supply adding patch for hx711 and we should
> > be good to go!
> >
> > Jonathan  
> 
> Because dvdd-supply now lands in 02/11 as a shared property, I will
> remove it from 04/11's properties block.  The allOf constraint in
> 04/11 does NOT gain a dvdd-supply: false in the else (HX711) branch
> DVDD is valid and meaningful for HX711 nodes too.  The only things
> forbidden for HX711 remain vref-supply (else branch); the only things
> forbidden for HX710B remain vsup-supply and rate-gpios (then branch).
> I think this will be a suitable approach, right ??

Yes. Sounds right to me.

Jonathan



  reply	other threads:[~2026-05-26 12:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 22:02 [PATCH v9 00/11] iio: adc: Add support for AVIA HX710B ADC Piyush Patle
2026-05-18 22:02 ` [PATCH v9 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-05-18 22:02 ` [PATCH v9 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-05-20 10:09   ` Jonathan Cameron
2026-05-24  2:42     ` Piyush Patle
2026-05-26 12:31       ` Jonathan Cameron
2026-05-18 22:02 ` [PATCH v9 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-05-18 22:02 ` [PATCH v9 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-05-18 22:10   ` sashiko-bot
2026-05-19 17:21     ` Conor Dooley
2026-05-20 10:19   ` Jonathan Cameron
2026-05-24  2:45     ` Piyush Patle
2026-05-26 12:32       ` Jonathan Cameron [this message]
2026-05-18 22:02 ` [PATCH v9 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-05-18 22:02 ` [PATCH v9 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-05-18 22:30   ` sashiko-bot
2026-05-20 10:23   ` Jonathan Cameron
2026-05-18 22:02 ` [PATCH v9 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-05-18 22:02 ` [PATCH v9 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset Piyush Patle
2026-05-20 10:24   ` Jonathan Cameron
2026-05-24  2:47     ` Piyush Patle
2026-05-18 22:02 ` [PATCH v9 09/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-05-18 22:02 ` [PATCH v9 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-05-18 22:41   ` sashiko-bot
2026-05-18 22:02 ` [PATCH v9 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-05-18 22:39   ` sashiko-bot
2026-05-20 10:31   ` Jonathan Cameron
2026-05-24  2:55     ` Piyush Patle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526133256.4b781fa6@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=piyushpatle228@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox