Re: [PATCH v2 2/2] arm64: renesas: r8a78000-ironhide: enable to use SCMI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds an include directive for `<dt-bindings/soc/renesas,r8a78000-mfis.h>`, but this header is not included in the commit and does not exist in the repository.
--

commit 12e4bb3b81767937e835c191fd20007f6b57db69
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

arm64: renesas: r8a78000-ironhide: enable to use SCMI

This commit enables SCMI via MFIS-SCP and the STCM transport area to manage
clocks on the r8a78000-ironhide platform.

> diff --git a/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> index a721734fbd5d0..86bbe5fbb118a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> @@ -6,6 +6,7 @@
>   */
>  
>  /dts-v1/;
> +#include <dt-bindings/soc/renesas,r8a78000-mfis.h>

Is the dt-bindings/soc/renesas,r8a78000-mfis.h header missing from this
patch? The file doesn't seem to be included in the commit or currently
present in the repository, which causes a build failure during the C
preprocessing step.

[ ... ]

> @@ -20,6 +21,23 @@ chosen {
>  		stdout-path = "serial0:1843200n8";
>  	};
>  
> +	firmware {
> +		scmi: scmi {
> +			compatible = "arm,scmi";
> +			mboxes = <&mfis_scp 2 MFIS_CHANNEL_TX>, <&mfis_scp 2 MFIS_CHANNEL_RX>;

Are MFIS_CHANNEL_TX and MFIS_CHANNEL_RX defined anywhere else? Without the
header file included above, these macros remain undefined.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519074702.3308-4-wsa+renesas@sang-engineering.com?part=2