Re: [PATCH v4 3/8] arm64: dts: renesas: rzv2h: Add audio clock inputs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Newly added fixed-clock nodes use a deprecated naming convention that will trigger dtbs_check warnings.
--

commit cf2cd1c875fd06adde5a2a08dd0af97c4fa1ae15
Author: John Madieu <john.madieu.xa@bp.renesas.com>

arm64: dts: renesas: rzv2h: Add audio clock inputs

This commit models optional external audio clock inputs as CPG input clocks
for RZ/V2H family SoCs, allowing the Audio Clock Generator (ADG) to derive
internal audio clocks. The clock frequencies are left at zero to be overridden
in board DTS files.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> index 95a4e30a064d1..eedc5bb933b7b 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> @@ -14,6 +14,20 @@ / {
>  	#size-cells = <2>;
>  	interrupt-parent = <&gic>;
>  
> +	audio_clkb: audio-clkb {

[Severity: Low]
Will this node name trigger dtbs_check warnings?

According to the fixed-clock device tree bindings, node names should match the
pattern '^clock-([0-9]+|[a-z0-9-]+)$'. The "audio-clkb" name falls under the
'any name allowed' fallback, which is explicitly marked as deprecated in the
schema.

While this matches the style of the pre-existing "audio-clk" node, adding new
nodes with deprecated names might not be desired.

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		/* This value must be overridden by the board */
> +		clock-frequency = <0>;
> +	};
> +
> +	audio_clkc: audio-clkc {

[Severity: Low]
Will this node name also trigger dtbs_check warnings for the same reason?

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		/* This value must be overridden by the board */
> +		clock-frequency = <0>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525110603.4018170-1-john.madieu.xa@bp.renesas.com?part=3