Re: [PATCH v4 7/8] arm64: dts: renesas: rzg3e-smarc-som: add audio pinmux definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree node `sound_clk` uses an underscore instead of a hyphen, violating naming conventions.
--

commit d0daff3ab55c18eb7640dc053ae11aaa9c14d357
Author: John Madieu <john.madieu.xa@bp.renesas.com>

arm64: dts: renesas: rzg3e-smarc-som: add audio pinmux definitions

This commit adds pinmux definitions for the SSI3 and SSI4 audio interfaces
on the RZ/G3E SMARC SoM. It configures the sound clock pins and the sound
data and control pins.

> diff --git a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> index 493f6783d5833..f4532a06cc31d 100644
> --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
[ ... ]
> @@ -353,6 +353,18 @@ sd2-pwen {
>  		};
>  	};
>  
> +	sound_clk_pins: sound_clk {

[Severity: Low]
This isn't a bug, but should this node name use a hyphen instead of an
underscore?

According to the Devicetree specification, node names should use hyphens
rather than underscores to separate words. Using an underscore here might
trigger compiler warnings for node_name_chars_strict. Renaming the node to
sound-clk would align with standard DT conventions.

> +		pinmux = <RZG3E_PORT_PINMUX(4, 2, 8)>, /* AUDIO_CLKB */
> +			 <RZG3E_PORT_PINMUX(4, 3, 8)>; /* AUDIO_CLKC */
> +	};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525110603.4018170-1-john.madieu.xa@bp.renesas.com?part=7