Re: [PATCH v2 18/24] arm64: dts: qcom: talos: Reduce OS PDC DRV span to 0x10000

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Reducing the PDC register span to 0x10000 causes the qcom-pdc driver to emit a boot warning and override the size back to 0x30000, negating the purpose of the patch.
--

commit d70fb9cd4a6ef5ac1791e6576ca81f3526300257
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

arm64: dts: qcom: talos: Reduce OS PDC DRV span to 0x10000

This commit reduces the OS PDC DRV register window size for talos in the
device tree. It changes the first reg entry size from 0x30000 to 0x10000.

> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
> index ff5afbfce2a47..6f6c9fe1758b1 100644
> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
> @@ -4529,7 +4529,7 @@ dispcc: clock-controller@af00000 {
>  
>  		pdc: interrupt-controller@b220000 {
>  			compatible = "qcom,qcs615-pdc", "qcom,pdc";
> -			reg = <0x0 0x0b220000 0x0 0x30000>,
> +			reg = <0x0 0x0b220000 0x0 0x10000>,

[Severity: Medium]
Will this regression cause a boot warning and be overridden by the driver?

Looking at drivers/irqchip/qcom-pdc.c, the driver enforces a minimum region
size of 0x30000:

#define QCOM_PDC_SIZE 0x30000
...
	res_size = max_t(resource_size_t, resource_size(&res), QCOM_PDC_SIZE);
	if (res_size > resource_size(&res))
		pr_warn("%pOF: invalid reg size, please fix DT\n", node);

Because the device tree size is now smaller than QCOM_PDC_SIZE, the driver
will print this warning on every boot, and will still ioremap the full
0x30000 bytes anyway.

Does the qcom-pdc driver need an update to handle the smaller 0x10000 size
properly alongside this device tree change?

>  			      <0x0 0x17c000f0 0x0 0x64>;
>  			qcom,pdc-ranges = <0 480 94>, <94 609 31>, <125 63 1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527094333.2311731-1-mukesh.ojha@oss.qualcomm.com?part=18