Re: [PATCH v2 02/24] arm64: dts: qcom: sdm845: Reduce OS PDC DRV span to 0x10000

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Reducing the PDC `reg` size to 0x10000 in the device tree triggers a kernel warning on boot and fails to reduce the actually mapped memory window due to driver hardcoding.
--

commit 525b0faef29c12db278a9396c520eabc83c6363b
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

arm64: dts: qcom: sdm845: Reduce OS PDC DRV span to 0x10000

This commit reduces the OS PDC DRV register window size from 0x30000 to
0x10000 in the sdm845 device tree.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -5102,7 +5102,7 @@ dispcc: clock-controller@af00000 {
>  
>  		pdc_intc: interrupt-controller@b220000 {
>  			compatible = "qcom,sdm845-pdc", "qcom,pdc";
> -			reg = <0 0x0b220000 0 0x30000>;
> +			reg = <0 0x0b220000 0 0x10000>;

[Severity: Medium]
Will reducing this register size trigger a boot warning from the qcom-pdc
driver?

Looking at the driver implementation in drivers/irqchip/qcom-pdc.c, the
probe function appears to enforce a minimum mapping size of 0x30000 via a
hardcoded QCOM_PDC_SIZE limit.

If the device tree specifies a smaller size, does the driver emit a warning
like "invalid reg size, please fix DT" and then map 0x30000 bytes anyway?

Since there are no corresponding driver patches in this series to adjust
QCOM_PDC_SIZE, will this result in a persistent boot-time warning without
actually reducing the mapped memory window?

>  			qcom,pdc-ranges = <0 480 94>, <94 609 15>, <115 630 7>;
>  			#interrupt-cells = <2>;
>  			interrupt-parent = <&intc>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527094333.2311731-1-mukesh.ojha@oss.qualcomm.com?part=2