Re: [PATCH v2 10/24] arm64: dts: qcom: sm8350: Reduce OS PDC DRV span to 0x10000

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Reducing the PDC register size to 0x10000 in the device tree triggers a spurious boot warning because the irq-qcom-pdc driver hardcodes a minimum size expectation of 0x30000.
--

commit 05076204b4916b97559866917e2826b903983008
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

arm64: dts: qcom: sm8350: Reduce OS PDC DRV span to 0x10000

The commit reduces the size of the first reg entry for the OS PDC DRV register
window on sm8350 from 0x30000 to 0x10000 bytes.

> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index c830953156ec6..ca235ce899c92 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -3174,7 +3174,7 @@ dispcc: clock-controller@af00000 {
>  
>  		pdc: interrupt-controller@b220000 {
>  			compatible = "qcom,sm8350-pdc", "qcom,pdc";
> -			reg = <0 0x0b220000 0 0x30000>, <0 0x17c000f0 0 0x60>;
> +			reg = <0 0x0b220000 0 0x10000>, <0 0x17c000f0 0 0x60>;

[Severity: Medium]
Will this change trigger a spurious boot warning in the driver?

Looking at drivers/irqchip/qcom-pdc.c, the driver calculates the resource
size using a hardcoded QCOM_PDC_SIZE of 0x30000:

    res_size = max_t(resource_size_t, resource_size(&res), QCOM_PDC_SIZE);
    if (res_size > resource_size(&res))
        pr_warn("%pOF: invalid reg size, please fix DT\n", node);

Since this patch reduces the device tree reg size to 0x10000, it appears
this condition will evaluate to true and print a warning on every boot,
even though the driver overrides the map size anyway.

Does the driver need to be updated alongside this device tree change to
avoid polluting dmesg?

>  			qcom,pdc-ranges = <0 480 40>, <40 140 14>, <54 263 1>,   <55 306 4>,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527094333.2311731-1-mukesh.ojha@oss.qualcomm.com?part=10