Re: [PATCH] dt-bindings: iio: adc: Add schema for AD7816/7/8 digital temperature sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing conditional device tree schema constraints for `busy-gpios`
--

commit b1de64cf7a950c655f529289b45b50bb4b5224f5
Author: Taha Narimani <tahanarimani3443@gmail.com>

dt-bindings: iio: adc: Add schema for AD7816/7/8 digital temperature sensor

This commit adds the YAML device tree binding schema for the Analog Devices
AD7816, AD7817, and AD7818 temperature sensors. It defines the required
properties and resolves checkpatch warnings for undocumented bindings.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7816.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7816.yaml
> new file mode 100644
> index 0000000000000..7f6a3e5dfcf40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7816.yaml
[ ... ]
> +  busy-gpios:
> +    maxItems: 1
> +    description: GPIO connected to the BUSY pin. Only applicable for AD7816 and AD7817.
> +
> +  interrupts:
> +    maxItems: 1
> +    description: OTI (Over Temperature Indicator) interrupt.
> +
> +required:
> +  - compatible
> +  - reg
> +  - rdwr-gpios
> +  - convert-gpios
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#

[Severity: Low]
Does this binding need conditional rules to enforce the busy-gpios
requirement?

The property description states that busy-gpios is only applicable for
AD7816 and AD7817. Because it lacks structural enforcement, an adi,ad7818
node could incorrectly include a busy-gpios property and pass schema
validation, while an adi,ad7816 node could incorrectly omit it.

Could an if-then conditional block be added here to restrict busy-gpios
usage based on the compatible string? The ad7816 driver strictly requires
this GPIO for the AD7816 and AD7817 variants and will fail to probe with
-ENOENT if it is missing.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530133126.54460-1-tahanarimani3443@gmail.com?part=1