devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: "Taha Narimani" <tahanarimani3443@gmail.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: iio: adc: Add schema for AD7816/7/8 digital temperature sensor
Date: Sun, 31 May 2026 09:53:57 +0100	[thread overview]
Message-ID: <20260531095357.29385752@jic23-huawei> (raw)
In-Reply-To: <20260531-mama-demanding-edf694ceb099@spud>

On Sun, 31 May 2026 00:11:44 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Sat, May 30, 2026 at 03:58:17PM +0100, Jonathan Cameron wrote:
> > On Sat, 30 May 2026 13:53:00 +0000  
> > > +
> > > +  interrupts:
> > > +    maxItems: 1
> > > +    description: OTI (Over Temperature Indicator) interrupt.  
> 
> > > +unevaluatedProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    #include <dt-bindings/gpio/gpio.h>
> > > +    #include <dt-bindings/interrupt-controller/irq.h>
> > > +
> > > +    spi {
> > > +        #address-cells = <1>;
> > > +        #size-cells = <0>;
> > > +
> > > +        adc@0 {
> > > +            compatible = "adi,ad7816";
> > > +            reg = <0>;
> > > +            spi-max-frequency = <1000000>;
> > > +            rdwr-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
> > > +            convert-gpios = <&gpio 6 GPIO_ACTIVE_HIGH>;
> > > +            busy-gpios = <&gpio 7 GPIO_ACTIVE_HIGH>;
> > > +            interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> > > +            interrupt-parent = <&gpio>;  
> > 
> > You don't have any interrupts in the binding. So this shouldn't
> > pass testing.  
> 
> There is an interrupts property in the binding, unless you meant
> something else?
Huh.  More coffee needed. Odd I missed it!  

J
> 
> >   
> > > +        };
> > > +    };  
> >   


      reply	other threads:[~2026-05-31  8:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 13:31 [PATCH] dt-bindings: iio: adc: Add schema for AD7816/7/8 digital temperature sensor Taha Narimani
2026-05-30 10:43 ` sashiko-bot
2026-05-30 13:53 ` Taha Narimani
2026-05-30 11:06   ` sashiko-bot
     [not found]     ` <CAEsNvj8Q3n3-tuPhANfRjUfqrnCtzfguuRKL0OrwCEEkSXrUaw@mail.gmail.com>
2026-05-30 11:21       ` Taha Narimani
2026-05-30 14:58   ` Jonathan Cameron
2026-05-30 23:11     ` Conor Dooley
2026-05-31  8:53       ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260531095357.29385752@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=tahanarimani3443@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).