Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yassine Oudjana" <yassine.oudjana@gmail.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v8 2/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Improve pinctrl subnode and property descriptions
Date: Sat, 30 May 2026 15:09:13 +0000	[thread overview]
Message-ID: <20260530150914.189C81F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260530145800.1029920-3-y.oudjana@protonmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Commit message inaccuracy regarding capitalization of the pinmux description.
--

commit a7cfb3754d286ad6671b0ee2b11ae49fbb660dff
Author: Yassine Oudjana <y.oudjana@protonmail.com>

dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Improve pinctrl subnode and property descriptions

This commit updates the Mediatek MT6779 pinctrl binding descriptions to fix
grammar, wrap lines at 80 characters, and remove unneeded literal style
indicators.

> Change "subnodes" to "subnode" in subnode description for better
> grammatical accuracy, capitalize pinmux description, wrap all descriptions
> at 80 characters, and remove literal style indicators from descriptions
> that don't need their new lines preserved.

[Severity: Low]
The commit message mentions it will "capitalize pinmux description". Is this
intended change missing from the patch? 

Looking at the diff for the pinmux description, the text was wrapped to 80
characters, but terms like "gpio" were left uncapitalized.

> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml

[ ... ]

>              description:
>                Integer array, represents gpio pin number and mux setting.
>                Supported pin number and mux varies for different SoCs, and are
> -              defined as macros in dt-bindings/pinctrl/<soc>-pinfunc.h directly.
> +              defined as macros in dt-bindings/pinctrl/<soc>-pinfunc.h
> +              directly.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530145800.1029920-1-y.oudjana@protonmail.com?part=2

  reply	other threads:[~2026-05-30 15:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 14:57 [PATCH v8 0/6] MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support Yassine Oudjana
2026-05-30 14:57 ` [PATCH v8 1/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Pull pinctrl node changes from MT6795 document Yassine Oudjana
2026-05-30 14:57 ` [PATCH v8 2/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Improve pinctrl subnode and property descriptions Yassine Oudjana
2026-05-30 15:09   ` sashiko-bot [this message]
2026-05-30 14:57 ` [PATCH v8 3/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 Yassine Oudjana
2026-05-30 15:17   ` sashiko-bot
2026-05-30 14:57 ` [PATCH v8 4/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6765 pin controller Yassine Oudjana
2026-05-30 15:29   ` sashiko-bot
2026-05-30 14:57 ` [PATCH v8 5/6] dt-bindings: pinctrl: mediatek: Add bindings for MT6735 " Yassine Oudjana
2026-05-30 15:35   ` sashiko-bot
2026-05-30 14:57 ` [PATCH v8 6/6] pinctrl: mediatek: Add MT6735 pinctrl driver Yassine Oudjana
2026-05-30 15:55   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260530150914.189C81F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yassine.oudjana@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox