Re: [PATCH v8 5/6] dt-bindings: pinctrl: mediatek: Add bindings for MT6735 pin controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces pinmux macros and a driver for the MT6735 pin controller but completely omits documenting the corresponding compatible strings (e.g., `mediatek,mt6735-pinctrl` and `mediatek,mt6735m-pinctrl`) in a YAML schema file (such as `mediatek,mt6779-pinctrl.yaml`).
--

commit 07ce040d313a0955bafec476cf793da45ce851b5
Author: Yassine Oudjana <y.oudjana@protonmail.com>

dt-bindings: pinctrl: mediatek: Add bindings for MT6735 pin controller

This commit adds device tree bindings for the MT6735 pin controller.
It introduces macros corresponding to unique pin-function combinations to be
used as values for the pinmux property.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index b539be153f6a4..1e833d0e7f47a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21083,6 +21083,12 @@ F:	drivers/pinctrl/mediatek/pinctrl-rt2880.c
>  F:	drivers/pinctrl/mediatek/pinctrl-rt305x.c
>  F:	drivers/pinctrl/mediatek/pinctrl-rt3883.c
>  
> +PIN CONTROLLER - MEDIATEK MT6735
> +M:	Yassine Oudjana <y.oudjana@protonmail.com>
> +L:	linux-mediatek@lists.infradead.org (moderated for non-subscribers)
> +S:	Maintained
> +F:	include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h
> +

[Severity: Low]
Does this patch omit the YAML schema file for the binding?

The patch introduces the pinmux macros for the MT6735 pin controller, but it
doesn't seem to document the corresponding compatible strings (e.g.,
mediatek,mt6735-pinctrl) in a YAML schema file.

Failing to provide the compatible string in the schema will cause device tree
nodes using this hardware to either bypass strict dtbs_check validation or
generate warnings.

Should the YAML schema update be included alongside this header?

>  PIN CONTROLLER - MICROCHIP AT91
>  M:	Ludovic Desroches <ludovic.desroches@microchip.com>

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530145800.1029920-1-y.oudjana@protonmail.com?part=5